From: "Shevchenko, Andriy" <andriy.shevchenko@intel.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"anton.wuerfel@fau.de" <anton.wuerfel@fau.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mail@maciej.szmigiero.name" <mail@maciej.szmigiero.name>,
"desmondl@broadcom.com" <desmondl@broadcom.com>,
"Zha, Qipeng" <qipeng.zha@intel.com>,
"heikki.krogerus@linux.intel.com"
<heikki.krogerus@linux.intel.com>,
"long.wanglong@huawei.com" <long.wanglong@huawei.com>,
"soeren.grunewald@desy.de" <soeren.grunewald@desy.de>,
"deller@gmx.de" <deller@gmx.de>,
"jslaby@suse.com" <jslaby@suse.com>,
"phillip.raffeck@fau.de" <phillip.raffeck@fau.de>,
"paul.burton@imgtec.com" <paul.burton@imgtec.com>,
"hpeter@gmail.com" <hpeter@gmail.com>,
"ralf@linux-mips.org" <ralf@linux-mips.org>,
"linux-kernel@i4.cs.fau.de" <linux-kernel@i4.cs.fau.de>,
"mans@mansr.com" <mans@mansr.com>,
"adam.lee@canonical.com" <adam.lee@canonical.com>,
"jejb@parisc-linux.org" <jejb@parisc-linux.org>,
"linux-parisc@vger.kernel.org" <linux-paris
Subject: Re: [PATCH v4 01/13] tty: serial: 8250: Fix whitespace errors
Date: Mon, 11 Jan 2016 12:50:18 +0000 [thread overview]
Message-ID: <1452516646.26146.22.camel@intel.com> (raw)
In-Reply-To: <1452515294.26146.10.camel@linux.intel.com>
T24gTW9uLCAyMDE2LTAxLTExIGF0IDE0OjI4ICswMjAwLCBBbmR5IFNoZXZjaGVua28gd3JvdGU6
DQo+IE9uIEZyaSwgMjAxNi0wMS0wOCBhdCAxODo0MyArMDEwMCwgQW50b24gV3VlcmZlbCB3cm90
ZToNCj4gPiBUaGlzIHBhdGNoIGZpeGVzIHdoaXRlc3BhY2UgZXJyb3JzIHJlcG9ydGVkIGJ5IGNo
ZWNrcGF0Y2ggdG8NCj4gPiBpbmNyZWFzZQ0KPiA+IHJlYWRhYmlsaXR5LiBNYWluIGZvY3VzIGlz
IG9uIG1pc3Npbmcgc3BhY2VzIGFmdGVyIGNvbW1hcyBpbg0KPiA+IGZ1bmN0aW9uIGhlYWRlcnMg
YW5kIG1hY3JvcyAobGlrZSBmb28sYmFyIGVkaXRlZCB0byBmb28sIGJhcikuDQo+ID4gDQo+ID4g
U2lnbmVkLW9mZi1ieTogQW50b24gV8O8cmZlbCA8YW50b24ud3VlcmZlbEBmYXUuZGU+DQo+ID4g
U2lnbmVkLW9mZi1ieTogUGhpbGxpcCBSYWZmZWNrIDxwaGlsbGlwLnJhZmZlY2tAZmF1LmRlPg0K
PiA+IENDOiBsaW51eC1rZXJuZWxAaTQuY3MuZmF1LmRlDQo+IA0KPiBDYzogbG9va3MgbW9yZSBz
dGFuZGFyZC4NCj4gDQo+ID4gLS0tIGEvZHJpdmVycy90dHkvc2VyaWFsLzgyNTAvODI1MF9hY2Nl
bnQuYw0KPiA+ICsrKyBiL2RyaXZlcnMvdHR5L3NlcmlhbC84MjUwLzgyNTBfYWNjZW50LmMNCj4g
PiBAQCAtMTAsNyArMTAsNyBAQA0KPiA+IMKgI2luY2x1ZGUgPGxpbnV4L2luaXQuaD4NCj4gPiDC
oCNpbmNsdWRlIDxsaW51eC9zZXJpYWxfODI1MC5oPg0KPiA+IMKgDQo+ID4gLSNkZWZpbmUgUE9S
VChfYmFzZSxfaXJxKQkJCQlcDQo+ID4gKyNkZWZpbmUgUE9SVChfYmFzZSwgX2lycSkJCQkJXA0K
PiA+IMKgCXsJCQkJCQlcDQo+ID4gwqAJCS5pb2Jhc2UJCT0gX2Jhc2UsCQlcDQo+ID4gwqAJCS5p
cnEJCT0gX2lycSwJCQkNCj4gPiBcDQoNCjgyNTBfUE9SVCgpDQoNCj4gPiANCj4gDQo+IFdoaWxl
IHRob3NlIGFyZSBva2F5LCBJIHdvdWxkIHN1Z2dlc3QgdG8gbWFrZSBhIG1hY3JvIGluDQo+IGRy
aXZlcnMv4oCmLzgyNTAuaCBvbmUgZm9yIGFsbCwgc29tZXRoaW5nIGxpa2UgdGhpczoNCj4gDQo+
ICNkZWZpbmUgODI1MF9QT1JUX0ZMQUdTKF9iYXNlLCBfaXJxLCBfZmxhZ3MpDQo+IOKApg0KPiAJ
LmZsYWdzwqDCoMKgwqDCoMKgwqDCoMKgwqA9IFVQRl9CT09UX0FVVE9DT05GIHwgKF9mbGFncykg
XA0KPiANCj4gI2RlZmluZSA4MjUwX1BPUlQoX2Jhc2UsIF9pcnEpCTgyNTBfUE9SVF9GTEFHUyhf
YmFzZSwgX2lycSwgMCkNCj4gDQo+IEFuZCB1c2UgaXQuDQoNCiNkZWZpbmUgODI1MF9GT1VSUE9S
VChfYmFzZSwgX2lycSkJODI1MF9QT1JUX0ZMQUdTKF9iYXNlLCBfaXJxLA0KVVBGX0ZPVVJQT1JU
KQ0KDQo+ID4gLS0tIGEvZHJpdmVycy90dHkvc2VyaWFsLzgyNTAvODI1MF9mb3VycG9ydC5jDQo+
ID4gKysrIGIvZHJpdmVycy90dHkvc2VyaWFsLzgyNTAvODI1MF9mb3VycG9ydC5jDQo+ID4gQEAg
LTEwLDcgKzEwLDcgQEANCj4gPiDCoCNpbmNsdWRlIDxsaW51eC9pbml0Lmg+DQo+ID4gwqAjaW5j
bHVkZSA8bGludXgvc2VyaWFsXzgyNTAuaD4NCj4gPiDCoA0KPiA+IC0jZGVmaW5lIFBPUlQoX2Jh
c2UsX2lycSkJCQkJCQkNCj4gPiBcDQo+ID4gKyNkZWZpbmUgUE9SVChfYmFzZSwgX2lycSkJCQkJ
CQkNCj4gPiBcDQo+ID4gwqAJewkJCQkJCQkJDQo+ID4gXA0KPiA+IMKgCQkuaW9iYXNlCQk9IF9i
YXNlLAkJCQ0KPiA+IAlcDQo+ID4gwqAJCS5pcnEJCT0gX2lycSwJCQkNCj4gPiAJDQo+ID4gCVwN
Cg0KODI1MF9GT1VSUE9SVCgpDQoNCi0tIA0KQW5keSBTaGV2Y2hlbmtvIDxhbmRyaXkuc2hldmNo
ZW5rb0BpbnRlbC5jb20+DQpJbnRlbCBGaW5sYW5kIE95DQotLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KSW50ZWwgRmlu
bGFuZCBPeQpSZWdpc3RlcmVkIEFkZHJlc3M6IFBMIDI4MSwgMDAxODEgSGVsc2lua2kgCkJ1c2lu
ZXNzIElkZW50aXR5IENvZGU6IDAzNTc2MDYgLSA0IApEb21pY2lsZWQgaW4gSGVsc2lua2kgCgpU
aGlzIGUtbWFpbCBhbmQgYW55IGF0dGFjaG1lbnRzIG1heSBjb250YWluIGNvbmZpZGVudGlhbCBt
YXRlcmlhbCBmb3IKdGhlIHNvbGUgdXNlIG9mIHRoZSBpbnRlbmRlZCByZWNpcGllbnQocykuIEFu
eSByZXZpZXcgb3IgZGlzdHJpYnV0aW9uCmJ5IG90aGVycyBpcyBzdHJpY3RseSBwcm9oaWJpdGVk
LiBJZiB5b3UgYXJlIG5vdCB0aGUgaW50ZW5kZWQKcmVjaXBpZW50LCBwbGVhc2UgY29udGFjdCB0
aGUgc2VuZGVyIGFuZCBkZWxldGUgYWxsIGNvcGllcy4K
WARNING: multiple messages have this Message-ID (diff)
From: "Shevchenko, Andriy" <andriy.shevchenko@intel.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"anton.wuerfel@fau.de" <anton.wuerfel@fau.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mail@maciej.szmigiero.name" <mail@maciej.szmigiero.name>,
"desmondl@broadcom.com" <desmondl@broadcom.com>,
"Zha, Qipeng" <qipeng.zha@intel.com>,
"heikki.krogerus@linux.intel.com"
<heikki.krogerus@linux.intel.com>,
"long.wanglong@huawei.com" <long.wanglong@huawei.com>,
"soeren.grunewald@desy.de" <soeren.grunewald@desy.de>,
"deller@gmx.de" <deller@gmx.de>,
"jslaby@suse.com" <jslaby@suse.com>,
"phillip.raffeck@fau.de" <phillip.raffeck@fau.de>,
"paul.burton@imgtec.com" <paul.burton@imgtec.com>,
"hpeter@gmail.com" <hpeter@gmail.com>,
"ralf@linux-mips.org" <ralf@linux-mips.org>,
"linux-kernel@i4.cs.fau.de" <linux-kernel@i4.cs.fau.de>,
"mans@mansr.com" <mans@mansr.com>,
"adam.lee@canonical.com" <adam.lee@canonical.com>,
"jejb@parisc-linux.org" <jejb@parisc-linux.org>,
"linux-parisc@vger.kernel.org" <linux-parisc@vger.kernel.org>,
"peter@hurleysoftware.com" <peter@hurleysoftware.com>,
"matt.redfearn@imgtec.com" <matt.redfearn@imgtec.com>,
"k.kozlowski@samsung.com" <k.kozlowski@samsung.com>
Subject: Re: [PATCH v4 01/13] tty: serial: 8250: Fix whitespace errors
Date: Mon, 11 Jan 2016 12:50:18 +0000 [thread overview]
Message-ID: <1452516646.26146.22.camel@intel.com> (raw)
In-Reply-To: <1452515294.26146.10.camel@linux.intel.com>
On Mon, 2016-01-11 at 14:28 +0200, Andy Shevchenko wrote:
> On Fri, 2016-01-08 at 18:43 +0100, Anton Wuerfel wrote:
> > This patch fixes whitespace errors reported by checkpatch to
> > increase
> > readability. Main focus is on missing spaces after commas in
> > function headers and macros (like foo,bar edited to foo, bar).
> >
> > Signed-off-by: Anton Würfel <anton.wuerfel@fau.de>
> > Signed-off-by: Phillip Raffeck <phillip.raffeck@fau.de>
> > CC: linux-kernel@i4.cs.fau.de
>
> Cc: looks more standard.
>
> > --- a/drivers/tty/serial/8250/8250_accent.c
> > +++ b/drivers/tty/serial/8250/8250_accent.c
> > @@ -10,7 +10,7 @@
> > #include <linux/init.h>
> > #include <linux/serial_8250.h>
> >
> > -#define PORT(_base,_irq) \
> > +#define PORT(_base, _irq) \
> > { \
> > .iobase = _base, \
> > .irq = _irq,
> > \
8250_PORT()
> >
>
> While those are okay, I would suggest to make a macro in
> drivers/…/8250.h one for all, something like this:
>
> #define 8250_PORT_FLAGS(_base, _irq, _flags)
> …
> .flags = UPF_BOOT_AUTOCONF | (_flags) \
>
> #define 8250_PORT(_base, _irq) 8250_PORT_FLAGS(_base, _irq, 0)
>
> And use it.
#define 8250_FOURPORT(_base, _irq) 8250_PORT_FLAGS(_base, _irq,
UPF_FOURPORT)
> > --- a/drivers/tty/serial/8250/8250_fourport.c
> > +++ b/drivers/tty/serial/8250/8250_fourport.c
> > @@ -10,7 +10,7 @@
> > #include <linux/init.h>
> > #include <linux/serial_8250.h>
> >
> > -#define PORT(_base,_irq)
> > \
> > +#define PORT(_base, _irq)
> > \
> > {
> > \
> > .iobase = _base,
> > \
> > .irq = _irq,
> >
> > \
8250_FOURPORT()
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
next prev parent reply other threads:[~2016-01-11 12:50 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 17:43 [PATCH v4 00/13] tty: serial: 8250: Fix checkpatch warnings Anton Wuerfel
2016-01-08 17:43 ` [PATCH v4 01/13] tty: serial: 8250: Fix whitespace errors Anton Wuerfel
2016-01-08 17:43 ` Anton Wuerfel
2016-01-11 12:28 ` Andy Shevchenko
2016-01-11 12:28 ` Andy Shevchenko
2016-01-11 12:50 ` Shevchenko, Andriy [this message]
2016-01-11 12:50 ` Shevchenko, Andriy
2016-01-11 12:54 ` Måns Rullgård
2016-01-11 12:54 ` Måns Rullgård
2016-01-11 13:03 ` Shevchenko, Andriy
2016-01-11 13:03 ` Shevchenko, Andriy
2016-01-08 17:43 ` [PATCH v4 02/13] tty: serial: 8250: Replace spaces with tabs Anton Wuerfel
2016-01-08 17:43 ` Anton Wuerfel
2016-01-08 17:43 ` [PATCH v4 03/13] tty: serial: 8250: Fix braces after struct Anton Wuerfel
2016-01-08 17:43 ` Anton Wuerfel
2016-01-08 17:43 ` [PATCH v4 04/13] tty: serial: 8250: Fix multiline comment style Anton Wuerfel
2016-01-08 17:43 ` Anton Wuerfel
2016-01-08 17:43 ` [PATCH v4 05/13] tty: serial: 8250: Remove else after return Anton Wuerfel
2016-01-08 17:43 ` Anton Wuerfel
2016-01-11 12:30 ` Andy Shevchenko
2016-01-11 12:30 ` Andy Shevchenko
2016-01-08 17:43 ` [PATCH v4 06/13] tty: serial: 8250: Move EXPORT_SYMBOL to function Anton Wuerfel
2016-01-08 17:43 ` Anton Wuerfel
2016-01-08 17:43 ` [PATCH v4 07/13] tty: serial: 8250: Fix line continuation warning Anton Wuerfel
2016-01-08 17:43 ` Anton Wuerfel
2016-01-08 17:43 ` [PATCH v4 08/13] tty: serial: 8250: Add parentheses to macro Anton Wuerfel
2016-01-08 17:43 ` Anton Wuerfel
2016-01-08 17:43 ` [PATCH v4 09/13] tty: serial: 8250: Fix multi-line strings Anton Wuerfel
2016-01-08 17:43 ` Anton Wuerfel
2016-01-08 17:43 ` [PATCH v4 10/13] tty: serial: 8250: Suitably replace printk Anton Wuerfel
2016-01-08 17:43 ` Anton Wuerfel
2016-01-11 12:38 ` Andy Shevchenko
2016-01-11 12:38 ` Andy Shevchenko
2016-01-08 17:43 ` [PATCH v4 11/13] tty: serial: 8250: Remove SERIAL_DEBUG_PNP macro Anton Wuerfel
2016-01-08 17:43 ` Anton Wuerfel
2016-01-08 17:43 ` [PATCH v4 12/13] tty: serial: 8250: Removed warning in debug output Anton Wuerfel
2016-01-08 17:43 ` Anton Wuerfel
2016-01-11 12:42 ` Andy Shevchenko
2016-01-11 12:42 ` Andy Shevchenko
2016-01-08 17:43 ` [PATCH v4 13/13] tty: serial: 8250: Fix indentation warnings Anton Wuerfel
2016-01-08 17:43 ` Anton Wuerfel
2016-01-11 12:47 ` Andy Shevchenko
2016-01-11 12:47 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452516646.26146.22.camel@intel.com \
--to=andriy.shevchenko@intel.com \
--cc=adam.lee@canonical.com \
--cc=anton.wuerfel@fau.de \
--cc=deller@gmx.de \
--cc=desmondl@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hpeter@gmail.com \
--cc=jejb@parisc-linux.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=long.wanglong@huawei.com \
--cc=mail@maciej.szmigiero.name \
--cc=mans@mansr.com \
--cc=paul.burton@imgtec.com \
--cc=phillip.raffeck@fau.de \
--cc=qipeng.zha@intel.com \
--cc=ralf@linux-mips.org \
--cc=soeren.grunewald@desy.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.