* [PATCH][coreutils] Add attr build dependency
@ 2016-01-14 14:54 Scott Ellis
2016-01-14 17:50 ` Khem Raj
0 siblings, 1 reply; 6+ messages in thread
From: Scott Ellis @ 2016-01-14 14:54 UTC (permalink / raw)
To: yocto
Fixes this warning:
WARNING: QA Issue: coreutils rdepends on libattr, but it isn't a build dependency? [build-deps]
Signed-off-by: Scott Ellis <scott@jumpnowtek.com>
---
meta/recipes-core/coreutils/coreutils_8.24.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-core/coreutils/coreutils_8.24.bb b/meta/recipes-core/coreutils/coreutils_8.24.bb
index f042346..47a25f3 100644
--- a/meta/recipes-core/coreutils/coreutils_8.24.bb
+++ b/meta/recipes-core/coreutils/coreutils_8.24.bb
@@ -7,7 +7,7 @@ BUGTRACKER = "http://debbugs.gnu.org/coreutils"
LICENSE = "GPLv3+"
LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504\
file://src/ls.c;beginline=5;endline=16;md5=38b79785ca88537b75871782a2a3c6b8"
-DEPENDS = "gmp libcap"
+DEPENDS = "attr gmp libcap"
DEPENDS_class-native = ""
inherit autotools gettext texinfo
--
2.5.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH][coreutils] Add attr build dependency
2016-01-14 14:54 [PATCH][coreutils] Add attr build dependency Scott Ellis
@ 2016-01-14 17:50 ` Khem Raj
2016-01-15 15:15 ` Scott Ellis
0 siblings, 1 reply; 6+ messages in thread
From: Khem Raj @ 2016-01-14 17:50 UTC (permalink / raw)
To: Scott Ellis; +Cc: yocto
[-- Attachment #1: Type: text/plain, Size: 1429 bytes --]
Scott
Thanks for patch. You might want to send into to oe-core mailing list.
> On Jan 14, 2016, at 6:54 AM, Scott Ellis <scott@jumpnowtek.com> wrote:
>
> Fixes this warning:
>
> WARNING: QA Issue: coreutils rdepends on libattr, but it isn't a build dependency? [build-deps]
>
> Signed-off-by: Scott Ellis <scott@jumpnowtek.com>
> ---
> meta/recipes-core/coreutils/coreutils_8.24.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/coreutils/coreutils_8.24.bb b/meta/recipes-core/coreutils/coreutils_8.24.bb
> index f042346..47a25f3 100644
> --- a/meta/recipes-core/coreutils/coreutils_8.24.bb
> +++ b/meta/recipes-core/coreutils/coreutils_8.24.bb
> @@ -7,7 +7,7 @@ BUGTRACKER = "http://debbugs.gnu.org/coreutils"
> LICENSE = "GPLv3+"
> LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504\
> file://src/ls.c;beginline=5;endline=16;md5=38b79785ca88537b75871782a2a3c6b8"
> -DEPENDS = "gmp libcap"
> +DEPENDS = "attr gmp lib cap”
while this fix is good. We can make this into a packageconfig knob
PACKAGECONFIG[attr] = "--enable-something,--disable-something,attr,"
> DEPENDS_class-native = ""
>
> inherit autotools gettext texinfo
> --
> 2.5.0
>
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][coreutils] Add attr build dependency
2016-01-14 17:50 ` Khem Raj
@ 2016-01-15 15:15 ` Scott Ellis
2016-01-15 18:23 ` Khem Raj
0 siblings, 1 reply; 6+ messages in thread
From: Scott Ellis @ 2016-01-15 15:15 UTC (permalink / raw)
To: yocto
The 'something' would be 'xattr'
PACKAGECONFIG[attr] = "--enable-xattr,--disable-xattr,attr,"
What should the default be?
The acl option for coreutils looks in DISTRO_FEATURES.
Should I do the same for this?
"Khem Raj" <raj.khem@gmail.com> said:
> Scott
>
> Thanks for patch. You might want to send into to oe-core mailing list.
>
>> On Jan 14, 2016, at 6:54 AM, Scott Ellis <scott@jumpnowtek.com> wrote:
>>
>> Fixes this warning:
>>
>> WARNING: QA Issue: coreutils rdepends on libattr, but it isn't a build
>> dependency? [build-deps]
>>
>> Signed-off-by: Scott Ellis <scott@jumpnowtek.com>
>> ---
>> meta/recipes-core/coreutils/coreutils_8.24.bb | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-core/coreutils/coreutils_8.24.bb
>> b/meta/recipes-core/coreutils/coreutils_8.24.bb
>> index f042346..47a25f3 100644
>> --- a/meta/recipes-core/coreutils/coreutils_8.24.bb
>> +++ b/meta/recipes-core/coreutils/coreutils_8.24.bb
>> @@ -7,7 +7,7 @@ BUGTRACKER = "http://debbugs.gnu.org/coreutils"
>> LICENSE = "GPLv3+"
>> LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504\
>> file://src/ls.c;beginline=5;endline=16;md5=38b79785ca88537b75871782a2a3c6b8"
>> -DEPENDS = "gmp libcap"
>> +DEPENDS = "attr gmp lib cap”
>
> while this fix is good. We can make this into a packageconfig knob
>
> PACKAGECONFIG[attr] = "--enable-something,--disable-something,attr,"
>
>> DEPENDS_class-native = ""
>>
>> inherit autotools gettext texinfo
>> --
>> 2.5.0
>>
>> --
>> _______________________________________________
>> yocto mailing list
>> yocto@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/yocto
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][coreutils] Add attr build dependency
2016-01-15 15:15 ` Scott Ellis
@ 2016-01-15 18:23 ` Khem Raj
2016-01-15 19:59 ` Scott Ellis
0 siblings, 1 reply; 6+ messages in thread
From: Khem Raj @ 2016-01-15 18:23 UTC (permalink / raw)
To: Scott Ellis; +Cc: yocto
[-- Attachment #1: Type: text/plain, Size: 2211 bytes --]
> On Jan 15, 2016, at 7:15 AM, Scott Ellis <scott@jumpnowtek.com> wrote:
>
> The 'something' would be 'xattr'
>
> PACKAGECONFIG[attr] = "--enable-xattr,--disable-xattr,attr,"
>
> What should the default be?
>
> The acl option for coreutils looks in DISTRO_FEATURES.
>
> Should I do the same for this?
if it depends on some DISTRO_FEATURE then definitely yes. Otherwise define the packageconfig
and then weakly assign a default with ??=
>
> "Khem Raj" <raj.khem@gmail.com> said:
>
>> Scott
>>
>> Thanks for patch. You might want to send into to oe-core mailing list.
>>
>>> On Jan 14, 2016, at 6:54 AM, Scott Ellis <scott@jumpnowtek.com> wrote:
>>>
>>> Fixes this warning:
>>>
>>> WARNING: QA Issue: coreutils rdepends on libattr, but it isn't a build
>>> dependency? [build-deps]
>>>
>>> Signed-off-by: Scott Ellis <scott@jumpnowtek.com>
>>> ---
>>> meta/recipes-core/coreutils/coreutils_8.24.bb | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-core/coreutils/coreutils_8.24.bb
>>> b/meta/recipes-core/coreutils/coreutils_8.24.bb
>>> index f042346..47a25f3 100644
>>> --- a/meta/recipes-core/coreutils/coreutils_8.24.bb
>>> +++ b/meta/recipes-core/coreutils/coreutils_8.24.bb
>>> @@ -7,7 +7,7 @@ BUGTRACKER = "http://debbugs.gnu.org/coreutils"
>>> LICENSE = "GPLv3+"
>>> LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504\
>>> file://src/ls.c;beginline=5;endline=16;md5=38b79785ca88537b75871782a2a3c6b8"
>>> -DEPENDS = "gmp libcap"
>>> +DEPENDS = "attr gmp lib cap”
>>
>> while this fix is good. We can make this into a packageconfig knob
>>
>> PACKAGECONFIG[attr] = "--enable-something,--disable-something,attr,"
>>
>>> DEPENDS_class-native = ""
>>>
>>> inherit autotools gettext texinfo
>>> --
>>> 2.5.0
>>>
>>> --
>>> _______________________________________________
>>> yocto mailing list
>>> yocto@yoctoproject.org
>>> https://lists.yoctoproject.org/listinfo/yocto
>>
>>
>
>
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][coreutils] Add attr build dependency
2016-01-15 18:23 ` Khem Raj
@ 2016-01-15 19:59 ` Scott Ellis
2016-01-15 20:28 ` Khem Raj
0 siblings, 1 reply; 6+ messages in thread
From: Scott Ellis @ 2016-01-15 19:59 UTC (permalink / raw)
To: yocto
Fixes this warning:
WARNING: QA Issue: coreutils rdepends on libattr, but it isn't a build dependency? [build-deps]
Signed-off-by: Scott Ellis <scott@jumpnowtek.com>
---
meta/recipes-core/coreutils/coreutils_8.24.bb | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-core/coreutils/coreutils_8.24.bb b/meta/recipes-core/coreutils/coreutils_8.24.bb
index f042346..6a09c59 100644
--- a/meta/recipes-core/coreutils/coreutils_8.24.bb
+++ b/meta/recipes-core/coreutils/coreutils_8.24.bb
@@ -28,14 +28,19 @@ SRC_URI[manpages.sha256sum] = "cf0333b5f134a331e0b46e2ddf90666f8bdc3281c1ca2c7cc
EXTRA_OECONF_class-native = "--without-gmp"
EXTRA_OECONF_class-target = "--enable-install-program=arch --libexecdir=${libdir}"
-# acl is not a default feature
+# acl and xattr are not default features
#
-PACKAGECONFIG_class-target ??= "${@bb.utils.contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}"
+PACKAGECONFIG_class-target ??= "\
+ ${@bb.utils.contains('DISTRO_FEATURES', 'acl', 'acl', '', d)} \
+ ${@bb.utils.contains('DISTRO_FEATURES', 'xattr', 'xattr', '', d)} \
+"
+
PACKAGECONFIG_class-native ??= ""
# with, without, depends, rdepends
#
PACKAGECONFIG[acl] = "--enable-acl,--disable-acl,acl,"
+PACKAGECONFIG[xattr] = "--enable-xattr,--disable-xattr,attr,"
# [ df mktemp base64 gets a special treatment and is not included in this
bindir_progs = "arch basename chcon cksum comm csplit cut dir dircolors dirname du \
--
2.5.0
"Khem Raj" <raj.khem@gmail.com> said:
>
>> On Jan 15, 2016, at 7:15 AM, Scott Ellis <scott@jumpnowtek.com> wrote:
>>
>> The 'something' would be 'xattr'
>>
>> PACKAGECONFIG[attr] = "--enable-xattr,--disable-xattr,attr,"
>>
>> What should the default be?
>>
>> The acl option for coreutils looks in DISTRO_FEATURES.
>>
>> Should I do the same for this?
>
> if it depends on some DISTRO_FEATURE then definitely yes. Otherwise define the
> packageconfig
> and then weakly assign a default with ??=
>
>>
>> "Khem Raj" <raj.khem@gmail.com> said:
>>
>>> Scott
>>>
>>> Thanks for patch. You might want to send into to oe-core mailing list.
>>>
>>>> On Jan 14, 2016, at 6:54 AM, Scott Ellis <scott@jumpnowtek.com> wrote:
>>>>
>>>> Fixes this warning:
>>>>
>>>> WARNING: QA Issue: coreutils rdepends on libattr, but it isn't a build
>>>> dependency? [build-deps]
>>>>
>>>> Signed-off-by: Scott Ellis <scott@jumpnowtek.com>
>>>> ---
>>>> meta/recipes-core/coreutils/coreutils_8.24.bb | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/meta/recipes-core/coreutils/coreutils_8.24.bb
>>>> b/meta/recipes-core/coreutils/coreutils_8.24.bb
>>>> index f042346..47a25f3 100644
>>>> --- a/meta/recipes-core/coreutils/coreutils_8.24.bb
>>>> +++ b/meta/recipes-core/coreutils/coreutils_8.24.bb
>>>> @@ -7,7 +7,7 @@ BUGTRACKER = "http://debbugs.gnu.org/coreutils"
>>>> LICENSE = "GPLv3+"
>>>> LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504\
>>>> file://src/ls.c;beginline=5;endline=16;md5=38b79785ca88537b75871782a2a3c6b8"
>>>> -DEPENDS = "gmp libcap"
>>>> +DEPENDS = "attr gmp lib cap”
>>>
>>> while this fix is good. We can make this into a packageconfig knob
>>>
>>> PACKAGECONFIG[attr] = "--enable-something,--disable-something,attr,"
>>>
>>>> DEPENDS_class-native = ""
>>>>
>>>> inherit autotools gettext texinfo
>>>> --
>>>> 2.5.0
>>>>
>>>> --
>>>> _______________________________________________
>>>> yocto mailing list
>>>> yocto@yoctoproject.org
>>>> https://lists.yoctoproject.org/listinfo/yocto
>>>
>>>
>>
>>
>> --
>> _______________________________________________
>> yocto mailing list
>> yocto@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/yocto
>
>
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH][coreutils] Add attr build dependency
2016-01-15 19:59 ` Scott Ellis
@ 2016-01-15 20:28 ` Khem Raj
0 siblings, 0 replies; 6+ messages in thread
From: Khem Raj @ 2016-01-15 20:28 UTC (permalink / raw)
To: Scott Ellis; +Cc: yocto
[-- Attachment #1: Type: text/plain, Size: 4275 bytes --]
> On Jan 15, 2016, at 11:59 AM, Scott Ellis <scott@jumpnowtek.com> wrote:
>
> Fixes this warning:
>
> WARNING: QA Issue: coreutils rdepends on libattr, but it isn't a build dependency? [build-deps]
>
> Signed-off-by: Scott Ellis <scott@jumpnowtek.com>
> ---
> meta/recipes-core/coreutils/coreutils_8.24.bb | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-core/coreutils/coreutils_8.24.bb b/meta/recipes-core/coreutils/coreutils_8.24.bb
> index f042346..6a09c59 100644
> --- a/meta/recipes-core/coreutils/coreutils_8.24.bb
> +++ b/meta/recipes-core/coreutils/coreutils_8.24.bb
> @@ -28,14 +28,19 @@ SRC_URI[manpages.sha256sum] = "cf0333b5f134a331e0b46e2ddf90666f8bdc3281c1ca2c7cc
> EXTRA_OECONF_class-native = "--without-gmp"
> EXTRA_OECONF_class-target = "--enable-install-program=arch --libexecdir=${libdir}"
>
> -# acl is not a default feature
> +# acl and xattr are not default features
> #
> -PACKAGECONFIG_class-target ??= "${@bb.utils.contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}"
> +PACKAGECONFIG_class-target ??= "\
> + ${@bb.utils.contains('DISTRO_FEATURES', 'acl', 'acl', '', d)} \
> + ${@bb.utils.contains('DISTRO_FEATURES', 'xattr', 'xattr', '', d)} \
> +”
Thanks, this one looks good.
> +
> PACKAGECONFIG_class-native ??= ""
>
> # with, without, depends, rdepends
> #
> PACKAGECONFIG[acl] = "--enable-acl,--disable-acl,acl,"
> +PACKAGECONFIG[xattr] = "--enable-xattr,--disable-xattr,attr,"
>
> # [ df mktemp base64 gets a special treatment and is not included in this
> bindir_progs = "arch basename chcon cksum comm csplit cut dir dircolors dirname du \
> --
> 2.5.0
>
> "Khem Raj" <raj.khem@gmail.com> said:
>
>>
>>> On Jan 15, 2016, at 7:15 AM, Scott Ellis <scott@jumpnowtek.com> wrote:
>>>
>>> The 'something' would be 'xattr'
>>>
>>> PACKAGECONFIG[attr] = "--enable-xattr,--disable-xattr,attr,"
>>>
>>> What should the default be?
>>>
>>> The acl option for coreutils looks in DISTRO_FEATURES.
>>>
>>> Should I do the same for this?
>>
>> if it depends on some DISTRO_FEATURE then definitely yes. Otherwise define the
>> packageconfig
>> and then weakly assign a default with ??=
>>
>>>
>>> "Khem Raj" <raj.khem@gmail.com> said:
>>>
>>>> Scott
>>>>
>>>> Thanks for patch. You might want to send into to oe-core mailing list.
>>>>
>>>>> On Jan 14, 2016, at 6:54 AM, Scott Ellis <scott@jumpnowtek.com> wrote:
>>>>>
>>>>> Fixes this warning:
>>>>>
>>>>> WARNING: QA Issue: coreutils rdepends on libattr, but it isn't a build
>>>>> dependency? [build-deps]
>>>>>
>>>>> Signed-off-by: Scott Ellis <scott@jumpnowtek.com>
>>>>> ---
>>>>> meta/recipes-core/coreutils/coreutils_8.24.bb | 2 +-
>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/meta/recipes-core/coreutils/coreutils_8.24.bb
>>>>> b/meta/recipes-core/coreutils/coreutils_8.24.bb
>>>>> index f042346..47a25f3 100644
>>>>> --- a/meta/recipes-core/coreutils/coreutils_8.24.bb
>>>>> +++ b/meta/recipes-core/coreutils/coreutils_8.24.bb
>>>>> @@ -7,7 +7,7 @@ BUGTRACKER = "http://debbugs.gnu.org/coreutils"
>>>>> LICENSE = "GPLv3+"
>>>>> LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504\
>>>>> file://src/ls.c;beginline=5;endline=16;md5=38b79785ca88537b75871782a2a3c6b8"
>>>>> -DEPENDS = "gmp libcap"
>>>>> +DEPENDS = "attr gmp lib cap”
>>>>
>>>> while this fix is good. We can make this into a packageconfig knob
>>>>
>>>> PACKAGECONFIG[attr] = "--enable-something,--disable-something,attr,"
>>>>
>>>>> DEPENDS_class-native = ""
>>>>>
>>>>> inherit autotools gettext texinfo
>>>>> --
>>>>> 2.5.0
>>>>>
>>>>> --
>>>>> _______________________________________________
>>>>> yocto mailing list
>>>>> yocto@yoctoproject.org
>>>>> https://lists.yoctoproject.org/listinfo/yocto
>>>>
>>>>
>>>
>>>
>>> --
>>> _______________________________________________
>>> yocto mailing list
>>> yocto@yoctoproject.org
>>> https://lists.yoctoproject.org/listinfo/yocto
>>
>>
>
>
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-01-15 20:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-14 14:54 [PATCH][coreutils] Add attr build dependency Scott Ellis
2016-01-14 17:50 ` Khem Raj
2016-01-15 15:15 ` Scott Ellis
2016-01-15 18:23 ` Khem Raj
2016-01-15 19:59 ` Scott Ellis
2016-01-15 20:28 ` Khem Raj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.