From: Romain Izard <romain.izard.pro@gmail.com>
To: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org
Cc: Josh Wu <rainyfeeling@outlook.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Yang Wenyou <Wenyou.Yang@atmel.com>,
Romain Izard <romain.izard.pro@gmail.com>
Subject: [PATCH v2 3/8] mtd: atmel_nand: Use of_device_get_match_data
Date: Fri, 15 Jan 2016 11:34:57 +0100 [thread overview]
Message-ID: <1452854102-6125-4-git-send-email-romain.izard.pro@gmail.com> (raw)
In-Reply-To: <1452854102-6125-1-git-send-email-romain.izard.pro@gmail.com>
Remove the need for forward declaration and the risk for a null pointer
when accessing the private part of the compatible match table, by using
the newly introduced of_device_get_match_data function.
Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
---
v2: new patch
drivers/mtd/nand/atmel_nand.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
index 6e548fc3ab7b..b5e2e62cd261 100644
--- a/drivers/mtd/nand/atmel_nand.c
+++ b/drivers/mtd/nand/atmel_nand.c
@@ -1485,8 +1485,6 @@ static void atmel_nand_hwctl(struct mtd_info *mtd, int mode)
ecc_writel(host->ecc, CR, ATMEL_ECC_RST);
}
-static const struct of_device_id atmel_nand_dt_ids[];
-
static int atmel_of_init_port(struct atmel_nand_host *host,
struct device_node *np)
{
@@ -1497,7 +1495,7 @@ static int atmel_of_init_port(struct atmel_nand_host *host,
enum of_gpio_flags flags = 0;
host->caps = (struct atmel_nand_caps *)
- of_match_device(atmel_nand_dt_ids, host->dev)->data;
+ of_device_get_match_data(host->dev);
if (of_property_read_u32(np, "atmel,nand-addr-offset", &val) == 0) {
if (val >= 32) {
--
2.5.0
WARNING: multiple messages have this Message-ID (diff)
From: Romain Izard <romain.izard.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Josh Wu <rainyfeeling-1ViLX0X+lBJBDgjK7y7TUQ@public.gmane.org>,
Nicolas Ferre
<nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
Yang Wenyou <Wenyou.Yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
Romain Izard
<romain.izard.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: [PATCH v2 3/8] mtd: atmel_nand: Use of_device_get_match_data
Date: Fri, 15 Jan 2016 11:34:57 +0100 [thread overview]
Message-ID: <1452854102-6125-4-git-send-email-romain.izard.pro@gmail.com> (raw)
In-Reply-To: <1452854102-6125-1-git-send-email-romain.izard.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Remove the need for forward declaration and the risk for a null pointer
when accessing the private part of the compatible match table, by using
the newly introduced of_device_get_match_data function.
Signed-off-by: Romain Izard <romain.izard.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
v2: new patch
drivers/mtd/nand/atmel_nand.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
index 6e548fc3ab7b..b5e2e62cd261 100644
--- a/drivers/mtd/nand/atmel_nand.c
+++ b/drivers/mtd/nand/atmel_nand.c
@@ -1485,8 +1485,6 @@ static void atmel_nand_hwctl(struct mtd_info *mtd, int mode)
ecc_writel(host->ecc, CR, ATMEL_ECC_RST);
}
-static const struct of_device_id atmel_nand_dt_ids[];
-
static int atmel_of_init_port(struct atmel_nand_host *host,
struct device_node *np)
{
@@ -1497,7 +1495,7 @@ static int atmel_of_init_port(struct atmel_nand_host *host,
enum of_gpio_flags flags = 0;
host->caps = (struct atmel_nand_caps *)
- of_match_device(atmel_nand_dt_ids, host->dev)->data;
+ of_device_get_match_data(host->dev);
if (of_property_read_u32(np, "atmel,nand-addr-offset", &val) == 0) {
if (val >= 32) {
--
2.5.0
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-01-15 10:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 10:34 [PATCH v2 0/8] mtd: atmel_nand: Add support for NAND Flash on SAMA5D2 Romain Izard
2016-01-15 10:34 ` Romain Izard
2016-01-15 10:34 ` [PATCH v2 1/8] mtd: atmel_nand: Do not warn on bitflips Romain Izard
2016-01-15 10:34 ` Romain Izard
2016-01-15 10:34 ` [PATCH v2 2/8] mtd: atmel_nand: Simplify error messages Romain Izard
2016-01-15 10:34 ` Romain Izard
2016-01-23 23:05 ` Brian Norris
2016-01-23 23:05 ` Brian Norris
2016-01-15 10:34 ` Romain Izard [this message]
2016-01-15 10:34 ` [PATCH v2 3/8] mtd: atmel_nand: Use of_device_get_match_data Romain Izard
2016-01-15 10:34 ` [PATCH v2 4/8] mtd: atmel_nand: Support variable RB_EDGE interrupts Romain Izard
2016-01-15 10:34 ` Romain Izard
2016-01-15 10:34 ` [PATCH v2 5/8] dt-bindings: atmel_nand: Reword the documenation Romain Izard
2016-01-15 10:34 ` Romain Izard
2016-01-17 0:19 ` Rob Herring
2016-01-17 0:19 ` Rob Herring
2016-01-15 10:35 ` [PATCH v2 6/8] mtd: atmel_nand: Support PMECC on SAMA5D2 Romain Izard
2016-01-15 10:35 ` Romain Izard
2016-01-17 0:18 ` Rob Herring
2016-01-17 0:18 ` Rob Herring
2016-01-15 10:35 ` [PATCH v2 7/8] mtd: atmel_nand: Support 32-bit ECC strength Romain Izard
2016-01-15 10:35 ` Romain Izard
2016-01-15 10:35 ` [PATCH v2 8/8] ARM: at91/dt: sama5d2: add nand0 and nfc0 nodes Romain Izard
2016-01-15 10:35 ` Romain Izard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452854102-6125-4-git-send-email-romain.izard.pro@gmail.com \
--to=romain.izard.pro@gmail.com \
--cc=Wenyou.Yang@atmel.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nicolas.ferre@atmel.com \
--cc=rainyfeeling@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.