From: Elliot Smith <elliot.smith@intel.com>
To: toaster@yoctoproject.org
Subject: [review-request][PATCH 2/3] toaster: toasterui: log OSErrorException metadata events
Date: Fri, 15 Jan 2016 16:30:16 +0000 [thread overview]
Message-ID: <1452875417-24767-3-git-send-email-elliot.smith@intel.com> (raw)
In-Reply-To: <1452875417-24767-1-git-send-email-elliot.smith@intel.com>
OSErrors occurring in toaster.bbclass are converted to
OSErrorException metadata events. They were then being swallowed
as unprocessed events by toasterui, which made them difficult
to spot.
Explicitly catch OSErrorException events and log them so they
are easier to spot and debug.
Signed-off-by: Elliot Smith <elliot.smith@intel.com>
---
bitbake/lib/bb/ui/toasterui.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/bitbake/lib/bb/ui/toasterui.py b/bitbake/lib/bb/ui/toasterui.py
index 19be623..32b1889 100644
--- a/bitbake/lib/bb/ui/toasterui.py
+++ b/bitbake/lib/bb/ui/toasterui.py
@@ -366,6 +366,8 @@ def main(server, eventHandler, params):
buildinfohelper.store_license_manifest_path(event)
elif event.type == "SetBRBE":
buildinfohelper.brbe = buildinfohelper._get_data_from_event(event)
+ elif event.type == "OSErrorException":
+ logger.error(event)
else:
logger.error("Unprocessed MetadataEvent %s ", str(event))
continue
--
Elliot Smith
Software Engineer
Intel OTC
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
next prev parent reply other threads:[~2016-01-15 16:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 16:30 [review-request][PATCH 0/3][V2] Fix SDK downloads for builds Elliot Smith
2016-01-15 16:30 ` [review-request][PATCH 1/3] toaster: toasterui: listen for bb.event.MetadataEvent Elliot Smith
2016-01-15 16:30 ` Elliot Smith [this message]
2016-01-15 16:30 ` [review-request][PATCH 3/3] toaster: toastergui: make artifact download more robust Elliot Smith
2016-01-16 12:23 ` [review-request][PATCH 0/3][V2] Fix SDK downloads for builds Barros Pena, Belen
2016-01-18 10:17 ` Smith, Elliot
2016-01-18 11:37 ` Barros Pena, Belen
2016-01-18 13:50 ` Ed Bartosh
-- strict thread matches above, loose matches on Subject: below --
2016-01-13 11:03 [review-request][PATCH 0/3] " Elliot Smith
2016-01-13 11:03 ` [review-request][PATCH 2/3] toaster: toasterui Log OSErrorException metadata events Elliot Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452875417-24767-3-git-send-email-elliot.smith@intel.com \
--to=elliot.smith@intel.com \
--cc=toaster@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.