Re: [review-request][PATCH 0/3][V2] Fix SDK downloads for builds

[Ed Bartosh <ed.bartosh@linux.intel.com>]

Hi,

I've sent this patchset upstream & updated toaster-next.

On Mon, Jan 18, 2016 at 11:37:51AM +0000, Barros Pena, Belen wrote:
> 
> 
> On 18/01/2016 11:17, "Smith, Elliot" <elliot.smith@intel.com> wrote:
> 
> >On 16 January 2016 at 12:23, Barros Pena, Belen
> ><belen.barros.pena@intel.com> wrote:
> >
> >
> >On 15/01/2016 16:30, "toaster-bounces@yoctoproject.org on behalf of Elliot
> >Smith" <toaster-bounces@yoctoproject.org on behalf of
> >elliot.smith@intel.com> wrote:
> >
> >>V2:
> >>
> >>Rebased on toaster-next and fixed conflicts.
> >
> >Hi Elliot,
> >
> >Somehow this is not working for me. I built an sdk for core-image-minimal
> >from Toaster on a clean build directory, but I cannot see the sdk
> >artifacts shown in the build dashboard, although they are in
> >/build/tmp/deploy/sdk. I've attached a screenshot of what I see.
> >
> >
> >
> >
> >I don't think I mentioned it in my review request, but you must build
> >against the local release, otherwise the changes to bitbake (in
> >meta/classes/toaster.bbclass) won't be active.
> 
> Right, that was the problem. If I build with the local release I can see
> the sdk artifacts listed.
> 
> Thanks!
> 
> Belén
> 
> 
> >
> >
> >
> >Elliot
> >
> > 
> >
> >
> >Am I doing something wrong?
> >
> >Thanks!
> >
> >Belén
> >
> >
> >>
> >>V1:
> >>
> >>Artifacts could not be downloaded for a build as they were not being
> >>listed.
> >>It was not possible to download them manually either, as the artifact
> >>download
> >>code was broken for SDK artifacts produced by command line builds.
> >>
> >>Fix how toaster.bbclass hooks onto bitbake's build tasks, so that the SDK
> >>artifacts are picked up after do_populate_sdk runs.
> >>
> >>Fix Toaster code for returning SDK artifacts in HTTP responses.
> >>
> >>Changes since b53df3c (toaster-next) are in
> >>git://git.yoctoproject.org/poky-contrib
> >><http://git.yoctoproject.org/poky-contrib>,
> >>elliot/toaster/sdk_artifacts-7603
> >>http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=elliot/toaster/s
> >>d
> >>k_artifacts-7603
> >>
> >>NB one of the commits on this branch (fbc2024) has been submitted to
> >>oe-core:
> >>http://lists.openembedded.org/pipermail/openembedded-core/2016-January/11
> >>5
> >>366.html
> >>This patch set contains the other commits on the branch.
> >>
> >>Related bug: 
> >https://bugzilla.yoctoproject.org/show_bug.cgi?id=7603
> ><https://bugzilla.yoctoproject.org/show_bug.cgi?id=7603>
> >>
> >>To test:
> >>
> >>1. Ensure that your database has no build artifacts in it, either by
> >>removing the database, clearing the relevant table with SQL via the
> >>command line
> >>(delete from orm_buildartifact), or removing the objects via the Django
> >>shell
> >>(orm.models.BuildArtifact.objects.all().delete()).
> >>
> >>Note that the current behaviour, where we only associate SDK artifacts
> >>with the
> >>first build which produces them, has not been modified. So if you have
> >>already
> >>run a build and have files in tmp/deploy/sdk associated with it,
> >>subsequent
> >>builds will not be associated with those files.
> >>
> >>2. Start a new build from the command line or Toaster, invoking the
> >>populate_sdk
> >>target:
> >>
> >># command line
> >>bitbake -c populate_sdk core-image-minimal
> >>
> >># Toaster (NB you must use the "Local" release)
> >>run a build like "core-image-minimal:populate_sdk"
> >>
> >>3. View the build dashboard for the build when it completes and ensure it
> >>contains an "Other artifacts" section, as shown in the bug report.
> >>
> >>4. Click on one of the "Other artifact" links and ensure that the
> >>artifact
> >>downloads correctly.
> >>
> >>As this code slightly modifies all other artifact downloads, you could
> >>also
> >>check downloads for the following, too:
> >>
> >>* cooker logs
> >>* task logs
> >>* image files
> >>* licence manifests
> >>
> >>Elliot Smith (3):
> >>  toaster: toasterui: listen for bb.event.MetadataEvent
> >>  toaster: toasterui: log OSErrorException metadata events
> >>  toaster: toastergui: make artifact download more robust
> >>
> >> bitbake/lib/bb/ui/toasterui.py                     |  5 +-
> >> .../toastergui/templates/unavailable_artifact.html | 13 ++-
> >> bitbake/lib/toaster/toastergui/views.py            | 97
> >>+++++++++-------------
> >> 3 files changed, 51 insertions(+), 64 deletions(-)
> >>
> >>--
> >>Elliot Smith
> >>Software Engineer
> >>Intel OTC
> >>
> >>---------------------------------------------------------------------
> >>Intel Corporation (UK) Limited
> >>Registered No. 1134945 (England)
> >>Registered Office: Pipers Way, Swindon SN3 1RJ
> >>VAT No: 860 2173 47
> >>
> >>This e-mail and any attachments may contain confidential material for
> >>the sole use of the intended recipient(s). Any review or distribution
> >>by others is strictly prohibited. If you are not the intended
> >>recipient, please contact the sender and delete all copies.
> >>
> >
> >
> >>--
> >>_______________________________________________
> >>toaster mailing list
> >>toaster@yoctoproject.org
> >>https://lists.yoctoproject.org/listinfo/toaster
> >
> >
> >
> >
> >
> >
> >
> >
> >-- 
> >Elliot Smith
> >Software Engineer
> >Intel Open Source Technology Centre
> >
> >
> >
> >
> 
> -- 
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster

-- 
--
Regards,
Ed