Re: [PATCH] Staging: usb: storage: onetouch: fixed parethesis and space style issue

[Joe Perches <joe@perches.com>]

On Sun, 2016-01-17 at 15:20 +0530, Tapan Prakash T wrote:
> Fixed two coding style issue.

Your email subject is not correct.
This driver is not in staging and there's
a trivial typo in parenthesis.

> diff --git a/drivers/usb/storage/onetouch.c b/drivers/usb/storage/onetouch.c
[]
> @@ -69,7 +69,7 @@ struct usb_onetouch {
>  		    vendorName, productName, useProtocol, useTransport, \
>  		    initFunction, flags) \
>  { USB_DEVICE_VER(id_vendor, id_product, bcdDeviceMin, bcdDeviceMax), \
> -  .driver_info = (flags) }
> +.driver_info = (flags) }

A more typical style would have been to change
the space to a tab before .driver_info

>  static struct usb_device_id onetouch_usb_ids[] = {
>  #	include "unusual_onetouch.h"
> @@ -125,7 +125,7 @@ static void usb_onetouch_irq(struct urb *urb)
>  	input_sync(dev);
>  
>  resubmit:
> -	retval = usb_submit_urb (urb, GFP_ATOMIC);
> +	retval = usb_submit_urb(urb, GFP_ATOMIC);
>  	if (retval)
>  		dev_err(&dev->dev, "can't resubmit intr, %s-%s/input0, "
>  			"retval %d\n", onetouch->udev->bus->bus_name,

And to coalesce the format string

		dev_err(&dev->dev, "can't resubmit intr, %s-%s/input0, retval %d\n",
			onetouch->udev->bus->bus_name,