* Re: [PATCH v1 1/1] selinux: use absolute path to include directory [not found] <1449259655-84458-1-git-send-email-andriy.shevchenko@linux.intel.com> @ 2016-01-19 15:53 ` Paul Moore 2016-01-19 16:11 ` Andy Shevchenko 0 siblings, 1 reply; 3+ messages in thread From: Paul Moore @ 2016-01-19 15:53 UTC (permalink / raw) To: Andy Shevchenko; +Cc: selinux, linux-security-module, James Morris On Fri, Dec 4, 2015 at 3:07 PM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > Compiler warns us a lot that it can't find include folder because it's provided > in relative form. > > CC security/selinux/netlabel.o > cc1: warning: security/selinux/include: No such file or directory [-Wmissing-include-dirs] > cc1: warning: security/selinux/include: No such file or directory [-Wmissing-include-dirs] > cc1: warning: security/selinux/include: No such file or directory [-Wmissing-include-dirs] > cc1: warning: security/selinux/include: No such file or directory [-Wmissing-include-dirs] > > Add $(srctree) prefix to the path. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > security/selinux/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/selinux/Makefile b/security/selinux/Makefile > index ad5cd76..90d1adb 100644 > --- a/security/selinux/Makefile > +++ b/security/selinux/Makefile > @@ -13,7 +13,7 @@ selinux-$(CONFIG_SECURITY_NETWORK_XFRM) += xfrm.o > > selinux-$(CONFIG_NETLABEL) += netlabel.o > > -ccflags-y := -Isecurity/selinux -Isecurity/selinux/include > +ccflags-y := -Isecurity/selinux -I$(srctree)/security/selinux/include Why not add the $(srctree) prefix to both paths? > $(addprefix $(obj)/,$(selinux-y)): $(obj)/flask.h > > -- > 2.6.2 > -- paul moore www.paul-moore.com ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] selinux: use absolute path to include directory 2016-01-19 15:53 ` [PATCH v1 1/1] selinux: use absolute path to include directory Paul Moore @ 2016-01-19 16:11 ` Andy Shevchenko 2016-01-19 16:32 ` Paul Moore 0 siblings, 1 reply; 3+ messages in thread From: Andy Shevchenko @ 2016-01-19 16:11 UTC (permalink / raw) To: Paul Moore; +Cc: selinux, linux-security-module, James Morris On Tue, 2016-01-19 at 10:53 -0500, Paul Moore wrote: > On Fri, Dec 4, 2015 at 3:07 PM, Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > Compiler warns us a lot that it can't find include folder because > > it's provided > > in relative form. > > > > CC security/selinux/netlabel.o > > cc1: warning: security/selinux/include: No such file or directory > > [-Wmissing-include-dirs] > > cc1: warning: security/selinux/include: No such file or directory > > [-Wmissing-include-dirs] > > cc1: warning: security/selinux/include: No such file or directory > > [-Wmissing-include-dirs] > > cc1: warning: security/selinux/include: No such file or directory > > [-Wmissing-include-dirs] > > > > Add $(srctree) prefix to the path. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > > security/selinux/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/security/selinux/Makefile b/security/selinux/Makefile > > index ad5cd76..90d1adb 100644 > > --- a/security/selinux/Makefile > > +++ b/security/selinux/Makefile > > @@ -13,7 +13,7 @@ selinux-$(CONFIG_SECURITY_NETWORK_XFRM) += xfrm.o > > > > selinux-$(CONFIG_NETLABEL) += netlabel.o > > > > -ccflags-y := -Isecurity/selinux -Isecurity/selinux/include > > +ccflags-y := -Isecurity/selinux > > -I$(srctree)/security/selinux/include > > Why not add the $(srctree) prefix to both paths? I don't care as long as it fixes the annoying messages. Though, I can re-do the patch if it looks better that way. -- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] selinux: use absolute path to include directory 2016-01-19 16:11 ` Andy Shevchenko @ 2016-01-19 16:32 ` Paul Moore 0 siblings, 0 replies; 3+ messages in thread From: Paul Moore @ 2016-01-19 16:32 UTC (permalink / raw) To: Andy Shevchenko; +Cc: selinux, linux-security-module, James Morris On Tue, Jan 19, 2016 at 11:11 AM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > On Tue, 2016-01-19 at 10:53 -0500, Paul Moore wrote: >> On Fri, Dec 4, 2015 at 3:07 PM, Andy Shevchenko >> <andriy.shevchenko@linux.intel.com> wrote: >> > Compiler warns us a lot that it can't find include folder because >> > it's provided >> > in relative form. >> > >> > CC security/selinux/netlabel.o >> > cc1: warning: security/selinux/include: No such file or directory >> > [-Wmissing-include-dirs] >> > cc1: warning: security/selinux/include: No such file or directory >> > [-Wmissing-include-dirs] >> > cc1: warning: security/selinux/include: No such file or directory >> > [-Wmissing-include-dirs] >> > cc1: warning: security/selinux/include: No such file or directory >> > [-Wmissing-include-dirs] >> > >> > Add $(srctree) prefix to the path. >> > >> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >> > --- >> > security/selinux/Makefile | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/security/selinux/Makefile b/security/selinux/Makefile >> > index ad5cd76..90d1adb 100644 >> > --- a/security/selinux/Makefile >> > +++ b/security/selinux/Makefile >> > @@ -13,7 +13,7 @@ selinux-$(CONFIG_SECURITY_NETWORK_XFRM) += xfrm.o >> > >> > selinux-$(CONFIG_NETLABEL) += netlabel.o >> > >> > -ccflags-y := -Isecurity/selinux -Isecurity/selinux/include >> > +ccflags-y := -Isecurity/selinux >> > -I$(srctree)/security/selinux/include >> >> Why not add the $(srctree) prefix to both paths? > > I don't care as long as it fixes the annoying messages. Though, I can > re-do the patch if it looks better that way. Please do. -- paul moore www.paul-moore.com ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-19 16:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1449259655-84458-1-git-send-email-andriy.shevchenko@linux.intel.com>
2016-01-19 15:53 ` [PATCH v1 1/1] selinux: use absolute path to include directory Paul Moore
2016-01-19 16:11 ` Andy Shevchenko
2016-01-19 16:32 ` Paul Moore
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.