From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: shmobile: Remove __init from rcar_gen2_read_mode_pins()
Date: Mon, 17 Feb 2014 10:59:32 +0000 [thread overview]
Message-ID: <1453243.5L1W6bkVz8@avalon> (raw)
In-Reply-To: <20140217063510.21892.52120.sendpatchset@w520>
Hi Magnus,
Thank you for the patch.
On Monday 17 February 2014 15:35:10 Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
>
> Remove __init from rcar_gen2_read_mode_pins() to allow
> it to be used after boot. For instance the R-Car Gen2
> MD21 check is needed even in the case of CPU Hotplug.
>
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
>
> Written against renesas-devel-v3.14-rc2-20140213
>
> arch/arm/mach-shmobile/setup-rcar-gen2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- 0001/arch/arm/mach-shmobile/setup-rcar-gen2.c
> +++ work/arch/arm/mach-shmobile/setup-rcar-gen2.c 2014-02-17
> 15:02:48.000000000 +0900 @@ -28,7 +28,7 @@
>
> #define MODEMR 0xe6160060
>
> -u32 __init rcar_gen2_read_mode_pins(void)
> +u32 rcar_gen2_read_mode_pins(void)
> {
> void __iomem *modemr = ioremap_nocache(MODEMR, 4);
> u32 mode;
Should we read the value once at boot time and cache it ?
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: shmobile: Remove __init from rcar_gen2_read_mode_pins()
Date: Mon, 17 Feb 2014 11:59:32 +0100 [thread overview]
Message-ID: <1453243.5L1W6bkVz8@avalon> (raw)
In-Reply-To: <20140217063510.21892.52120.sendpatchset@w520>
Hi Magnus,
Thank you for the patch.
On Monday 17 February 2014 15:35:10 Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
>
> Remove __init from rcar_gen2_read_mode_pins() to allow
> it to be used after boot. For instance the R-Car Gen2
> MD21 check is needed even in the case of CPU Hotplug.
>
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
>
> Written against renesas-devel-v3.14-rc2-20140213
>
> arch/arm/mach-shmobile/setup-rcar-gen2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- 0001/arch/arm/mach-shmobile/setup-rcar-gen2.c
> +++ work/arch/arm/mach-shmobile/setup-rcar-gen2.c 2014-02-17
> 15:02:48.000000000 +0900 @@ -28,7 +28,7 @@
>
> #define MODEMR 0xe6160060
>
> -u32 __init rcar_gen2_read_mode_pins(void)
> +u32 rcar_gen2_read_mode_pins(void)
> {
> void __iomem *modemr = ioremap_nocache(MODEMR, 4);
> u32 mode;
Should we read the value once at boot time and cache it ?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-02-17 10:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 6:35 [PATCH] ARM: shmobile: Remove __init from rcar_gen2_read_mode_pins() Magnus Damm
2014-02-17 6:35 ` Magnus Damm
2014-02-17 8:52 ` Geert Uytterhoeven
2014-02-17 8:52 ` Geert Uytterhoeven
2014-02-17 10:59 ` Laurent Pinchart [this message]
2014-02-17 10:59 ` Laurent Pinchart
2014-02-17 11:08 ` Geert Uytterhoeven
2014-02-17 11:08 ` Geert Uytterhoeven
2014-02-17 11:16 ` Magnus Damm
2014-02-17 11:16 ` Magnus Damm
2014-02-18 0:18 ` Simon Horman
2014-02-18 0:18 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453243.5L1W6bkVz8@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.