From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 4/6] ARM: rockchip: add basic smp support for rk3288
Date: Tue, 14 Oct 2014 23:23:40 +0200 [thread overview]
Message-ID: <1453932.GC4UXrUPRz@phil> (raw)
In-Reply-To: <CAD=FV=WGnE3fBfzLGN_x8dFqq4RV=OnVAyUgRQheMiyG4U7TkQ@mail.gmail.com>
Am Dienstag, 14. Oktober 2014, 13:24:03 schrieb Doug Anderson:
> Kever,
>
> On Mon, Oct 13, 2014 at 1:12 PM, Kever Yang <kever.yang@rock-chips.com>
wrote:
> > + /*
> > + * We need to soft reset the cpu when we turn off the cpu power
> > domain, + * or else the active processors might be stalled when
> > the individual + * processor is powered down.
> > + */
> > + if (read_cpuid_part_number() != ARM_CPU_PART_CORTEX_A9) {
>
> I haven't done a full review of this patch, but it seems unlikely that
> your uses of read_cpuid_part_number() and read_cpuid_part() in this
> patch are correct. You use both functions and in both cases compare
> the results to ARM_CPU_PART_CORTEX_A9.
I think read_cpuid_part() would be the correct one, as it does
read_cpuid_id() & ARM_CPU_PART_MASK
which in turn should mask the correct parts of the cpuid to match against
ARM_CPU_PART_CORTEX_A9 [0].
[0] http://lxr.free-electrons.com/source/arch/arm/include/asm/cputype.h#L77
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Doug Anderson <dianders@chromium.org>
Cc: Kever Yang <kever.yang@rock-chips.com>,
Sonny Rao <sonnyrao@chromium.org>,
Addy Ke <addy.ke@rock-chips.com>, Eddie Cai <cf@rock-chips.com>,
Jianqun Xu <xjq@rock-chips.com>, han jiang <hj@rock-chips.com>,
Tao Huang <huangtao@rock-chips.com>,
linux-rockchip@lists.infradead.org,
Russell King <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 4/6] ARM: rockchip: add basic smp support for rk3288
Date: Tue, 14 Oct 2014 23:23:40 +0200 [thread overview]
Message-ID: <1453932.GC4UXrUPRz@phil> (raw)
In-Reply-To: <CAD=FV=WGnE3fBfzLGN_x8dFqq4RV=OnVAyUgRQheMiyG4U7TkQ@mail.gmail.com>
Am Dienstag, 14. Oktober 2014, 13:24:03 schrieb Doug Anderson:
> Kever,
>
> On Mon, Oct 13, 2014 at 1:12 PM, Kever Yang <kever.yang@rock-chips.com>
wrote:
> > + /*
> > + * We need to soft reset the cpu when we turn off the cpu power
> > domain, + * or else the active processors might be stalled when
> > the individual + * processor is powered down.
> > + */
> > + if (read_cpuid_part_number() != ARM_CPU_PART_CORTEX_A9) {
>
> I haven't done a full review of this patch, but it seems unlikely that
> your uses of read_cpuid_part_number() and read_cpuid_part() in this
> patch are correct. You use both functions and in both cases compare
> the results to ARM_CPU_PART_CORTEX_A9.
I think read_cpuid_part() would be the correct one, as it does
read_cpuid_id() & ARM_CPU_PART_MASK
which in turn should mask the correct parts of the cpuid to match against
ARM_CPU_PART_CORTEX_A9 [0].
[0] http://lxr.free-electrons.com/source/arch/arm/include/asm/cputype.h#L77
next prev parent reply other threads:[~2014-10-14 21:23 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-13 20:11 [PATCH v4 0/6] add basic rk3288 smp support Kever Yang
2014-10-13 20:11 ` Kever Yang
2014-10-13 20:11 ` Kever Yang
2014-10-13 20:11 ` [PATCH v4 1/6] ARM: rockchip: convert to regmap and use pmu syscon if available Kever Yang
2014-10-13 20:11 ` Kever Yang
2014-10-13 20:11 ` [PATCH v4 2/6] ARM: rockchip: add option to access the pmu via a phandle in smp_operations Kever Yang
2014-10-13 20:11 ` Kever Yang
2014-10-13 20:11 ` Kever Yang
2014-10-13 20:11 ` [PATCH v4 3/6] ARM: dts: rockchip: add pmu references to cpus nodes Kever Yang
2014-10-13 20:11 ` Kever Yang
2014-10-13 20:12 ` [PATCH v4 4/6] ARM: rockchip: add basic smp support for rk3288 Kever Yang
2014-10-13 20:12 ` Kever Yang
2014-10-14 20:24 ` Doug Anderson
2014-10-14 20:24 ` Doug Anderson
2014-10-14 21:23 ` Heiko Stübner [this message]
2014-10-14 21:23 ` Heiko Stübner
2014-10-14 21:50 ` Kever Yang
2014-10-14 21:50 ` Kever Yang
2014-10-14 23:37 ` Russell King - ARM Linux
2014-10-14 23:37 ` Russell King - ARM Linux
2014-10-15 6:49 ` Kever Yang
2014-10-15 6:49 ` Kever Yang
2014-10-14 23:36 ` Russell King - ARM Linux
2014-10-14 23:36 ` Russell King - ARM Linux
2014-10-13 20:12 ` [PATCH v4 5/6] ARM: dts: rockchip: add intmem node for rk3288 smp support Kever Yang
2014-10-13 20:12 ` Kever Yang
2014-10-13 20:12 ` [PATCH v4 6/6] ARM: dts: rockchip: add reset for CPU nodes Kever Yang
2014-10-13 20:12 ` Kever Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453932.GC4UXrUPRz@phil \
--to=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.