[PATCH v2] udev: add runtime dependencies for udev-cache

[PATCH v2] udev: add runtime dependencies for udev-cache

[Ricardo Neri]

udev-cache uses find and xargs, which are provided by findutils. It also
uses gzip, which is provided by gzip. These utilities need to be present
when udev-cache runs. Thus, add them as RDEPENDSs.

Otherwise, if busybox is not included in the built image, the following
errors could be observed when booting if such packages are not present:

    /etc/rcS.d/S36udev-cache: line 66: xargs: command not found
    /etc/rcS.d/S36udev-cache: line 65: find: command not found
    /etc/rcS.d/S36udev-cache: line 67: gzip: command not found

Cc: Khem Raj <raj.khem@gmail.com>
Cc: Ross Burton <ross.burton@intel.com>
Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
---
Changes since v1:
 * Narrow the dependency only to udev-cache
 * Reword the commit message to mention that the issue is only
   reproducible if busybox is not included in the image.
---
 meta/recipes-core/udev/udev.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-core/udev/udev.inc b/meta/recipes-core/udev/udev.inc
index 93d7369..4e8e758 100644
--- a/meta/recipes-core/udev/udev.inc
+++ b/meta/recipes-core/udev/udev.inc
@@ -38,6 +38,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/utils/kernel/hotplug/udev-${PV}.tar.gz \
 
 inherit autotools pkgconfig update-rc.d ptest
 RDEPENDS_${PN}-ptest += "make perl python"
+RDEPENDS_${PN}-cache += "gzip findutils"
 
 libexecdir = "${base_libdir}"
 EXTRA_OECONF = "--disable-introspection \
-- 
1.9.1

Re: [PATCH v2] udev: add runtime dependencies for udev-cache

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 1741 bytes --]


> On Feb 4, 2016, at 12:12 PM, Ricardo Neri <ricardo.neri-calderon@linux.intel.com> wrote:
> 
> udev-cache uses find and xargs, which are provided by findutils. It also
> uses gzip, which is provided by gzip. These utilities need to be present
> when udev-cache runs. Thus, add them as RDEPENDSs.
> 
> Otherwise, if busybox is not included in the built image, the following
> errors could be observed when booting if such packages are not present:
> 
>    /etc/rcS.d/S36udev-cache: line 66: xargs: command not found
>    /etc/rcS.d/S36udev-cache: line 65: find: command not found
>    /etc/rcS.d/S36udev-cache: line 67: gzip: command not found
> 
> Cc: Khem Raj <raj.khem@gmail.com>
> Cc: Ross Burton <ross.burton@intel.com>
> Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
> ---
> Changes since v1:
> * Narrow the dependency only to udev-cache
> * Reword the commit message to mention that the issue is only
>   reproducible if busybox is not included in the image.
> ---
> meta/recipes-core/udev/udev.inc | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-core/udev/udev.inc b/meta/recipes-core/udev/udev.inc
> index 93d7369..4e8e758 100644
> --- a/meta/recipes-core/udev/udev.inc
> +++ b/meta/recipes-core/udev/udev.inc
> @@ -38,6 +38,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/utils/kernel/hotplug/udev-${PV}.tar.gz \
> 
> inherit autotools pkgconfig update-rc.d ptest
> RDEPENDS_${PN}-ptest += "make perl python"
> +RDEPENDS_${PN}-cache += "gzip findutils”

are they individually packaged ipks even with busybox ?
if not then this fix is insufficient

> 
> libexecdir = "${base_libdir}"
> EXTRA_OECONF = "--disable-introspection \
> --
> 1.9.1
> 


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

Re: [PATCH v2] udev: add runtime dependencies for udev-cache

[Phil Blundell]

On Thu, 2016-02-04 at 13:01 -0800, Khem Raj wrote:
> > On Feb 4, 2016, at 12:12 PM, Ricardo Neri <ricardo.neri-calderon@linux.intel.com> wrote:
> > inherit autotools pkgconfig update-rc.d ptest
> > RDEPENDS_${PN}-ptest += "make perl python"
> > +RDEPENDS_${PN}-cache += "gzip findutils”
> 
> are they individually packaged ipks even with busybox ?
> if not then this fix is insufficient

They don't have to be individually packaged, it would suffice for
busybox to RPROVIDE them.  (But it doesn't, so I think you are correct
that the patch as it stands will break builds with busybox.)

p.

Re: [PATCH v2] udev: add runtime dependencies for udev-cache

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 985 bytes --]


> On Feb 4, 2016, at 1:10 PM, Phil Blundell <pb@pbcl.net> wrote:
> 
> On Thu, 2016-02-04 at 13:01 -0800, Khem Raj wrote:
>>> On Feb 4, 2016, at 12:12 PM, Ricardo Neri <ricardo.neri-calderon@linux.intel.com> wrote:
>>> inherit autotools pkgconfig update-rc.d ptest
>>> RDEPENDS_${PN}-ptest += "make perl python"
>>> +RDEPENDS_${PN}-cache += "gzip findutils”
>> 
>> are they individually packaged ipks even with busybox ?
>> if not then this fix is insufficient
> 
> They don't have to be individually packaged, it would suffice for
> busybox to RPROVIDE them.

yes thats what I was expecting to be ensured.

>  (But it doesn't, so I think you are correct
> that the patch as it stands will break builds with busybox.)

I never said it will break for that matter original patch is fine too its just redundantly bringing in packages
when a system primarily using busybox for core utilities may be able to use busybox for, what I said was that it is insufficient.

[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]