All of lore.kernel.org
 help / color / mirror / Atom feed
From: ian.campbell@citrix.com (Ian Campbell)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] xen/arm: correctly handle DMA mapping of compound pages
Date: Mon, 8 Feb 2016 15:59:32 +0000	[thread overview]
Message-ID: <1454947172.17191.4.camel@citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1602081542410.27008@kaball.uk.xensource.com>

On Mon, 2016-02-08 at 15:46 +0000, Stefano Stabellini wrote:
> On Mon, 8 Feb 2016, Ian Campbell wrote:
> > Currently xen_dma_map_page concludes that DMA to anything other than
> > the head page of a compound page must be foreign, since the PFN of the
> > page is that of the head.
> > 
> > Fix the check to instead consider the whole of a compound page to be
> > local if the PFN of the head passes the 1:1 check.
> > 
> > We can never see a compound page which is a mixture of foreign and
> > local sub-pages.
> > 
> > The comment already correctly described the intention, but fixup the
> > spelling and some grammar.
> > 
> > This fixes the various SSH protocol errors which we have been seeing
> > on the cubietrucks in our automated test infrastructure.
> > 
> > This has been broken since "xen/arm: use hypercall to flush caches in
> > map_page" (3567258d281b), which was in v3.19-rc1.
> 
> checkpatch.pl reports a small style issue with this statement.

Damn, I added that para after I'd already run checkpatch.

> [...]
> 
> To take care of 64k pages, this needs to be:
> 
{...]

> Since you are at it, it might be worth adding brackets.

Will do on both counts. v2 on its way.

Ian.

WARNING: multiple messages have this Message-ID (diff)
From: Ian Campbell <ian.campbell@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Russell King <linux@arm.linux.org.uk>,
	<xen-devel@lists.xenproject.org>,
	<linux-arm-kernel@lists.infradead.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH] xen/arm: correctly handle DMA mapping of compound pages
Date: Mon, 8 Feb 2016 15:59:32 +0000	[thread overview]
Message-ID: <1454947172.17191.4.camel@citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1602081542410.27008@kaball.uk.xensource.com>

On Mon, 2016-02-08 at 15:46 +0000, Stefano Stabellini wrote:
> On Mon, 8 Feb 2016, Ian Campbell wrote:
> > Currently xen_dma_map_page concludes that DMA to anything other than
> > the head page of a compound page must be foreign, since the PFN of the
> > page is that of the head.
> > 
> > Fix the check to instead consider the whole of a compound page to be
> > local if the PFN of the head passes the 1:1 check.
> > 
> > We can never see a compound page which is a mixture of foreign and
> > local sub-pages.
> > 
> > The comment already correctly described the intention, but fixup the
> > spelling and some grammar.
> > 
> > This fixes the various SSH protocol errors which we have been seeing
> > on the cubietrucks in our automated test infrastructure.
> > 
> > This has been broken since "xen/arm: use hypercall to flush caches in
> > map_page" (3567258d281b), which was in v3.19-rc1.
> 
> checkpatch.pl reports a small style issue with this statement.

Damn, I added that para after I'd already run checkpatch.

> [...]
> 
> To take care of 64k pages, this needs to be:
> 
{...]

> Since you are at it, it might be worth adding brackets.

Will do on both counts. v2 on its way.

Ian.

  reply	other threads:[~2016-02-08 15:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-08 13:33 [PATCH] xen/arm: correctly handle DMA mapping of compound pages Ian Campbell
2016-02-08 13:33 ` Ian Campbell
2016-02-08 15:46 ` Stefano Stabellini
2016-02-08 15:46 ` Stefano Stabellini
2016-02-08 15:46   ` Stefano Stabellini
2016-02-08 15:59   ` Ian Campbell [this message]
2016-02-08 15:59     ` Ian Campbell
2016-02-08 15:59   ` Ian Campbell
  -- strict thread matches above, loose matches on Subject: below --
2016-02-08 13:33 Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454947172.17191.4.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.