* [PATCH] cifs: fix erroneous return value
@ 2016-02-10 17:50 ` Anton Protopopov
0 siblings, 0 replies; 7+ messages in thread
From: Anton Protopopov @ 2016-02-10 17:50 UTC (permalink / raw)
To: Steve French
Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Anton Protopopov
The setup_ntlmv2_rsp() function may return positive value ENOMEM instead
of -ENOMEM in case of kmalloc failure.
Signed-off-by: Anton Protopopov <a.s.protopopov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
fs/cifs/cifsencrypt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/cifs/cifsencrypt.c b/fs/cifs/cifsencrypt.c
index afa09fc..e682b36 100644
--- a/fs/cifs/cifsencrypt.c
+++ b/fs/cifs/cifsencrypt.c
@@ -714,7 +714,7 @@ setup_ntlmv2_rsp(struct cifs_ses *ses, const struct nls_table *nls_cp)
ses->auth_key.response = kmalloc(baselen + tilen, GFP_KERNEL);
if (!ses->auth_key.response) {
- rc = ENOMEM;
+ rc = -ENOMEM;
ses->auth_key.len = 0;
goto setup_ntlmv2_rsp_ret;
}
--
2.6.5
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] cifs: fix erroneous return value
@ 2016-02-10 17:50 ` Anton Protopopov
0 siblings, 0 replies; 7+ messages in thread
From: Anton Protopopov @ 2016-02-10 17:50 UTC (permalink / raw)
To: Steve French; +Cc: linux-cifs, linux-kernel, Anton Protopopov
The setup_ntlmv2_rsp() function may return positive value ENOMEM instead
of -ENOMEM in case of kmalloc failure.
Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
---
fs/cifs/cifsencrypt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/cifs/cifsencrypt.c b/fs/cifs/cifsencrypt.c
index afa09fc..e682b36 100644
--- a/fs/cifs/cifsencrypt.c
+++ b/fs/cifs/cifsencrypt.c
@@ -714,7 +714,7 @@ setup_ntlmv2_rsp(struct cifs_ses *ses, const struct nls_table *nls_cp)
ses->auth_key.response = kmalloc(baselen + tilen, GFP_KERNEL);
if (!ses->auth_key.response) {
- rc = ENOMEM;
+ rc = -ENOMEM;
ses->auth_key.len = 0;
goto setup_ntlmv2_rsp_ret;
}
--
2.6.5
^ permalink raw reply related [flat|nested] 7+ messages in thread[parent not found: <1455126621-28052-1-git-send-email-a.s.protopopov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH] cifs: fix erroneous return value
2016-02-10 17:50 ` Anton Protopopov
@ 2016-02-10 17:59 ` Joe Perches
-1 siblings, 0 replies; 7+ messages in thread
From: Joe Perches @ 2016-02-10 17:59 UTC (permalink / raw)
To: Anton Protopopov, Steve French
Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Wed, 2016-02-10 at 12:50 -0500, Anton Protopopov wrote:
> The setup_ntlmv2_rsp() function may return positive value ENOMEM instead
> of -ENOMEM in case of kmalloc failure.
How have you verified this change is correct?
Have you checked that the callers of this function in
fs/cifs/sess.c do the appropriate things with with a
negative return value?
The return value is now set into a struct member variable
as a positive value,
sess_data->result = rc;
Have you checked all the users of this member variable?
If you have, you should say so in the commit message.
> Signed-off-by: Anton Protopopov <a.s.protopopov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> fs/cifs/cifsencrypt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/cifsencrypt.c b/fs/cifs/cifsencrypt.c
> index afa09fc..e682b36 100644
> --- a/fs/cifs/cifsencrypt.c
> +++ b/fs/cifs/cifsencrypt.c
> @@ -714,7 +714,7 @@ setup_ntlmv2_rsp(struct cifs_ses *ses, const struct nls_table *nls_cp)
>
> ses->auth_key.response = kmalloc(baselen + tilen, GFP_KERNEL);
> if (!ses->auth_key.response) {
> - rc = ENOMEM;
> + rc = -ENOMEM;
> ses->auth_key.len = 0;
> goto setup_ntlmv2_rsp_ret;
> }
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] cifs: fix erroneous return value
@ 2016-02-10 17:59 ` Joe Perches
0 siblings, 0 replies; 7+ messages in thread
From: Joe Perches @ 2016-02-10 17:59 UTC (permalink / raw)
To: Anton Protopopov, Steve French; +Cc: linux-cifs, linux-kernel
On Wed, 2016-02-10 at 12:50 -0500, Anton Protopopov wrote:
> The setup_ntlmv2_rsp() function may return positive value ENOMEM instead
> of -ENOMEM in case of kmalloc failure.
How have you verified this change is correct?
Have you checked that the callers of this function in
fs/cifs/sess.c do the appropriate things with with a
negative return value?
The return value is now set into a struct member variable
as a positive value,
sess_data->result = rc;
Have you checked all the users of this member variable?
If you have, you should say so in the commit message.
> Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
> ---
> fs/cifs/cifsencrypt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/cifsencrypt.c b/fs/cifs/cifsencrypt.c
> index afa09fc..e682b36 100644
> --- a/fs/cifs/cifsencrypt.c
> +++ b/fs/cifs/cifsencrypt.c
> @@ -714,7 +714,7 @@ setup_ntlmv2_rsp(struct cifs_ses *ses, const struct nls_table *nls_cp)
>
> ses->auth_key.response = kmalloc(baselen + tilen, GFP_KERNEL);
> if (!ses->auth_key.response) {
> - rc = ENOMEM;
> + rc = -ENOMEM;
> ses->auth_key.len = 0;
> goto setup_ntlmv2_rsp_ret;
> }
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] cifs: fix erroneous return value
2016-02-10 17:59 ` Joe Perches
(?)
@ 2016-02-10 18:53 ` Anton Protopopov
-1 siblings, 0 replies; 7+ messages in thread
From: Anton Protopopov @ 2016-02-10 18:53 UTC (permalink / raw)
To: Joe Perches; +Cc: Steve French, linux-cifs, linux-kernel
2016-02-10 12:59 GMT-05:00 Joe Perches <joe@perches.com>:
> On Wed, 2016-02-10 at 12:50 -0500, Anton Protopopov wrote:
>> The setup_ntlmv2_rsp() function may return positive value ENOMEM instead
>> of -ENOMEM in case of kmalloc failure.
>
> How have you verified this change is correct?
Yes, this is the only case in which the setup_ntlmv2_rsp() function
returns positive error value. In all other error cases it returns the
negative error number.
>
> Have you checked that the callers of this function in
> fs/cifs/sess.c do the appropriate things with with a
> negative return value?
>
> The return value is now set into a struct member variable
> as a positive value,
>
> sess_data->result = rc;
As far as I can see, this member variable always contains a negative
error value which, in the end, is returned by the CIFS_SessSetup()
function (this function can also return -EINVAL, -ENOMEM, -EOPNOTSUPP,
etc.).
> Have you checked all the users of this member variable?
>
> If you have, you should say so in the commit message.
>
>> Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
>> ---
>> fs/cifs/cifsencrypt.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/cifs/cifsencrypt.c b/fs/cifs/cifsencrypt.c
>> index afa09fc..e682b36 100644
>> --- a/fs/cifs/cifsencrypt.c
>> +++ b/fs/cifs/cifsencrypt.c
>> @@ -714,7 +714,7 @@ setup_ntlmv2_rsp(struct cifs_ses *ses, const struct nls_table *nls_cp)
>>
>> ses->auth_key.response = kmalloc(baselen + tilen, GFP_KERNEL);
>> if (!ses->auth_key.response) {
>> - rc = ENOMEM;
>> + rc = -ENOMEM;
>> ses->auth_key.len = 0;
>> goto setup_ntlmv2_rsp_ret;
>> }
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] cifs: fix erroneous return value
2016-02-10 17:50 ` Anton Protopopov
@ 2016-02-11 0:25 ` Steve French
-1 siblings, 0 replies; 7+ messages in thread
From: Steve French @ 2016-02-11 0:25 UTC (permalink / raw)
To: Anton Protopopov
Cc: Steve French, linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
LKML
Merged into cifs-2.6.git and added cc: stable
On Wed, Feb 10, 2016 at 11:50 AM, Anton Protopopov
<a.s.protopopov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> The setup_ntlmv2_rsp() function may return positive value ENOMEM instead
> of -ENOMEM in case of kmalloc failure.
>
> Signed-off-by: Anton Protopopov <a.s.protopopov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> fs/cifs/cifsencrypt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/cifsencrypt.c b/fs/cifs/cifsencrypt.c
> index afa09fc..e682b36 100644
> --- a/fs/cifs/cifsencrypt.c
> +++ b/fs/cifs/cifsencrypt.c
> @@ -714,7 +714,7 @@ setup_ntlmv2_rsp(struct cifs_ses *ses, const struct nls_table *nls_cp)
>
> ses->auth_key.response = kmalloc(baselen + tilen, GFP_KERNEL);
> if (!ses->auth_key.response) {
> - rc = ENOMEM;
> + rc = -ENOMEM;
> ses->auth_key.len = 0;
> goto setup_ntlmv2_rsp_ret;
> }
> --
> 2.6.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] cifs: fix erroneous return value
@ 2016-02-11 0:25 ` Steve French
0 siblings, 0 replies; 7+ messages in thread
From: Steve French @ 2016-02-11 0:25 UTC (permalink / raw)
To: Anton Protopopov; +Cc: Steve French, linux-cifs@vger.kernel.org, LKML
Merged into cifs-2.6.git and added cc: stable
On Wed, Feb 10, 2016 at 11:50 AM, Anton Protopopov
<a.s.protopopov@gmail.com> wrote:
> The setup_ntlmv2_rsp() function may return positive value ENOMEM instead
> of -ENOMEM in case of kmalloc failure.
>
> Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
> ---
> fs/cifs/cifsencrypt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/cifsencrypt.c b/fs/cifs/cifsencrypt.c
> index afa09fc..e682b36 100644
> --- a/fs/cifs/cifsencrypt.c
> +++ b/fs/cifs/cifsencrypt.c
> @@ -714,7 +714,7 @@ setup_ntlmv2_rsp(struct cifs_ses *ses, const struct nls_table *nls_cp)
>
> ses->auth_key.response = kmalloc(baselen + tilen, GFP_KERNEL);
> if (!ses->auth_key.response) {
> - rc = ENOMEM;
> + rc = -ENOMEM;
> ses->auth_key.len = 0;
> goto setup_ntlmv2_rsp_ret;
> }
> --
> 2.6.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-02-11 0:25 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-10 17:50 [PATCH] cifs: fix erroneous return value Anton Protopopov
2016-02-10 17:50 ` Anton Protopopov
[not found] ` <1455126621-28052-1-git-send-email-a.s.protopopov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-10 17:59 ` Joe Perches
2016-02-10 17:59 ` Joe Perches
2016-02-10 18:53 ` Anton Protopopov
2016-02-11 0:25 ` Steve French
2016-02-11 0:25 ` Steve French
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.