From: green at linuxhacker.ru <green@linuxhacker.ru>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Andreas Dilger <andreas.dilger@intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lustre Development List <lustre-devel@lists.lustre.org>,
Oleg Drokin <green@linuxhacker.ru>
Subject: [lustre-devel] [PATCH 03/45] staging/lustre/libcfs: Get rid of /proc references in comments
Date: Tue, 16 Feb 2016 00:46:35 -0500 [thread overview]
Message-ID: <1455601637-3847710-4-git-send-email-green@linuxhacker.ru> (raw)
In-Reply-To: <1455601637-3847710-1-git-send-email-green@linuxhacker.ru>
From: Oleg Drokin <green@linuxhacker.ru>
Now that the sysfs conversion is complete, also convert all the
remaining comments
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
---
drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c | 4 ++--
drivers/staging/lustre/lustre/libcfs/module.c | 4 ----
drivers/staging/lustre/lustre/libcfs/tracefile.c | 7 ++++---
3 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c b/drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c
index 59c7bf3..3358c3b 100644
--- a/drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c
+++ b/drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c
@@ -87,7 +87,7 @@ void libcfs_run_debug_log_upcall(char *file)
rc = call_usermodehelper(argv[0], argv, envp, 1);
if (rc < 0 && rc != -ENOENT) {
- CERROR("Error %d invoking LNET debug log upcall %s %s; check /proc/sys/lnet/debug_log_upcall\n",
+ CERROR("Error %d invoking LNET debug log upcall %s %s; check /sys/kernel/debug/lnet/debug_log_upcall\n",
rc, argv[0], argv[1]);
} else {
CDEBUG(D_HA, "Invoked LNET debug log upcall %s %s\n",
@@ -113,7 +113,7 @@ void libcfs_run_upcall(char **argv)
rc = call_usermodehelper(argv[0], argv, envp, 1);
if (rc < 0 && rc != -ENOENT) {
- CERROR("Error %d invoking LNET upcall %s %s%s%s%s%s%s%s%s; check /proc/sys/lnet/upcall\n",
+ CERROR("Error %d invoking LNET upcall %s %s%s%s%s%s%s%s%s; check /sys/kernel/debug/lnet/upcall\n",
rc, argv[0], argv[1],
argc < 3 ? "" : ",", argc < 3 ? "" : argv[2],
argc < 4 ? "" : ",", argc < 4 ? "" : argv[3],
diff --git a/drivers/staging/lustre/lustre/libcfs/module.c b/drivers/staging/lustre/lustre/libcfs/module.c
index 611607a..45838b5 100644
--- a/drivers/staging/lustre/lustre/libcfs/module.c
+++ b/drivers/staging/lustre/lustre/libcfs/module.c
@@ -368,10 +368,6 @@ static int proc_cpt_table(struct ctl_table *table, int write,
}
static struct ctl_table lnet_table[] = {
- /*
- * NB No .strategy entries have been provided since sysctl(8) prefers
- * to go via /proc for portability.
- */
{
.procname = "debug",
.data = &libcfs_debug,
diff --git a/drivers/staging/lustre/lustre/libcfs/tracefile.c b/drivers/staging/lustre/lustre/libcfs/tracefile.c
index 65c4f1a..a7d9b78 100644
--- a/drivers/staging/lustre/lustre/libcfs/tracefile.c
+++ b/drivers/staging/lustre/lustre/libcfs/tracefile.c
@@ -771,9 +771,10 @@ EXPORT_SYMBOL(cfs_trace_copyin_string);
int cfs_trace_copyout_string(char __user *usr_buffer, int usr_buffer_nob,
const char *knl_buffer, char *append)
{
- /* NB if 'append' != NULL, it's a single character to append to the
- * copied out string - usually "\n", for /proc entries and "" (i.e. a
- * terminating zero byte) for sysctl entries */
+ /*
+ * NB if 'append' != NULL, it's a single character to append to the
+ * copied out string - usually "\n" or "" (i.e. a terminating zero byte)
+ */
int nob = strlen(knl_buffer);
if (nob > usr_buffer_nob)
--
2.1.0
WARNING: multiple messages have this Message-ID (diff)
From: green@linuxhacker.ru
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Andreas Dilger <andreas.dilger@intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lustre Development List <lustre-devel@lists.lustre.org>,
Oleg Drokin <green@linuxhacker.ru>
Subject: [PATCH 03/45] staging/lustre/libcfs: Get rid of /proc references in comments
Date: Tue, 16 Feb 2016 00:46:35 -0500 [thread overview]
Message-ID: <1455601637-3847710-4-git-send-email-green@linuxhacker.ru> (raw)
In-Reply-To: <1455601637-3847710-1-git-send-email-green@linuxhacker.ru>
From: Oleg Drokin <green@linuxhacker.ru>
Now that the sysfs conversion is complete, also convert all the
remaining comments
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
---
drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c | 4 ++--
drivers/staging/lustre/lustre/libcfs/module.c | 4 ----
drivers/staging/lustre/lustre/libcfs/tracefile.c | 7 ++++---
3 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c b/drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c
index 59c7bf3..3358c3b 100644
--- a/drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c
+++ b/drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c
@@ -87,7 +87,7 @@ void libcfs_run_debug_log_upcall(char *file)
rc = call_usermodehelper(argv[0], argv, envp, 1);
if (rc < 0 && rc != -ENOENT) {
- CERROR("Error %d invoking LNET debug log upcall %s %s; check /proc/sys/lnet/debug_log_upcall\n",
+ CERROR("Error %d invoking LNET debug log upcall %s %s; check /sys/kernel/debug/lnet/debug_log_upcall\n",
rc, argv[0], argv[1]);
} else {
CDEBUG(D_HA, "Invoked LNET debug log upcall %s %s\n",
@@ -113,7 +113,7 @@ void libcfs_run_upcall(char **argv)
rc = call_usermodehelper(argv[0], argv, envp, 1);
if (rc < 0 && rc != -ENOENT) {
- CERROR("Error %d invoking LNET upcall %s %s%s%s%s%s%s%s%s; check /proc/sys/lnet/upcall\n",
+ CERROR("Error %d invoking LNET upcall %s %s%s%s%s%s%s%s%s; check /sys/kernel/debug/lnet/upcall\n",
rc, argv[0], argv[1],
argc < 3 ? "" : ",", argc < 3 ? "" : argv[2],
argc < 4 ? "" : ",", argc < 4 ? "" : argv[3],
diff --git a/drivers/staging/lustre/lustre/libcfs/module.c b/drivers/staging/lustre/lustre/libcfs/module.c
index 611607a..45838b5 100644
--- a/drivers/staging/lustre/lustre/libcfs/module.c
+++ b/drivers/staging/lustre/lustre/libcfs/module.c
@@ -368,10 +368,6 @@ static int proc_cpt_table(struct ctl_table *table, int write,
}
static struct ctl_table lnet_table[] = {
- /*
- * NB No .strategy entries have been provided since sysctl(8) prefers
- * to go via /proc for portability.
- */
{
.procname = "debug",
.data = &libcfs_debug,
diff --git a/drivers/staging/lustre/lustre/libcfs/tracefile.c b/drivers/staging/lustre/lustre/libcfs/tracefile.c
index 65c4f1a..a7d9b78 100644
--- a/drivers/staging/lustre/lustre/libcfs/tracefile.c
+++ b/drivers/staging/lustre/lustre/libcfs/tracefile.c
@@ -771,9 +771,10 @@ EXPORT_SYMBOL(cfs_trace_copyin_string);
int cfs_trace_copyout_string(char __user *usr_buffer, int usr_buffer_nob,
const char *knl_buffer, char *append)
{
- /* NB if 'append' != NULL, it's a single character to append to the
- * copied out string - usually "\n", for /proc entries and "" (i.e. a
- * terminating zero byte) for sysctl entries */
+ /*
+ * NB if 'append' != NULL, it's a single character to append to the
+ * copied out string - usually "\n" or "" (i.e. a terminating zero byte)
+ */
int nob = strlen(knl_buffer);
if (nob > usr_buffer_nob)
--
2.1.0
next prev parent reply other threads:[~2016-02-16 5:46 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 5:46 [lustre-devel] [PATCH 00/45] Lustre cleanups green at linuxhacker.ru
2016-02-16 5:46 ` green
2016-02-16 5:46 ` [lustre-devel] [PATCH 01/45] staging/lustre/ptlrpc: Get rid of /proc references in comments green at linuxhacker.ru
2016-02-16 5:46 ` green
2016-02-16 5:46 ` [lustre-devel] [PATCH 02/45] staging/lustre/obdclass: " green at linuxhacker.ru
2016-02-16 5:46 ` green
2016-02-16 5:46 ` green at linuxhacker.ru [this message]
2016-02-16 5:46 ` [PATCH 03/45] staging/lustre/libcfs: " green
2016-02-16 5:46 ` [lustre-devel] [PATCH 04/45] staging/lustre/llite: " green at linuxhacker.ru
2016-02-16 5:46 ` green
2016-02-16 5:46 ` [lustre-devel] [PATCH 05/45] staging/lustre/lov: " green at linuxhacker.ru
2016-02-16 5:46 ` green
2016-02-16 5:46 ` [lustre-devel] [PATCH 06/45] staging/lustre: Remove unused function oti_init green at linuxhacker.ru
2016-02-16 5:46 ` green
2016-02-16 5:46 ` [lustre-devel] [PATCH 07/45] staging/lustre: Remove unused osc_on_mdt function green at linuxhacker.ru
2016-02-16 5:46 ` green
2016-02-16 5:46 ` [lustre-devel] [PATCH 08/45] staging/lustre: Remove server code from client_obd_setup() green at linuxhacker.ru
2016-02-16 5:46 ` green
2016-02-16 5:46 ` [lustre-devel] [PATCH 09/45] staging/lustre: Remove server code from class_get_type() green at linuxhacker.ru
2016-02-16 5:46 ` green
2016-02-16 5:46 ` [lustre-devel] [PATCH 10/45] staging/lustre: Remove commented out lock_lock_multi_match green at linuxhacker.ru
2016-02-16 5:46 ` green
2016-02-16 5:46 ` [lustre-devel] [PATCH 11/45] staging/lustre/osc: Remove commented out osc_page_protected() green at linuxhacker.ru
2016-02-16 5:46 ` green
2016-02-16 5:46 ` [lustre-devel] [PATCH 12/45] staging/lustre/libcfs: Adjust NULL comparison codestyle green at linuxhacker.ru
2016-02-16 5:46 ` green
2016-02-16 5:46 ` [lustre-devel] [PATCH 13/45] staging/lustre/lov: " green at linuxhacker.ru
2016-02-16 5:46 ` green
2016-02-16 5:46 ` [lustre-devel] [PATCH 14/45] staging/lustre/llite: " green at linuxhacker.ru
2016-02-16 5:46 ` green
2016-02-16 5:46 ` [lustre-devel] [PATCH 15/45] staging/lustre/ldlm: " green at linuxhacker.ru
2016-02-16 5:46 ` green
2016-02-16 5:46 ` [lustre-devel] [PATCH 16/45] staging/lustre/lmv: " green at linuxhacker.ru
2016-02-16 5:46 ` green
2016-02-16 5:46 ` [lustre-devel] [PATCH 17/45] staging/lustre/fid: " green at linuxhacker.ru
2016-02-16 5:46 ` green
2016-02-16 5:46 ` [lustre-devel] [PATCH 18/45] staging/lustre/fld: " green at linuxhacker.ru
2016-02-16 5:46 ` green
2016-02-16 5:46 ` [lustre-devel] [PATCH 19/45] staging/lustre/lclient: " green at linuxhacker.ru
2016-02-16 5:46 ` green
2016-02-16 5:46 ` [lustre-devel] [PATCH 20/45] staging/lustre/include: " green at linuxhacker.ru
2016-02-16 5:46 ` green
2016-02-16 5:46 ` [lustre-devel] [PATCH 21/45] staging/lustre/mdc: " green at linuxhacker.ru
2016-02-16 5:46 ` green
2016-02-16 5:46 ` [lustre-devel] [PATCH 22/45] staging/lustre/mgc: " green at linuxhacker.ru
2016-02-16 5:46 ` green
2016-02-16 5:46 ` [lustre-devel] [PATCH 23/45] staging/lustre/obdclass: " green at linuxhacker.ru
2016-02-16 5:46 ` green
2016-02-16 5:46 ` [lustre-devel] [PATCH 24/45] staging/lustre/obdecho: " green at linuxhacker.ru
2016-02-16 5:46 ` green
2016-02-16 5:46 ` [lustre-devel] [PATCH 25/45] staging/lustre/osc: " green at linuxhacker.ru
2016-02-16 5:46 ` green
2016-02-16 5:46 ` [lustre-devel] [PATCH 26/45] staging/lustre/ptlrpc: " green at linuxhacker.ru
2016-02-16 5:46 ` green
2016-02-16 5:46 ` [lustre-devel] [PATCH 27/45] staging/lustre: Remove the "write to FSF to get a copy of GPL" wording green at linuxhacker.ru
2016-02-16 5:46 ` green
2016-02-16 5:47 ` [lustre-devel] [PATCH 28/45] staging/lustre/libcfs: Cleanup: parenthesis alignment adjustments green at linuxhacker.ru
2016-02-16 5:47 ` green
2016-02-16 5:47 ` [lustre-devel] [PATCH 29/45] staging/lustre/libcfs: Move EXPORT_SYMBOLs under function/variable green at linuxhacker.ru
2016-02-16 5:47 ` green
2016-02-16 5:47 ` [lustre-devel] [PATCH 30/45] staging/lustre/libcfs: style change to add missing spaces for operations green at linuxhacker.ru
2016-02-16 5:47 ` green
2016-02-16 5:47 ` [lustre-devel] [PATCH 31/45] staging/lustre/libcfs: reformat cfs_tcd_for_each_type_lock define green at linuxhacker.ru
2016-02-16 5:47 ` green
2016-02-16 5:47 ` [lustre-devel] [PATCH 32/45] staging/lustre/libcfs: Remove stray spaces after function name green at linuxhacker.ru
2016-02-16 5:47 ` green
2016-02-16 5:47 ` [lustre-devel] [PATCH 33/45] staging/lustre/libcfs: Shortened too long lines green at linuxhacker.ru
2016-02-16 5:47 ` green
2016-02-16 5:47 ` [lustre-devel] [PATCH 34/45] staging/lustre/libcfs: Remove unused cfs_tcd_owns_tage() function green at linuxhacker.ru
2016-02-16 5:47 ` green
2016-02-16 5:47 ` [lustre-devel] [PATCH 35/45] staging/lustre/libcfs: Move private tracefile structs out of header green at linuxhacker.ru
2016-02-16 5:47 ` green
2016-02-16 5:47 ` [lustre-devel] [PATCH 36/45] staging/lustre/libcfs: Update comments style to match kernel green at linuxhacker.ru
2016-02-16 5:47 ` green
2016-02-16 5:47 ` [lustre-devel] [PATCH 37/45] staging/lustre/libcfs: Remove useless returns in void functions green at linuxhacker.ru
2016-02-16 5:47 ` green
2016-02-16 5:47 ` [lustre-devel] [PATCH 38/45] staging/lustre/libcfs: Remove empty lines after/before braces green at linuxhacker.ru
2016-02-16 5:47 ` green
2016-02-16 5:47 ` [lustre-devel] [PATCH 39/45] staging/lustre: Update cfs_cpu_notify switch statement with a comment green at linuxhacker.ru
2016-02-16 5:47 ` green
2016-02-16 5:47 ` [lustre-devel] [PATCH 40/45] staging/lustre: Get rid of cfs_trace_buf_type_t typedef green at linuxhacker.ru
2016-02-16 5:47 ` green
2016-02-16 5:47 ` [lustre-devel] [PATCH 41/45] staging/lustre/libcfs: Get rid of multiple assignments green at linuxhacker.ru
2016-02-16 5:47 ` green
2016-02-16 5:47 ` [lustre-devel] [PATCH 42/45] staging/lustre: Remove space after cast in cfs_crypto_hash_final() green at linuxhacker.ru
2016-02-16 5:47 ` green
2016-02-16 5:47 ` [lustre-devel] [PATCH 43/45] staging/lustre/libcfs: Replace use of printk with pr_<level> green at linuxhacker.ru
2016-02-16 5:47 ` green
2016-02-16 5:55 ` [lustre-devel] " Joe Perches
2016-02-16 5:55 ` Joe Perches
2016-02-16 16:12 ` [lustre-devel] " Oleg Drokin
2016-02-16 16:12 ` Oleg Drokin
2016-02-20 22:34 ` [lustre-devel] " Greg Kroah-Hartman
2016-02-20 22:34 ` Greg Kroah-Hartman
2016-02-16 5:47 ` [lustre-devel] [PATCH 44/45] staging/lustre: Convert cfs_trace_daemon_command to use kstrtoul green at linuxhacker.ru
2016-02-16 5:47 ` green
2016-02-16 5:47 ` [lustre-devel] [PATCH 45/45] staging/lustre: Convert cfs_str2num_check " green at linuxhacker.ru
2016-02-16 5:47 ` green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455601637-3847710-4-git-send-email-green@linuxhacker.ru \
--to=green@linuxhacker.ru \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.