From: Oliver Neukum <oneukum@suse.com>
To: Keith Packard <keithp@keithp.com>
Cc: linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: check for signals in chaoskey read function
Date: Tue, 16 Feb 2016 09:24:53 +0100 [thread overview]
Message-ID: <1455611093.4532.2.camel@suse.com> (raw)
In-Reply-To: <1455590972-2120-1-git-send-email-keithp@keithp.com>
On Mon, 2016-02-15 at 18:49 -0800, Keith Packard wrote:
> Call signal_pending before reading a chunk of data from the device so
> that long read operations can be interrupted with a signal.
Hi,
why is this needed? You are doing this right after a
mutex_lock_interruptible().
Regards
Oliver
next prev parent reply other threads:[~2016-02-16 8:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 2:49 [PATCH] usb: check for signals in chaoskey read function Keith Packard
2016-02-16 8:24 ` Oliver Neukum [this message]
2016-02-16 19:09 ` Keith Packard
2016-02-17 14:59 ` Oliver Neukum
2016-02-17 18:05 ` Keith Packard
2016-02-17 18:21 ` Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455611093.4532.2.camel@suse.com \
--to=oneukum@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.