From: Toshi Kani <toshi.kani@hpe.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, bp@suse.de,
dan.j.williams@intel.com, ross.zwisler@linux.intel.com,
vishal.l.verma@intel.com, micah.parrish@hpe.com,
brian.boylston@hpe.com, x86@kernel.org,
linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] x86/lib/copy_user_64.S: cleanup __copy_user_nocache()
Date: Wed, 17 Feb 2016 08:52:47 -0700 [thread overview]
Message-ID: <1455724367.2925.209.camel@hpe.com> (raw)
In-Reply-To: <20160217080235.GA20160@gmail.com>
On Wed, 2016-02-17 at 09:02 +0100, Ingo Molnar wrote:
> * Toshi Kani <toshi.kani@hpe.com> wrote:
>
> > Add comments to __copy_user_nocache() to clarify its procedures
> > and alignment requirement.
> >
> > Also change numeric branch target labels to named labels. The
> > labels begin with ".L" and prefix "cun" (Copy User Nocache) to
> > keep them local and unique to the function.
>
> So the .L labels are local, i.e. they are not emitted into the symbol
> table.
>
> I.e. no need to name them globally!
Right, but I thought there is risk of conflicting the names with other copy
functions in the file when they also start using descriptive labels. For
instance, ".L_finish_copy" can be easily used by other copy functions as
well.
> I've done a s/Lcun_/L_/ over the patch.
Thanks,
-Toshi
WARNING: multiple messages have this Message-ID (diff)
From: Toshi Kani <toshi.kani@hpe.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, bp@suse.de,
dan.j.williams@intel.com, ross.zwisler@linux.intel.com,
vishal.l.verma@intel.com, micah.parrish@hpe.com,
brian.boylston@hpe.com, x86@kernel.org, linux-nvdimm@ml01.01.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] x86/lib/copy_user_64.S: cleanup __copy_user_nocache()
Date: Wed, 17 Feb 2016 08:52:47 -0700 [thread overview]
Message-ID: <1455724367.2925.209.camel@hpe.com> (raw)
In-Reply-To: <20160217080235.GA20160@gmail.com>
On Wed, 2016-02-17 at 09:02 +0100, Ingo Molnar wrote:
> * Toshi Kani <toshi.kani@hpe.com> wrote:
>
> > Add comments to __copy_user_nocache() to clarify its procedures
> > and alignment requirement.
> >
> > Also change numeric branch target labels to named labels. The
> > labels begin with ".L" and prefix "cun" (Copy User Nocache) to
> > keep them local and unique to the function.
>
> So the .L labels are local, i.e. they are not emitted into the symbol
> table.
>
> I.e. no need to name them globally!
Right, but I thought there is risk of conflicting the names with other copy
functions in the file when they also start using descriptive labels. For
instance, ".L_finish_copy" can be easily used by other copy functions as
well.
> I've done a s/Lcun_/L_/ over the patch.
Thanks,
-Toshi
next prev parent reply other threads:[~2016-02-17 15:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 21:24 [PATCH v3 0/2] Fix BTT data corruptions after crash Toshi Kani
2016-02-11 21:24 ` Toshi Kani
2016-02-11 21:24 ` [PATCH v3 1/2] x86/lib/copy_user_64.S: cleanup __copy_user_nocache() Toshi Kani
2016-02-11 21:24 ` Toshi Kani
2016-02-17 8:02 ` Ingo Molnar
2016-02-17 8:02 ` Ingo Molnar
2016-02-17 15:52 ` Toshi Kani [this message]
2016-02-17 15:52 ` Toshi Kani
2016-02-17 12:13 ` [tip:x86/urgent] x86/uaccess/64: Make the __copy_user_nocache() assembly code more readable tip-bot for Toshi Kani
2016-02-11 21:24 ` [PATCH v3 2/2] x86/lib/copy_user_64.S: Handle 4-byte nocache copy Toshi Kani
2016-02-11 21:24 ` Toshi Kani
2016-02-17 12:14 ` [tip:x86/urgent] x86/uaccess/64: Handle the caching of 4-byte nocache copies properly in __copy_user_nocache () tip-bot for Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455724367.2925.209.camel@hpe.com \
--to=toshi.kani@hpe.com \
--cc=bp@suse.de \
--cc=brian.boylston@hpe.com \
--cc=dan.j.williams@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=micah.parrish@hpe.com \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=ross.zwisler@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=vishal.l.verma@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.