From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V4
Date: Thu, 18 Feb 2016 01:15:01 -0800 [thread overview]
Message-ID: <1455786901.3128.13.camel@intel.com> (raw)
In-Reply-To: <97579B9E-E7C6-4DBE-B1A2-027C2EA7F754@gmail.com>
On Thu, 2016-02-18 at 08:53 +0100, John Holland wrote:
>
> > On Feb 18, 2016, at 03:29, David Miller <davem@davemloft.net>
> wrote:
> >?
> > From: John Holland <jotihojr@gmail.com>
> > Date: Thu, 18 Feb 2016 00:49:17 +0100
> >?
> >> The Intel i211 LOM pcie ethernet controllers' iNVM operates as an
> OTP
> >> and has no externel EEPROM interface [1]. The following allows the
> >> driver to pickup the MAC address from a device tree blob when
> >> CONFIG_OF
> >> has been enabled.
> >?
> > Please use the generic eth_platform_get_mac_address(), or
> > alternatively structure your code like the ixgbe and other cases so
> > that SPARC and other OF platforms get this support as well.
>
> Don't know what you mean. The PCI path in
> eth_platform_get_mac_address() didn't return a devicetree node and I
> can find no instance of of_<function> use in ixgbe.
See commit?e1be080f292eba2ef96af999057d1603cd50b473 in my dev-queue
branch. ?Sowmini Varadhan provided a patch to
use?eth_platform_get_mac_address() instead of the "CONFIG_SPARC"
solution.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20160218/9f38b301/attachment.asc>
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: John Holland <jotihojr@gmail.com>, David Miller <davem@davemloft.net>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org
Subject: Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V4
Date: Thu, 18 Feb 2016 01:15:01 -0800 [thread overview]
Message-ID: <1455786901.3128.13.camel@intel.com> (raw)
In-Reply-To: <97579B9E-E7C6-4DBE-B1A2-027C2EA7F754@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1079 bytes --]
On Thu, 2016-02-18 at 08:53 +0100, John Holland wrote:
>
> > On Feb 18, 2016, at 03:29, David Miller <davem@davemloft.net>
> wrote:
> >
> > From: John Holland <jotihojr@gmail.com>
> > Date: Thu, 18 Feb 2016 00:49:17 +0100
> >
> >> The Intel i211 LOM pcie ethernet controllers' iNVM operates as an
> OTP
> >> and has no externel EEPROM interface [1]. The following allows the
> >> driver to pickup the MAC address from a device tree blob when
> >> CONFIG_OF
> >> has been enabled.
> >
> > Please use the generic eth_platform_get_mac_address(), or
> > alternatively structure your code like the ixgbe and other cases so
> > that SPARC and other OF platforms get this support as well.
>
> Don't know what you mean. The PCI path in
> eth_platform_get_mac_address() didn't return a devicetree node and I
> can find no instance of of_<function> use in ixgbe.
See commit e1be080f292eba2ef96af999057d1603cd50b473 in my dev-queue
branch. Sowmini Varadhan provided a patch to
use eth_platform_get_mac_address() instead of the "CONFIG_SPARC"
solution.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-02-18 9:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 23:49 [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V4 John Holland
2016-02-17 23:49 ` John Holland
2016-02-18 2:29 ` David Miller
2016-02-18 2:29 ` David Miller
2016-02-18 7:53 ` John Holland
2016-02-18 7:53 ` John Holland
2016-02-18 9:15 ` Jeff Kirsher [this message]
2016-02-18 9:15 ` Jeff Kirsher
2016-02-18 15:22 ` David Miller
2016-02-18 15:22 ` David Miller
2016-02-18 15:47 ` John Holland
2016-02-18 15:47 ` John Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455786901.3128.13.camel@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.