[PATCH] Do not suggest PREFERRED_PROVIDER for runtime providers.

[PATCH] Do not suggest PREFERRED_PROVIDER for runtime providers.

[Ismo Puustinen]

PREFERRED_PROVIDER affects only build-time dependencies. Do not suggest
the user to set it if the multiple providers are for runtime packages.

Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com>
---
 lib/bb/ui/crumbs/runningbuild.py | 3 ++-
 lib/bb/ui/knotty.py              | 3 ++-
 lib/bb/ui/toasterui.py           | 3 ++-
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/lib/bb/ui/crumbs/runningbuild.py b/lib/bb/ui/crumbs/runningbuild.py
index 16a955d..0eacd4a 100644
--- a/lib/bb/ui/crumbs/runningbuild.py
+++ b/lib/bb/ui/crumbs/runningbuild.py
@@ -386,7 +386,8 @@ class RunningBuild (gobject.GObject):
         elif isinstance(event, bb.event.MultipleProviders):
             self.emit("log", "info", "multiple providers are available for %s%s (%s)" \
                                      % (event._is_runtime and "runtime " or "", event._item, ", ".join(event._candidates)))
-            self.emit("log", "info", "consider defining a PREFERRED_PROVIDER entry to match %s" % (event._item))
+            if not event._is_runtime:
+                self.emit("log", "info", "consider defining a PREFERRED_PROVIDER entry to match %s" % (event._item))
         elif isinstance(event, bb.event.NoProvider):
             msg = ""
             if event._runtime:
diff --git a/lib/bb/ui/knotty.py b/lib/bb/ui/knotty.py
index dff92bc..eb64963 100644
--- a/lib/bb/ui/knotty.py
+++ b/lib/bb/ui/knotty.py
@@ -452,7 +452,8 @@ def main(server, eventHandler, params, tf = TerminalFilter):
                 logger.info("multiple providers are available for %s%s (%s)", event._is_runtime and "runtime " or "",
                             event._item,
                             ", ".join(event._candidates))
-                logger.info("consider defining a PREFERRED_PROVIDER entry to match %s", event._item)
+                if not event._is_runtime:
+                    logger.info("consider defining a PREFERRED_PROVIDER entry to match %s", event._item)
                 continue
             if isinstance(event, bb.event.NoProvider):
                 if event._runtime:
diff --git a/lib/bb/ui/toasterui.py b/lib/bb/ui/toasterui.py
index 32b1889..f7a2f38 100644
--- a/lib/bb/ui/toasterui.py
+++ b/lib/bb/ui/toasterui.py
@@ -257,7 +257,8 @@ def main(server, eventHandler, params):
                 logger.info("multiple providers are available for %s%s (%s)", event._is_runtime and "runtime " or "",
                             event._item,
                             ", ".join(event._candidates))
-                logger.info("consider defining a PREFERRED_PROVIDER entry to match %s", event._item)
+                if not event._is_runtime:
+                    logger.info("consider defining a PREFERRED_PROVIDER entry to match %s", event._item)
                 continue
 
             if isinstance(event, bb.event.NoProvider):
-- 
2.5.0

Re: [PATCH] Do not suggest PREFERRED_PROVIDER for runtime providers.

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 470 bytes --]

On Thu, Feb 18, 2016 at 4:34 AM Ismo Puustinen <ismo.puustinen@intel.com>
wrote:

> PREFERRED_PROVIDER affects only build-time dependencies. Do not suggest
> the user to set it if the multiple providers are for runtime packages.
>
> Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com>
>

This is incorrect. Build provider preferences affect runtime provider
resolution. It'd be better if we used a separate variable for it, but
that's not the case now.

[-- Attachment #2: Type: text/html, Size: 811 bytes --]

Re: [PATCH] Do not suggest PREFERRED_PROVIDER for runtime providers.

[Richard Purdie]

On Thu, 2016-02-18 at 15:15 +0000, Christopher Larson wrote:
> On Thu, Feb 18, 2016 at 4:34 AM Ismo Puustinen <
> ismo.puustinen@intel.com> wrote:
> > PREFERRED_PROVIDER affects only build-time dependencies. Do not
> > suggest
> > the user to set it if the multiple providers are for runtime
> > packages.
> > 
> > Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com>
> This is incorrect. Build provider preferences affect runtime provider
> resolution. It'd be better if we used a separate variable for it, but
> that's not the case now.

I think you're both right.

The message as it stands today confuses users no end and we do need to
do something about that. Equally I'm not sure no message at all is an
improvement...

There definitely is a usability problem there.

Cheers,

Richard