Re: [PATCH v2 13/16] xenalyze: handle Credit1 scheduler events

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1538 bytes --]

On Thu, 2016-02-18 at 15:31 +0000, George Dunlap wrote:
> On 16/02/16 18:12, Dario Faggioli wrote:
> > 
> > diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c
> > index 17021f1..4ab2dba 100644
> > --- a/tools/xentrace/xenalyze.c
> > +++ b/tools/xentrace/xenalyze.c
> > @@ -7673,6 +7673,63 @@ void sched_process(struct pcpu_info *p)
> >          default:
> >              process_generic(&p->ri);
> >          }
> > +    } else if(ri->evt.sub == 2) {
> > +        /* TRC_SCHED_CLASS */
> > +        switch(ri->event)
> > +        {
> > +        /* CREDIT (TRC_CSCHED_xxx) */
> > +        case TRC_SCHED_CLASS_EVT(CSCHED, 1): /* SCHED_TASKLET */
> 
> Sorry, just one more comment:
> 
> It would probably be good at some point to find a way to expose these
> in
> a public header, rather than having to manually keep this file in
> sync
> with the values in sched_*.c.  But that's a nice-to-have for another
> day. :-)
> 
Indeed. I can add this to my TODO list, although...

> (Maybe a cleanup for a GSoC / OPW student...?)
> 
... that's actually a good idea (and we should add this to the list of
similar projects, if we keep one).

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel