From: Sascha Silbe <silbe@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Markus Armbruster <armbru@redhat.com>
Subject: [Qemu-devel] [PATCH v2 2/3] qdev-monitor: sort alias table by typename
Date: Thu, 18 Feb 2016 22:44:13 +0100 [thread overview]
Message-ID: <1455831854-49013-3-git-send-email-silbe@linux.vnet.ibm.com> (raw)
In-Reply-To: <1455831854-49013-1-git-send-email-silbe@linux.vnet.ibm.com>
Sort the alias table by typename so it's easier to see which aliases
exist.
Signed-off-by: Sascha Silbe <silbe@linux.vnet.ibm.com>
---
v1->v2: Added comment asking devs to keep table sorted
---
qdev-monitor.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/qdev-monitor.c b/qdev-monitor.c
index e5136d7..4e3681c 100644
--- a/qdev-monitor.c
+++ b/qdev-monitor.c
@@ -39,19 +39,20 @@ typedef struct QDevAlias
uint32_t arch_mask;
} QDevAlias;
+/* Please keep this table sorted by typename. */
static const QDevAlias qdev_alias_table[] = {
- { "virtio-blk-pci", "virtio-blk", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
- { "virtio-net-pci", "virtio-net", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
- { "virtio-serial-pci", "virtio-serial", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
+ { "e1000", "e1000-82540em" },
+ { "ich9-ahci", "ahci" },
+ { "kvm-pci-assign", "pci-assign" },
+ { "lsi53c895a", "lsi" },
{ "virtio-balloon-pci", "virtio-balloon",
QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
{ "virtio-blk-ccw", "virtio-blk", QEMU_ARCH_S390X },
+ { "virtio-blk-pci", "virtio-blk", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
{ "virtio-net-ccw", "virtio-net", QEMU_ARCH_S390X },
+ { "virtio-net-pci", "virtio-net", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
{ "virtio-serial-ccw", "virtio-serial", QEMU_ARCH_S390X },
- { "lsi53c895a", "lsi" },
- { "ich9-ahci", "ahci" },
- { "kvm-pci-assign", "pci-assign" },
- { "e1000", "e1000-82540em" },
+ { "virtio-serial-pci", "virtio-serial", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
{ }
};
--
2.1.4
next prev parent reply other threads:[~2016-02-18 21:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 21:44 [Qemu-devel] [PATCH v2 0/3] add missing virtio aliases Sascha Silbe
2016-02-18 21:44 ` [Qemu-devel] [PATCH v2 1/3] qdev-monitor: improve error message when alias device is unavailable Sascha Silbe
2016-02-22 11:54 ` Cornelia Huck
2016-02-18 21:44 ` Sascha Silbe [this message]
2016-02-22 12:00 ` [Qemu-devel] [PATCH v2 2/3] qdev-monitor: sort alias table by typename Cornelia Huck
2016-02-18 21:44 ` [Qemu-devel] [PATCH v2 3/3] qdev-monitor: add missing aliases for virtio device classes Sascha Silbe
2016-02-22 12:09 ` Cornelia Huck
2016-02-22 17:38 ` Sascha Silbe
2016-03-04 12:44 ` [Qemu-devel] [PATCH v2 0/3] add missing virtio aliases Sascha Silbe
2016-03-04 13:01 ` Michael S. Tsirkin
2016-03-04 14:54 ` Markus Armbruster
2016-03-04 17:02 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455831854-49013-3-git-send-email-silbe@linux.vnet.ibm.com \
--to=silbe@linux.vnet.ibm.com \
--cc=armbru@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.