From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Sascha Silbe <silbe@linux.vnet.ibm.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/3] qdev-monitor: improve error message when alias device is unavailable
Date: Mon, 22 Feb 2016 12:54:29 +0100 [thread overview]
Message-ID: <20160222125429.5532a334.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <1455831854-49013-2-git-send-email-silbe@linux.vnet.ibm.com>
On Thu, 18 Feb 2016 22:44:12 +0100
Sascha Silbe <silbe@linux.vnet.ibm.com> wrote:
> When trying to instantiate an alias that points to a device class that
> doesn't exist, the error message looks like qemu misunderstood the
> request:
>
> $ s390x-softmmu/qemu-system-s390x -device virtio-gpu
> qemu-system-s390x: -device virtio-gpu: 'virtio-gpu-ccw' is not a valid
> device model name
>
> Special-case the error message to make it explicit that alias
> expansion is going on:
>
> $ s390x-softmmu/qemu-system-s390x -device virtio-gpu
> qemu-system-s390x: -device virtio-gpu: 'virtio-gpu' (alias
> 'virtio-gpu-ccw') is not a valid device model name
>
> Suggested-By: Cornelia Huck <cornelia.huck@de.ibm.com>
> Signed-off-by: Sascha Silbe <silbe@linux.vnet.ibm.com>
> ---
> v1->v2: new patch
> ---
> qdev-monitor.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
next prev parent reply other threads:[~2016-02-22 11:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 21:44 [Qemu-devel] [PATCH v2 0/3] add missing virtio aliases Sascha Silbe
2016-02-18 21:44 ` [Qemu-devel] [PATCH v2 1/3] qdev-monitor: improve error message when alias device is unavailable Sascha Silbe
2016-02-22 11:54 ` Cornelia Huck [this message]
2016-02-18 21:44 ` [Qemu-devel] [PATCH v2 2/3] qdev-monitor: sort alias table by typename Sascha Silbe
2016-02-22 12:00 ` Cornelia Huck
2016-02-18 21:44 ` [Qemu-devel] [PATCH v2 3/3] qdev-monitor: add missing aliases for virtio device classes Sascha Silbe
2016-02-22 12:09 ` Cornelia Huck
2016-02-22 17:38 ` Sascha Silbe
2016-03-04 12:44 ` [Qemu-devel] [PATCH v2 0/3] add missing virtio aliases Sascha Silbe
2016-03-04 13:01 ` Michael S. Tsirkin
2016-03-04 14:54 ` Markus Armbruster
2016-03-04 17:02 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160222125429.5532a334.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=armbru@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=silbe@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.