From: David Daney <ddaney.cavm@gmail.com>
To: Will Deacon <will.deacon@arm.com>,
linux-arm-kernel@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Frank Rowand <frowand.list@gmail.com>,
Grant Likely <grant.likely@linaro.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Matt Fleming <matt@codeblueprint.co.uk>,
linux-efi@vger.kernel.org,
Ganapatrao Kulkarni <gkulkarni@caviumnetworks.com>,
Robert Richter <rrichter@cavium.com>
Cc: linux-kernel@vger.kernel.org, David Daney <david.daney@cavium.com>
Subject: [PATCH v11 01/10] of/fdt: make generic early_init_dt_add_memory_arch() a weak alias
Date: Fri, 19 Feb 2016 17:13:10 -0800 [thread overview]
Message-ID: <1455930799-5371-2-git-send-email-ddaney.cavm@gmail.com> (raw)
In-Reply-To: <1455930799-5371-1-git-send-email-ddaney.cavm@gmail.com>
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
The function early_init_dt_add_memory_arch() is defined as __weak
so that archs can override it. However, in this override implementation,
it may still be useful to invoke the generic implementation, so instead,
rename the generic version to early_init_dt_add_memory() and turn the
original definition into a weak alias. This way, the generic version can
still be called even in the presence of an arch specific override.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Robert Richter <rrichter@cavium.com>
Signed-off-by: David Daney <david.daney@cavium.com>
---
drivers/of/fdt.c | 7 +++++--
include/linux/of_fdt.h | 1 +
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index 655f79d..cba8281 100644
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -980,7 +980,7 @@ int __init early_init_dt_scan_chosen(unsigned long node, const char *uname,
#define MAX_MEMBLOCK_ADDR ((phys_addr_t)~0)
#endif
-void __init __weak early_init_dt_add_memory_arch(u64 base, u64 size)
+void __init early_init_dt_add_memory(u64 base, u64 size)
{
const u64 phys_offset = __pa(PAGE_OFFSET);
@@ -1038,7 +1038,7 @@ void * __init __weak early_init_dt_alloc_memory_arch(u64 size, u64 align)
return __va(memblock_alloc(size, align));
}
#else
-void __init __weak early_init_dt_add_memory_arch(u64 base, u64 size)
+void __init early_init_dt_add_memory(u64 base, u64 size)
{
WARN_ON(1);
}
@@ -1058,6 +1058,9 @@ void * __init __weak early_init_dt_alloc_memory_arch(u64 size, u64 align)
}
#endif
+__weak __alias(early_init_dt_add_memory)
+void early_init_dt_add_memory_arch(u64 base, u64 size);
+
bool __init early_init_dt_verify(void *params)
{
if (!params)
diff --git a/include/linux/of_fdt.h b/include/linux/of_fdt.h
index df9ef38..463a06b 100644
--- a/include/linux/of_fdt.h
+++ b/include/linux/of_fdt.h
@@ -65,6 +65,7 @@ extern int early_init_dt_scan_memory(unsigned long node, const char *uname,
int depth, void *data);
extern void early_init_fdt_scan_reserved_mem(void);
extern void early_init_fdt_reserve_self(void);
+extern void early_init_dt_add_memory(u64 base, u64 size);
extern void early_init_dt_add_memory_arch(u64 base, u64 size);
extern int early_init_dt_reserve_memory_arch(phys_addr_t base, phys_addr_t size,
bool no_map);
--
1.8.3.1
WARNING: multiple messages have this Message-ID (diff)
From: ddaney.cavm@gmail.com (David Daney)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v11 01/10] of/fdt: make generic early_init_dt_add_memory_arch() a weak alias
Date: Fri, 19 Feb 2016 17:13:10 -0800 [thread overview]
Message-ID: <1455930799-5371-2-git-send-email-ddaney.cavm@gmail.com> (raw)
In-Reply-To: <1455930799-5371-1-git-send-email-ddaney.cavm@gmail.com>
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
The function early_init_dt_add_memory_arch() is defined as __weak
so that archs can override it. However, in this override implementation,
it may still be useful to invoke the generic implementation, so instead,
rename the generic version to early_init_dt_add_memory() and turn the
original definition into a weak alias. This way, the generic version can
still be called even in the presence of an arch specific override.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Robert Richter <rrichter@cavium.com>
Signed-off-by: David Daney <david.daney@cavium.com>
---
drivers/of/fdt.c | 7 +++++--
include/linux/of_fdt.h | 1 +
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index 655f79d..cba8281 100644
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -980,7 +980,7 @@ int __init early_init_dt_scan_chosen(unsigned long node, const char *uname,
#define MAX_MEMBLOCK_ADDR ((phys_addr_t)~0)
#endif
-void __init __weak early_init_dt_add_memory_arch(u64 base, u64 size)
+void __init early_init_dt_add_memory(u64 base, u64 size)
{
const u64 phys_offset = __pa(PAGE_OFFSET);
@@ -1038,7 +1038,7 @@ void * __init __weak early_init_dt_alloc_memory_arch(u64 size, u64 align)
return __va(memblock_alloc(size, align));
}
#else
-void __init __weak early_init_dt_add_memory_arch(u64 base, u64 size)
+void __init early_init_dt_add_memory(u64 base, u64 size)
{
WARN_ON(1);
}
@@ -1058,6 +1058,9 @@ void * __init __weak early_init_dt_alloc_memory_arch(u64 size, u64 align)
}
#endif
+__weak __alias(early_init_dt_add_memory)
+void early_init_dt_add_memory_arch(u64 base, u64 size);
+
bool __init early_init_dt_verify(void *params)
{
if (!params)
diff --git a/include/linux/of_fdt.h b/include/linux/of_fdt.h
index df9ef38..463a06b 100644
--- a/include/linux/of_fdt.h
+++ b/include/linux/of_fdt.h
@@ -65,6 +65,7 @@ extern int early_init_dt_scan_memory(unsigned long node, const char *uname,
int depth, void *data);
extern void early_init_fdt_scan_reserved_mem(void);
extern void early_init_fdt_reserve_self(void);
+extern void early_init_dt_add_memory(u64 base, u64 size);
extern void early_init_dt_add_memory_arch(u64 base, u64 size);
extern int early_init_dt_reserve_memory_arch(phys_addr_t base, phys_addr_t size,
bool no_map);
--
1.8.3.1
next prev parent reply other threads:[~2016-02-20 1:13 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-20 1:13 [PATCH v11 00/10] arm64, numa: Add numa support for arm64 platforms David Daney
2016-02-20 1:13 ` David Daney
2016-02-20 1:13 ` David Daney
2016-02-20 1:13 ` David Daney [this message]
2016-02-20 1:13 ` [PATCH v11 01/10] of/fdt: make generic early_init_dt_add_memory_arch() a weak alias David Daney
2016-02-20 1:13 ` [PATCH v11 02/10] arm64: override generic version of early_init_dt_add_memory_arch() David Daney
2016-02-20 1:13 ` David Daney
2016-02-20 1:13 ` [PATCH v11 03/10] efi: move FDT handling to separate object file David Daney
2016-02-20 1:13 ` David Daney
2016-02-20 1:13 ` [PATCH v11 04/10] arm64/efi: move EFI /chosen node parsing before early FDT processing David Daney
2016-02-20 1:13 ` David Daney
2016-02-20 1:13 ` [PATCH v11 05/10] arm64/efi: ignore DT memory nodes instead of removing them David Daney
2016-02-20 1:13 ` David Daney
2016-02-20 1:13 ` [PATCH v11 06/10] arm64/efi: ignore DT memreserve entries " David Daney
2016-02-20 1:13 ` David Daney
2016-02-20 1:13 ` [PATCH v11 07/10] Documentation, dt, numa: dt bindings for NUMA David Daney
2016-02-20 1:13 ` David Daney
2016-02-20 1:13 ` [PATCH v11 08/10] dt, numa: Add NUMA dt binding implementation David Daney
2016-02-20 1:13 ` David Daney
[not found] ` <1455930799-5371-9-git-send-email-ddaney.cavm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-23 19:36 ` Rob Herring
2016-02-23 19:36 ` Rob Herring
2016-02-23 19:36 ` Rob Herring
2016-02-26 1:26 ` David Daney
2016-02-26 1:26 ` David Daney
2016-02-26 1:26 ` David Daney
[not found] ` <56CFA9CA.6090803-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2016-02-26 18:27 ` Will Deacon
2016-02-26 18:27 ` Will Deacon
2016-02-26 18:27 ` Will Deacon
2016-03-01 16:56 ` Rob Herring
2016-03-01 16:56 ` Rob Herring
2016-03-01 16:47 ` Rob Herring
2016-03-01 16:47 ` Rob Herring
2016-03-01 16:47 ` Rob Herring
2016-03-01 16:57 ` David Daney
2016-03-01 16:57 ` David Daney
2016-03-01 17:43 ` Rob Herring
2016-03-01 17:43 ` Rob Herring
2016-03-01 17:58 ` David Daney
2016-03-01 17:58 ` David Daney
[not found] ` <1455930799-5371-1-git-send-email-ddaney.cavm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-20 1:13 ` [PATCH v11 09/10] arm64, numa: Add NUMA support for arm64 platforms David Daney
2016-02-20 1:13 ` David Daney
2016-02-20 1:13 ` David Daney
2016-02-20 8:20 ` [PATCH v11 00/10] arm64, numa: Add numa " Ard Biesheuvel
2016-02-20 8:20 ` Ard Biesheuvel
2016-02-20 8:20 ` Ard Biesheuvel
2016-02-20 10:39 ` Robert Richter
2016-02-20 10:39 ` Robert Richter
[not found] ` <20160220103959.GC4914-vWBEXY7mpu582hYKe6nXyg@public.gmane.org>
2016-02-20 10:44 ` Ard Biesheuvel
2016-02-20 10:44 ` Ard Biesheuvel
2016-02-20 10:44 ` Ard Biesheuvel
2016-02-20 1:13 ` [PATCH v11 10/10] arm64, mm, numa: Add NUMA balancing support for arm64 David Daney
2016-02-20 1:13 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455930799-5371-2-git-send-email-ddaney.cavm@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=david.daney@cavium.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=galak@codeaurora.org \
--cc=gkulkarni@caviumnetworks.com \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matt@codeblueprint.co.uk \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rrichter@cavium.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.