From: Axel Lin <axel.lin@ingics.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Julien Grossholtz <julien.grossholtz@savoirfairelinux.com>,
Alexandre Courbot <gnurou@gmail.com>,
linux-gpio@vger.kernel.org
Subject: [PATCH] gpio: ts4800: Drop redundant code to set already initialized gpio_chip fields
Date: Sat, 20 Feb 2016 14:22:46 +0800 [thread overview]
Message-ID: <1455949366.14139.1.camel@ingics.com> (raw)
Both chip->base and chip->label are correctly set by bgpio_init().
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/gpio/gpio-ts4800.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpio/gpio-ts4800.c b/drivers/gpio/gpio-ts4800.c
index 9da79e4..1478245 100644
--- a/drivers/gpio/gpio-ts4800.c
+++ b/drivers/gpio/gpio-ts4800.c
@@ -54,8 +54,6 @@ static int ts4800_gpio_probe(struct platform_device *pdev)
return retval;
}
- chip->base = -1;
- chip->label = dev_name(&pdev->dev);
chip->ngpio = ngpios;
platform_set_drvdata(pdev, chip);
--
2.1.4
next reply other threads:[~2016-02-20 6:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-20 6:22 Axel Lin [this message]
2016-02-22 16:13 ` [PATCH] gpio: ts4800: Drop redundant code to set already initialized gpio_chip fields Julien Grossholtz
2016-02-25 9:52 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455949366.14139.1.camel@ingics.com \
--to=axel.lin@ingics.com \
--cc=gnurou@gmail.com \
--cc=julien.grossholtz@savoirfairelinux.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.