* [PATCH] gpio: ts4800: Drop redundant code to set already initialized gpio_chip fields
@ 2016-02-20 6:22 Axel Lin
2016-02-22 16:13 ` Julien Grossholtz
2016-02-25 9:52 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2016-02-20 6:22 UTC (permalink / raw)
To: Linus Walleij; +Cc: Julien Grossholtz, Alexandre Courbot, linux-gpio
Both chip->base and chip->label are correctly set by bgpio_init().
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/gpio/gpio-ts4800.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpio/gpio-ts4800.c b/drivers/gpio/gpio-ts4800.c
index 9da79e4..1478245 100644
--- a/drivers/gpio/gpio-ts4800.c
+++ b/drivers/gpio/gpio-ts4800.c
@@ -54,8 +54,6 @@ static int ts4800_gpio_probe(struct platform_device *pdev)
return retval;
}
- chip->base = -1;
- chip->label = dev_name(&pdev->dev);
chip->ngpio = ngpios;
platform_set_drvdata(pdev, chip);
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: ts4800: Drop redundant code to set already initialized gpio_chip fields
2016-02-20 6:22 [PATCH] gpio: ts4800: Drop redundant code to set already initialized gpio_chip fields Axel Lin
@ 2016-02-22 16:13 ` Julien Grossholtz
2016-02-25 9:52 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Julien Grossholtz @ 2016-02-22 16:13 UTC (permalink / raw)
To: Axel Lin; +Cc: Linus Walleij, Alexandre Courbot, linux-gpio
Hello,
Thank you for this patch. I checked and it still works as expected.
----- Original Message -----
> From: "Axel Lin" <axel.lin@ingics.com>
> To: "Linus Walleij" <linus.walleij@linaro.org>
> Cc: "Julien Grossholtz" <julien.grossholtz@savoirfairelinux.com>, "Alexandre Courbot" <gnurou@gmail.com>,
> linux-gpio@vger.kernel.org
> Sent: Saturday, February 20, 2016 1:22:46 AM
> Subject: [PATCH] gpio: ts4800: Drop redundant code to set already initialized gpio_chip fields
> Both chip->base and chip->label are correctly set by bgpio_init().
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Tested-by: Julien Grossholtz <julien.grossholtz@savoirfairelinux.com>
> ---
> drivers/gpio/gpio-ts4800.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-ts4800.c b/drivers/gpio/gpio-ts4800.c
> index 9da79e4..1478245 100644
> --- a/drivers/gpio/gpio-ts4800.c
> +++ b/drivers/gpio/gpio-ts4800.c
> @@ -54,8 +54,6 @@ static int ts4800_gpio_probe(struct platform_device *pdev)
> return retval;
> }
>
> - chip->base = -1;
> - chip->label = dev_name(&pdev->dev);
> chip->ngpio = ngpios;
>
> platform_set_drvdata(pdev, chip);
> --
> 2.1.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: ts4800: Drop redundant code to set already initialized gpio_chip fields
2016-02-20 6:22 [PATCH] gpio: ts4800: Drop redundant code to set already initialized gpio_chip fields Axel Lin
2016-02-22 16:13 ` Julien Grossholtz
@ 2016-02-25 9:52 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2016-02-25 9:52 UTC (permalink / raw)
To: Axel Lin; +Cc: Julien Grossholtz, Alexandre Courbot, linux-gpio@vger.kernel.org
On Sat, Feb 20, 2016 at 7:22 AM, Axel Lin <axel.lin@ingics.com> wrote:
> Both chip->base and chip->label are correctly set by bgpio_init().
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Patch applied with Julien's Test tag.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-25 9:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-20 6:22 [PATCH] gpio: ts4800: Drop redundant code to set already initialized gpio_chip fields Axel Lin
2016-02-22 16:13 ` Julien Grossholtz
2016-02-25 9:52 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.