From: Stephen Boyd <sboyd@codeaurora.org>
To: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
uclinux-h8-devel@lists.sourceforge.jp,
Gabriel Fernandez <gabriel.fernandez@st.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Chen-Yu Tsai <wens@csie.org>, Tero Kristo <t-kristo@ti.com>,
Felipe Balbi <balbi@ti.com>,
linux-usb@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
linux-fbdev@vger.kernel.org
Subject: [PATCH 0/9] Change return type of of_clk_get_parent_count() to unsigned
Date: Mon, 22 Feb 2016 12:54:38 -0800 [thread overview]
Message-ID: <1456174487-28397-1-git-send-email-sboyd@codeaurora.org> (raw)
Russell King recently pointed out that of_clk_get_parent_count() can
return a negative number if the "clocks" property isn't present in a
node. Upon investigating all the callers of this API, none of the them
seem to care about that case, and furthermore some callers are assigning
the return value to an unsigned int which could cause very large numbers
of parents to be used.
This series changes the API to return an unsigned int from 0 (no parents)
to N, thereby avoiding any problems with negative return values.
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: <uclinux-h8-devel@lists.sourceforge.jp>
Cc: Gabriel Fernandez <gabriel.fernandez@st.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: Tero Kristo <t-kristo@ti.com>
Cc: Felipe Balbi <balbi@ti.com>
Cc: <linux-usb@vger.kernel.org>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: <linux-fbdev@vger.kernel.org>
Stephen Boyd (9):
clk: Make of_clk_get_parent_count() return unsigned ints
clk: at91: Remove impossible checks for of_clk_get_parent_count()
clk: gpio: Remove impossible check for of_clk_get_parent_count() < 0
clk: h8300: Remove impossible check for of_clk_get_parent_count()
clk: st: Remove impossible check for of_clk_get_parent_count() < 0
clk: sunxi: Use proper type for of_clk_get_parent_count() return value
clk: ti: Update for of_clk_get_parent_count() returning unsigned int
usb: dwc3: Remove impossible check for of_clk_get_parent_count() < 0
simplefb: Remove impossible check for of_clk_get_parent_count() < 0
drivers/clk/at91/clk-generated.c | 4 ++--
drivers/clk/at91/clk-main.c | 4 ++--
drivers/clk/at91/clk-master.c | 4 ++--
drivers/clk/at91/clk-programmable.c | 4 ++--
drivers/clk/at91/clk-slow.c | 6 +++---
drivers/clk/at91/clk-smd.c | 4 ++--
drivers/clk/at91/clk-usb.c | 4 ++--
drivers/clk/clk-gpio.c | 6 ++----
drivers/clk/clk.c | 16 ++++++++++++++--
drivers/clk/h8300/clk-div.c | 4 ++--
drivers/clk/h8300/clk-h8s2678.c | 4 ++--
drivers/clk/st/clk-flexgen.c | 4 ++--
drivers/clk/st/clkgen-mux.c | 4 ++--
drivers/clk/sunxi/clk-sun6i-ar100.c | 2 +-
drivers/clk/ti/clockdomain.c | 2 +-
drivers/clk/ti/composite.c | 8 ++++----
drivers/clk/ti/dpll.c | 2 +-
drivers/clk/ti/mux.c | 4 ++--
drivers/usb/dwc3/dwc3-of-simple.c | 9 +++++----
drivers/video/fbdev/simplefb.c | 4 ++--
include/linux/clk-provider.h | 2 +-
21 files changed, 56 insertions(+), 45 deletions(-)
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@codeaurora.org>
To: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
uclinux-h8-devel@lists.sourceforge.jp,
Gabriel Fernandez <gabriel.fernandez@st.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Chen-Yu Tsai <wens@csie.org>, Tero Kristo <t-kristo@ti.com>,
Felipe Balbi <balbi@ti.com>,
linux-usb@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
linux-fbdev@vger.kernel.org
Subject: [PATCH 0/9] Change return type of of_clk_get_parent_count() to unsigned
Date: Mon, 22 Feb 2016 20:54:38 +0000 [thread overview]
Message-ID: <1456174487-28397-1-git-send-email-sboyd@codeaurora.org> (raw)
Russell King recently pointed out that of_clk_get_parent_count() can
return a negative number if the "clocks" property isn't present in a
node. Upon investigating all the callers of this API, none of the them
seem to care about that case, and furthermore some callers are assigning
the return value to an unsigned int which could cause very large numbers
of parents to be used.
This series changes the API to return an unsigned int from 0 (no parents)
to N, thereby avoiding any problems with negative return values.
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: <uclinux-h8-devel@lists.sourceforge.jp>
Cc: Gabriel Fernandez <gabriel.fernandez@st.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: Tero Kristo <t-kristo@ti.com>
Cc: Felipe Balbi <balbi@ti.com>
Cc: <linux-usb@vger.kernel.org>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: <linux-fbdev@vger.kernel.org>
Stephen Boyd (9):
clk: Make of_clk_get_parent_count() return unsigned ints
clk: at91: Remove impossible checks for of_clk_get_parent_count()
clk: gpio: Remove impossible check for of_clk_get_parent_count() < 0
clk: h8300: Remove impossible check for of_clk_get_parent_count()
clk: st: Remove impossible check for of_clk_get_parent_count() < 0
clk: sunxi: Use proper type for of_clk_get_parent_count() return value
clk: ti: Update for of_clk_get_parent_count() returning unsigned int
usb: dwc3: Remove impossible check for of_clk_get_parent_count() < 0
simplefb: Remove impossible check for of_clk_get_parent_count() < 0
drivers/clk/at91/clk-generated.c | 4 ++--
drivers/clk/at91/clk-main.c | 4 ++--
drivers/clk/at91/clk-master.c | 4 ++--
drivers/clk/at91/clk-programmable.c | 4 ++--
drivers/clk/at91/clk-slow.c | 6 +++---
drivers/clk/at91/clk-smd.c | 4 ++--
drivers/clk/at91/clk-usb.c | 4 ++--
drivers/clk/clk-gpio.c | 6 ++----
drivers/clk/clk.c | 16 ++++++++++++++--
drivers/clk/h8300/clk-div.c | 4 ++--
drivers/clk/h8300/clk-h8s2678.c | 4 ++--
drivers/clk/st/clk-flexgen.c | 4 ++--
drivers/clk/st/clkgen-mux.c | 4 ++--
drivers/clk/sunxi/clk-sun6i-ar100.c | 2 +-
drivers/clk/ti/clockdomain.c | 2 +-
drivers/clk/ti/composite.c | 8 ++++----
drivers/clk/ti/dpll.c | 2 +-
drivers/clk/ti/mux.c | 4 ++--
drivers/usb/dwc3/dwc3-of-simple.c | 9 +++++----
drivers/video/fbdev/simplefb.c | 4 ++--
include/linux/clk-provider.h | 2 +-
21 files changed, 56 insertions(+), 45 deletions(-)
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next reply other threads:[~2016-02-22 20:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 20:54 Stephen Boyd [this message]
2016-02-22 20:54 ` [PATCH 0/9] Change return type of of_clk_get_parent_count() to unsigned Stephen Boyd
2016-02-22 20:54 ` [PATCH 1/9] clk: Make of_clk_get_parent_count() return unsigned ints Stephen Boyd
2016-02-22 20:54 ` [PATCH 2/9] clk: at91: Remove impossible checks for of_clk_get_parent_count() Stephen Boyd
2016-02-22 20:54 ` [PATCH 3/9] clk: gpio: Remove impossible check for of_clk_get_parent_count() < 0 Stephen Boyd
2016-02-22 20:54 ` [PATCH 4/9] clk: h8300: Remove impossible check for of_clk_get_parent_count() Stephen Boyd
2016-02-22 20:54 ` [PATCH 5/9] clk: st: Remove impossible check for of_clk_get_parent_count() < 0 Stephen Boyd
2016-02-22 20:54 ` [PATCH 6/9] clk: sunxi: Use proper type for of_clk_get_parent_count() return value Stephen Boyd
2016-02-22 20:54 ` [PATCH 7/9] clk: ti: Update for of_clk_get_parent_count() returning unsigned int Stephen Boyd
2016-02-22 20:54 ` [PATCH 8/9] usb: dwc3: Remove impossible check for of_clk_get_parent_count() < 0 Stephen Boyd
2016-02-23 6:48 ` Felipe Balbi
2016-02-22 20:54 ` [PATCH 9/9] simplefb: " Stephen Boyd
2016-02-22 20:54 ` Stephen Boyd
2016-02-26 11:35 ` Tomi Valkeinen
2016-02-26 11:35 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456174487-28397-1-git-send-email-sboyd@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=balbi@ti.com \
--cc=boris.brezillon@free-electrons.com \
--cc=gabriel.fernandez@st.com \
--cc=hdegoede@redhat.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=mturquette@baylibre.com \
--cc=plagnioj@jcrosoft.com \
--cc=t-kristo@ti.com \
--cc=tomi.valkeinen@ti.com \
--cc=uclinux-h8-devel@lists.sourceforge.jp \
--cc=wens@csie.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.