From: Joe Perches <joe@perches.com>
To: Philippe Loctaux <phil@philippeloctaux.com>, gregkh@linuxfoundation.org
Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: mite: added spaces around | and *
Date: Mon, 22 Feb 2016 16:37:08 -0800 [thread overview]
Message-ID: <1456187828.4139.3.camel@perches.com> (raw)
In-Reply-To: <1456184291-30665-1-git-send-email-phil@philippeloctaux.com>
On Tue, 2016-02-23 at 00:38 +0100, Philippe Loctaux wrote:
> Added spaces around | and *, fixing 2 checkpatch checks.
[]
> diff --git a/drivers/staging/comedi/drivers/mite.c b/drivers/staging/comedi/drivers/mite.c
[]
> @@ -51,7 +51,7 @@
>
> #include "mite.h"
>
> -#define TOP_OF_PAGE(x) ((x)|(~(PAGE_MASK)))
> +#define TOP_OF_PAGE(x) ((x) | (~(PAGE_MASK)))
It'd be nice to remove superfluous parentheses here too
+#define TOP_OF_PAGE(x) ((x) | ~PAGE_MASK)
next prev parent reply other threads:[~2016-02-23 0:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 23:38 [PATCH] Staging: comedi: mite: added spaces around | and * Philippe Loctaux
2016-02-23 0:37 ` Joe Perches [this message]
2016-02-23 11:07 ` Ian Abbott
2016-02-23 12:38 ` Philippe Loctaux
2016-02-23 16:39 ` Ian Abbott
2016-02-23 16:48 ` Ian Abbott
2016-02-23 21:47 ` Philippe Loctaux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456187828.4139.3.camel@perches.com \
--to=joe@perches.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=phil@philippeloctaux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.