From: Scott Wood <oss@buserror.net>
To: Rob Herring <robh@kernel.org>, Zhao Qiang <qiang.zhao@nxp.com>
Cc: leoyang.li@nxp.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 3/7] QE: Add uqe_serial document to bindings
Date: Tue, 23 Feb 2016 14:27:13 -0600 [thread overview]
Message-ID: <1456259233.5360.25.camel@buserror.net> (raw)
In-Reply-To: <20160223202342.GA9008@rob-hp-laptop>
On Tue, 2016-02-23 at 14:23 -0600, Rob Herring wrote:
> On Thu, Feb 18, 2016 at 09:06:08AM +0800, Zhao Qiang wrote:
> > Add uqe_serial document to
> > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> >
> > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> > ---
> > Changes for v2
> > - modify tx/rx-clock-name specification
> >
> > .../bindings/powerpc/fsl/cpm_qe/uqe_serial.txt | 19
> > +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> >
> > diff --git
> > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> > new file mode 100644
> > index 0000000..436c71c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> > @@ -0,0 +1,19 @@
> > +* Serial
> > +
> > +Currently defined compatibles:
> > +- ucc_uart
> > +
> > +Properties for ucc_uart:
> > +port-number : port number of UCC-UART
>
> How is this used?
>
> > +tx/rx-clock-name : should be "brg1"-"brg16" for internal clock source,
> > + should be "clk1"-"clk28" for external clock source.
>
> Perhaps you should be using the clock binding here and in other
> bindings?
These properties are required by the underlying UCC binding
(Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/ucc.txt) and predate
the clock binding.
-Scott
next prev parent reply other threads:[~2016-02-23 20:27 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 1:06 [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings Zhao Qiang
2016-02-18 1:06 ` Zhao Qiang
2016-02-18 1:06 ` [PATCH v2 2/7] QE: Add ucc hdlc document to bindings Zhao Qiang
2016-02-18 1:06 ` Zhao Qiang
2016-02-23 20:21 ` Rob Herring
2016-02-25 4:37 ` Qiang Zhao
2016-02-25 4:37 ` Qiang Zhao
2016-02-25 4:37 ` Qiang Zhao
2016-02-18 1:06 ` [PATCH v2 3/7] QE: Add uqe_serial " Zhao Qiang
2016-02-18 1:06 ` Zhao Qiang
2016-02-23 20:23 ` Rob Herring
2016-02-23 20:23 ` Rob Herring
2016-02-23 20:27 ` Scott Wood [this message]
2016-02-25 4:44 ` Qiang Zhao
2016-02-25 4:44 ` Qiang Zhao
2016-02-25 4:44 ` Qiang Zhao
2016-02-18 1:06 ` [PATCH v2 4/7] bindings: move cpm_qe binding from powerpc/fsl to soc/fsl Zhao Qiang
2016-02-18 1:06 ` Zhao Qiang
2016-02-23 20:24 ` Rob Herring
2016-02-23 20:24 ` Rob Herring
2016-02-18 1:06 ` [PATCH v2 5/7] T104xD4RDB: Add qe node to t104xd4rdb Zhao Qiang
2016-02-18 1:06 ` Zhao Qiang
2016-02-18 1:06 ` [PATCH v2 6/7] T104xRDB: Add qe node to t104xrdb Zhao Qiang
2016-02-18 1:06 ` Zhao Qiang
2016-02-18 1:06 ` [PATCH v2 7/7] T104xQDS: Add qe node to t104xqds Zhao Qiang
2016-02-18 1:06 ` Zhao Qiang
2016-02-23 20:15 ` [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings Rob Herring
2016-02-23 20:20 ` Scott Wood
2016-02-23 20:20 ` Scott Wood
2016-02-25 3:10 ` Qiang Zhao
2016-02-25 3:10 ` Qiang Zhao
2016-02-25 3:11 ` Scott Wood
2016-02-25 5:55 ` Qiang Zhao
2016-02-25 5:55 ` Qiang Zhao
2016-02-25 5:56 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456259233.5360.25.camel@buserror.net \
--to=oss@buserror.net \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=qiang.zhao@nxp.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.