Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings.

[Scott Wood <oss@buserror.net>]

On Tue, 2016-02-23 at 14:15 -0600, Rob Herring wrote:
> On Thu, Feb 18, 2016 at 09:06:06AM +0800, Zhao Qiang wrote:
> > Add IC, SI and SIRAM document of QE to
> > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > 
> > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> > ---
> > Changes for v2
> > 	- Add interrupt-controller in Required properties
> > 	- delete address-cells and size-cells for qe-si and qe-siram
> > 
> >  .../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt  | 50
> > ++++++++++++++++++++++
> >  1 file changed, 50 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > index 4f89302..84052a7 100644
> > --- a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > @@ -69,6 +69,56 @@ Example:
> >  	};
> >       };
> >  
> > +* Interrupt Controller (IC)
> > +
> > +Required properties:
> > +- compatible : should be "fsl,qe-ic".
> 
> > +- compatible : should be "fsl,qe-si".
> 
> > +- compatible : should be "fsl,qe-siram".
> 
> These compatible strings are all a bit generic and should have SoC 
> specific compatible strings.

I don't know about si/siram, but "fsl,qe-ic" has been around since 2008, so it
should be documented even if a more specific compatible is also added.

-Scott