From: Toshi Kani <toshi.kani@hpe.com>
To: Dexuan Cui <decui@microsoft.com>,
gregkh@linuxfoundation.org, akpm@linux-foundation.org,
tglx@linutronix.de, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
driverdev-devel@linuxdriverproject.org, jasowang@redhat.com
Cc: olaf@aepfle.de, apw@canonical.com, kys@microsoft.com,
haiyangz@microsoft.com
Subject: Re: [PATCH] x86/mm: fix slow_virt_to_phys() for X86_PAE again
Date: Thu, 25 Feb 2016 10:03:10 -0700 [thread overview]
Message-ID: <1456419790.15454.6.camel@hpe.com> (raw)
In-Reply-To: <1456394292-9030-1-git-send-email-decui@microsoft.com>
On Thu, 2016-02-25 at 01:58 -0800, Dexuan Cui wrote:
> "d1cd12108346: x86, pageattr: Prevent overflow in slow_virt_to_phys() for
> X86_PAE"
> was unintentionally removed by the recent
> "34437e67a672: x86/mm: Fix slow_virt_to_phys() to handle large PAT bit".
>
> And, the variable 'phys_addr' was defined as "unsigned long" by mistake
> -- it should
> be "phys_addr_t".
>
> As a result, Hyper-V network driver in 32-PAE Linux guest can't work
> again.
>
> Fixes: "commmit 34437e67a672: x86/mm: Fix slow_virt_to_phys() to handle
> large PAT bit"
> Signed-off-by: Dexuan Cui <decui@microsoft.com>
> Cc: Toshi Kani <toshi.kani@hpe.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: K. Y. Srinivasan <kys@microsoft.com>
> Cc: Haiyang Zhang <haiyangz@microsoft.com>
> Cc: gregkh@linuxfoundation.org
> Cc: linux-mm@kvack.org
> Cc: olaf@aepfle.de
> Cc: apw@canonical.com
> Cc: jasowang@redhat.com
> Cc: stable@vger.kernel.org
Thanks for the fix and adding the comment to explain the trick! A The change
looks good to me.
Reviewed-by: Toshi Kani <toshi.kani@hpe.com>
-Toshi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Toshi Kani <toshi.kani@hpe.com>
To: Dexuan Cui <decui@microsoft.com>,
gregkh@linuxfoundation.org, akpm@linux-foundation.org,
tglx@linutronix.de, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
driverdev-devel@linuxdriverproject.org, jasowang@redhat.com
Cc: olaf@aepfle.de, apw@canonical.com, kys@microsoft.com,
haiyangz@microsoft.com
Subject: Re: [PATCH] x86/mm: fix slow_virt_to_phys() for X86_PAE again
Date: Thu, 25 Feb 2016 10:03:10 -0700 [thread overview]
Message-ID: <1456419790.15454.6.camel@hpe.com> (raw)
In-Reply-To: <1456394292-9030-1-git-send-email-decui@microsoft.com>
On Thu, 2016-02-25 at 01:58 -0800, Dexuan Cui wrote:
> "d1cd12108346: x86, pageattr: Prevent overflow in slow_virt_to_phys() for
> X86_PAE"
> was unintentionally removed by the recent
> "34437e67a672: x86/mm: Fix slow_virt_to_phys() to handle large PAT bit".
>
> And, the variable 'phys_addr' was defined as "unsigned long" by mistake
> -- it should
> be "phys_addr_t".
>
> As a result, Hyper-V network driver in 32-PAE Linux guest can't work
> again.
>
> Fixes: "commmit 34437e67a672: x86/mm: Fix slow_virt_to_phys() to handle
> large PAT bit"
> Signed-off-by: Dexuan Cui <decui@microsoft.com>
> Cc: Toshi Kani <toshi.kani@hpe.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: K. Y. Srinivasan <kys@microsoft.com>
> Cc: Haiyang Zhang <haiyangz@microsoft.com>
> Cc: gregkh@linuxfoundation.org
> Cc: linux-mm@kvack.org
> Cc: olaf@aepfle.de
> Cc: apw@canonical.com
> Cc: jasowang@redhat.com
> Cc: stable@vger.kernel.org
Thanks for the fix and adding the comment to explain the trick! The change
looks good to me.
Reviewed-by: Toshi Kani <toshi.kani@hpe.com>
-Toshi
next prev parent reply other threads:[~2016-02-25 16:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 9:58 [PATCH] x86/mm: fix slow_virt_to_phys() for X86_PAE again Dexuan Cui
2016-02-25 9:58 ` Dexuan Cui
2016-02-25 17:03 ` Toshi Kani [this message]
2016-02-25 17:03 ` Toshi Kani
2016-02-25 18:57 ` [tip:x86/urgent] x86/mm: Fix " tip-bot for Dexuan Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456419790.15454.6.camel@hpe.com \
--to=toshi.kani@hpe.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=decui@microsoft.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=olaf@aepfle.de \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.