* [PATCH 1/2] gpio: moxart: Drop redundant code to set already initialized gpio_chip fields
@ 2016-02-26 7:59 Axel Lin
2016-02-26 8:00 ` [PATCH 2/2] gpio: moxart: Allow compile test build Axel Lin
2016-03-07 4:37 ` [PATCH 1/2] gpio: moxart: Drop redundant code to set already initialized gpio_chip fields Linus Walleij
0 siblings, 2 replies; 4+ messages in thread
From: Axel Lin @ 2016-02-26 7:59 UTC (permalink / raw)
To: Linus Walleij; +Cc: Jonas Jensen, Alexandre Courbot, linux-gpio
These fields are initialized by bgpio_init() with exactly the same settings
so remove the redundant code.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/gpio/gpio-moxart.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpio/gpio-moxart.c b/drivers/gpio/gpio-moxart.c
index ca60453..f7cf593 100644
--- a/drivers/gpio/gpio-moxart.c
+++ b/drivers/gpio/gpio-moxart.c
@@ -57,10 +57,7 @@ static int moxart_gpio_probe(struct platform_device *pdev)
gc->label = "moxart-gpio";
gc->request = gpiochip_generic_request;
gc->free = gpiochip_generic_free;
- gc->bgpio_data = gc->read_reg(gc->reg_set);
gc->base = 0;
- gc->ngpio = 32;
- gc->parent = dev;
gc->owner = THIS_MODULE;
ret = gpiochip_add_data(gc, NULL);
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] gpio: moxart: Allow compile test build
2016-02-26 7:59 [PATCH 1/2] gpio: moxart: Drop redundant code to set already initialized gpio_chip fields Axel Lin
@ 2016-02-26 8:00 ` Axel Lin
2016-03-07 4:39 ` Linus Walleij
2016-03-07 4:37 ` [PATCH 1/2] gpio: moxart: Drop redundant code to set already initialized gpio_chip fields Linus Walleij
1 sibling, 1 reply; 4+ messages in thread
From: Axel Lin @ 2016-02-26 8:00 UTC (permalink / raw)
To: Linus Walleij; +Cc: Jonas Jensen, Alexandre Courbot, linux-gpio
There is no build dependency for this driver, so enable COMPILE_TEST to get
better build coverage.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/gpio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 1118fef..f8d6035ea 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -280,7 +280,7 @@ config GPIO_MM_LANTIQ
config GPIO_MOXART
bool "MOXART GPIO support"
- depends on ARCH_MOXART
+ depends on ARCH_MOXART || COMPILE_TEST
select GPIO_GENERIC
help
Select this option to enable GPIO driver for
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] gpio: moxart: Drop redundant code to set already initialized gpio_chip fields
2016-02-26 7:59 [PATCH 1/2] gpio: moxart: Drop redundant code to set already initialized gpio_chip fields Axel Lin
2016-02-26 8:00 ` [PATCH 2/2] gpio: moxart: Allow compile test build Axel Lin
@ 2016-03-07 4:37 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2016-03-07 4:37 UTC (permalink / raw)
To: Axel Lin; +Cc: Jonas Jensen, Alexandre Courbot, linux-gpio@vger.kernel.org
On Fri, Feb 26, 2016 at 2:59 PM, Axel Lin <axel.lin@ingics.com> wrote:
> These fields are initialized by bgpio_init() with exactly the same settings
> so remove the redundant code.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-07 4:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-26 7:59 [PATCH 1/2] gpio: moxart: Drop redundant code to set already initialized gpio_chip fields Axel Lin
2016-02-26 8:00 ` [PATCH 2/2] gpio: moxart: Allow compile test build Axel Lin
2016-03-07 4:39 ` Linus Walleij
2016-03-07 4:37 ` [PATCH 1/2] gpio: moxart: Drop redundant code to set already initialized gpio_chip fields Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.