All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] automake: remove patch
@ 2016-02-25 23:02 Joseph A. Lutz
  2016-02-27  8:34 ` Richard Purdie
  0 siblings, 1 reply; 3+ messages in thread
From: Joseph A. Lutz @ 2016-02-25 23:02 UTC (permalink / raw)
  To: openembedded-core

The patch being removed in this commit removes *.pyc files from being
compiled. This dose not allow a user to select which files are included
in the image. Since optimization is no longer the default for python
we should have the ability to choose what is included in the image.

Signed-off-by: Joseph A. Lutz <joseph.lutz@novatechweb.com>
---
 ...-compile-compile-only-optimized-byte-code.patch | 42 ----------------------
 meta/recipes-devtools/automake/automake_1.15.bb    |  1 -
 2 files changed, 43 deletions(-)
 delete mode 100644 meta/recipes-devtools/automake/automake/py-compile-compile-only-optimized-byte-code.patch

diff --git a/meta/recipes-devtools/automake/automake/py-compile-compile-only-optimized-byte-code.patch b/meta/recipes-devtools/automake/automake/py-compile-compile-only-optimized-byte-code.patch
deleted file mode 100644
index f8334a7..0000000
--- a/meta/recipes-devtools/automake/automake/py-compile-compile-only-optimized-byte-code.patch
+++ /dev/null
@@ -1,42 +0,0 @@
-Upstream-Status: Inappropriate [embedded specific]
-
-* OE-Core's python creates the same binary output
-  for both pyc and pyo, so disable the creation of
-  pyc files by automake.
-
-Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
-
-Updated for automake-1.12.6
-
-Signed-off-by: Marko Lindqvist <cazfi74@gmail.com>
-
-diff -Nurd automake-1.12.6/lib/py-compile automake-1.12.6/lib/py-compile
---- automake-1.12.6/lib/py-compile	2012-12-13 21:57:31.000000000 +0200
-+++ automake-1.12.6/lib/py-compile	2012-12-27 19:34:01.426015140 +0200
-@@ -115,26 +115,6 @@
-     filetrans="filepath = os.path.normpath('$destdir' + os.sep + path)"
- fi
- 
--$PYTHON -c "
--import sys, os, py_compile, imp
--
--files = '''$files'''
--
--sys.stdout.write('Byte-compiling python modules...\n')
--for file in files.split():
--    $pathtrans
--    $filetrans
--    if not os.path.exists(filepath) or not (len(filepath) >= 3
--                                            and filepath[-3:] == '.py'):
--	    continue
--    sys.stdout.write(file)
--    sys.stdout.flush()
--    if hasattr(imp, 'get_tag'):
--        py_compile.compile(filepath, imp.cache_from_source(filepath), path)
--    else:
--        py_compile.compile(filepath, filepath + 'c', path)
--sys.stdout.write('\n')" || exit $?
--
- # this will fail for python < 1.5, but that doesn't matter ...
- $PYTHON -O -c "
- import sys, os, py_compile, imp
diff --git a/meta/recipes-devtools/automake/automake_1.15.bb b/meta/recipes-devtools/automake/automake_1.15.bb
index e3cb85b..4ce26b4 100644
--- a/meta/recipes-devtools/automake/automake_1.15.bb
+++ b/meta/recipes-devtools/automake/automake_1.15.bb
@@ -19,7 +19,6 @@ RDEPENDS_${PN} += "\
 RDEPENDS_${PN}_class-native = "autoconf-native hostperl-runtime-native"
 
 SRC_URI += " file://python-libdir.patch \
-            file://py-compile-compile-only-optimized-byte-code.patch \
             file://buildtest.patch \
             file://performance.patch"
 
-- 
2.6.2



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] automake: remove patch
  2016-02-25 23:02 [PATCH] automake: remove patch Joseph A. Lutz
@ 2016-02-27  8:34 ` Richard Purdie
  2016-02-27 23:18   ` Burton, Ross
  0 siblings, 1 reply; 3+ messages in thread
From: Richard Purdie @ 2016-02-27  8:34 UTC (permalink / raw)
  To: Joseph A. Lutz, openembedded-core

On Thu, 2016-02-25 at 17:02 -0600, Joseph A. Lutz wrote:
> The patch being removed in this commit removes *.pyc files from being
> compiled. This dose not allow a user to select which files are
> included
> in the image. Since optimization is no longer the default for python
> we should have the ability to choose what is included in the image.
> 
> Signed-off-by: Joseph A. Lutz <joseph.lutz@novatechweb.com>

This breaks the builds:

https://autobuilder.yoctoproject.org/main/builders/nightly-mips-lsb/bui
lds/652/steps/BuildImages/logs/stdio

Cheers,

Richard


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] automake: remove patch
  2016-02-27  8:34 ` Richard Purdie
@ 2016-02-27 23:18   ` Burton, Ross
  0 siblings, 0 replies; 3+ messages in thread
From: Burton, Ross @ 2016-02-27 23:18 UTC (permalink / raw)
  To: Richard Purdie; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 393 bytes --]

On 27 February 2016 at 08:34, Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> This breaks the builds:
>
> https://autobuilder.yoctoproject.org/main/builders/nightly-mips-lsb/bui
> lds/652/steps/BuildImages/logs/stdio
>

I've just sent a small patch to allow *.pyc to get packaged into cracklib
so this should be resolved.  I'll test again when mut next runs.

Ross

[-- Attachment #2: Type: text/html, Size: 980 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-02-27 23:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-25 23:02 [PATCH] automake: remove patch Joseph A. Lutz
2016-02-27  8:34 ` Richard Purdie
2016-02-27 23:18   ` Burton, Ross

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.