All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alison Schofield <amsfield22@gmail.com>
To: outreachy-kernel@googlegroups.com
Subject: reordering remove actions in iio drivers
Date: Sun, 28 Feb 2016 09:51:19 -0800	[thread overview]
Message-ID: <1456681879-2605-1-git-send-email-amsfield22@gmail.com> (raw)
In-Reply-To: <20160222194313.GA9769@amitoj-Inspiron-3542>

Hi Amitoj,

I just worked on a similar patch, and yours caught my attention.
It's not clear that it is OK to reorder the .remove actions.
Although it may seem counterintuitive to do anything *after*
you've unregistered your device, it is indeed done purposely
and safely in many iio drivers.  It usually needs to stay that way.

Check out more discussions of this on linux-iio.

And, consider the source...I'm just trying to figure this stuff
out too!

alisons


  reply	other threads:[~2016-02-28 17:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-22 19:43 [PATCH] staging: iio: accel: Replace iio_device_register with devm_iio_device_register Amitoj Kaur Chawla
2016-02-28 17:51 ` Alison Schofield [this message]
2016-02-28 17:56   ` [Outreachy kernel] reordering remove actions in iio drivers Julia Lawall
2016-02-28 18:20     ` Alison Schofield
2016-02-28 19:17       ` Julia Lawall
2016-02-29  6:15       ` Amitoj Kaur Chawla
2016-02-29  6:37 ` [PATCH] staging: iio: accel: Replace iio_device_register with devm_iio_device_register Amitoj Kaur Chawla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456681879-2605-1-git-send-email-amsfield22@gmail.com \
    --to=amsfield22@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.