From: Alison Schofield <amsfield22@gmail.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] reordering remove actions in iio drivers
Date: Sun, 28 Feb 2016 10:20:37 -0800 [thread overview]
Message-ID: <20160228182036.GA2929@d830.WORKGROUP> (raw)
In-Reply-To: <alpine.DEB.2.02.1602281856040.2147@localhost6.localdomain6>
On Sun, Feb 28, 2016 at 06:56:56PM +0100, Julia Lawall wrote:
> On Sun, 28 Feb 2016, Alison Schofield wrote:
>
> > Hi Amitoj,
> >
> > I just worked on a similar patch, and yours caught my attention.
> > It's not clear that it is OK to reorder the .remove actions.
> > Although it may seem counterintuitive to do anything *after*
> > you've unregistered your device, it is indeed done purposely
> > and safely in many iio drivers. It usually needs to stay that way.
> >
> > Check out more discussions of this on linux-iio.
> >
> > And, consider the source...I'm just trying to figure this stuff
> > out too!
>
> Which patch of Amitoj's are you referring to (or which file), and if
> possible do you have a more specific link for the discussion on linux-iio?
>
> thanks,
> julia
I'm seeing this threaded with original patch, but I guess you're not.
It is in reference to:
[PATCH] staging: iio: accel: Replace iio_device_register with
devm_iio_device_register
There is a lot of linux-iio discussion when this devm was originally
introduced with 30+ patches to migrate. Search devm_iio_device_register
and another later on when an intern tried to apply it:
http://article.gmane.org/gmane.linux.kernel.iio/13354/match=devm_iio_register
The accel case might be ok...just a heads up on the considerations.
alisons
next prev parent reply other threads:[~2016-02-28 18:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 19:43 [PATCH] staging: iio: accel: Replace iio_device_register with devm_iio_device_register Amitoj Kaur Chawla
2016-02-28 17:51 ` reordering remove actions in iio drivers Alison Schofield
2016-02-28 17:56 ` [Outreachy kernel] " Julia Lawall
2016-02-28 18:20 ` Alison Schofield [this message]
2016-02-28 19:17 ` Julia Lawall
2016-02-29 6:15 ` Amitoj Kaur Chawla
2016-02-29 6:37 ` [PATCH] staging: iio: accel: Replace iio_device_register with devm_iio_device_register Amitoj Kaur Chawla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160228182036.GA2929@d830.WORKGROUP \
--to=amsfield22@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.