* [PATCH] toaster: change TOASTER_CONF to meta-poky
@ 2016-02-29 15:44 Belen Barros Pena
2016-02-29 15:59 ` Richard Purdie
0 siblings, 1 reply; 4+ messages in thread
From: Belen Barros Pena @ 2016-02-29 15:44 UTC (permalink / raw)
To: toaster
From: Belen Barros Pena <belen.barros.pena@intel.com>
Patch 9d5483c37523ff3d334c98cafb848282b54962cd renames the layer within
the meta-yocto repository to meta-poky. This patch changes the value of
TOASTER_CONF in the toaster set up script to get Toaster to import the
meta-poky/conf/toasterconf.json file.
Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
---
bitbake/bin/toaster | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bitbake/bin/toaster b/bitbake/bin/toaster
index 72eae64..4e709ab 100755
--- a/bitbake/bin/toaster
+++ b/bitbake/bin/toaster
@@ -248,7 +248,7 @@ fi
# in the local layers that currently prevent using an arbitrary
# toasterconf.json
if [ "$TOASTER_CONF" = "" ]; then
- TOASTER_CONF="$(dirname $TOASTER)/../../meta-yocto/conf/toasterconf.json"
+ TOASTER_CONF="$(dirname $TOASTER)/../../meta-poky/conf/toasterconf.json"
export TOASTER_CONF=$(python -c "import os; print os.path.realpath('$TOASTER_CONF')")
fi
if [ ! -f $TOASTER_CONF ]; then
--
2.5.4 (Apple Git-61)
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] toaster: change TOASTER_CONF to meta-poky
2016-02-29 15:44 [PATCH] toaster: change TOASTER_CONF to meta-poky Belen Barros Pena
@ 2016-02-29 15:59 ` Richard Purdie
2016-02-29 16:23 ` Barros Pena, Belen
0 siblings, 1 reply; 4+ messages in thread
From: Richard Purdie @ 2016-02-29 15:59 UTC (permalink / raw)
To: Belen Barros Pena, toaster
On Mon, 2016-02-29 at 15:44 +0000, Belen Barros Pena wrote:
> From: Belen Barros Pena <belen.barros.pena@intel.com>
>
> Patch 9d5483c37523ff3d334c98cafb848282b54962cd renames the layer
> within
> the meta-yocto repository to meta-poky. This patch changes the value
> of
> TOASTER_CONF in the toaster set up script to get Toaster to import
> the
> meta-poky/conf/toasterconf.json file.
>
> Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
> ---
> bitbake/bin/toaster | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bitbake/bin/toaster b/bitbake/bin/toaster
> index 72eae64..4e709ab 100755
> --- a/bitbake/bin/toaster
> +++ b/bitbake/bin/toaster
> @@ -248,7 +248,7 @@ fi
> # in the local layers that currently prevent using an arbitrary
> # toasterconf.json
> if [ "$TOASTER_CONF" = "" ]; then
> - TOASTER_CONF="$(dirname $TOASTER)/../../meta
> -yocto/conf/toasterconf.json"
> + TOASTER_CONF="$(dirname $TOASTER)/../../meta
> -poky/conf/toasterconf.json"
> export TOASTER_CONF=$(python -c "import os; print
> os.path.realpath('$TOASTER_CONF')")
> fi
> if [ ! -f $TOASTER_CONF ]; then
Do we still need this or can this be removed given the TEMPLATECONF
code above it in this file? bitbake really shouldn't have OE/Yocto
knowledge ideally.
Cheers,
Richard
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] toaster: change TOASTER_CONF to meta-poky
2016-02-29 15:59 ` Richard Purdie
@ 2016-02-29 16:23 ` Barros Pena, Belen
2016-02-29 23:13 ` Brian Avery
0 siblings, 1 reply; 4+ messages in thread
From: Barros Pena, Belen @ 2016-02-29 16:23 UTC (permalink / raw)
To: Richard Purdie, toaster@yoctoproject.org
On 29/02/2016 15:59, "toaster-bounces@yoctoproject.org on behalf of
Richard Purdie" <toaster-bounces@yoctoproject.org on behalf of
richard.purdie@linuxfoundation.org> wrote:
>On Mon, 2016-02-29 at 15:44 +0000, Belen Barros Pena wrote:
>> From: Belen Barros Pena <belen.barros.pena@intel.com>
>>
>> Patch 9d5483c37523ff3d334c98cafb848282b54962cd renames the layer
>> within
>> the meta-yocto repository to meta-poky. This patch changes the value
>> of
>> TOASTER_CONF in the toaster set up script to get Toaster to import
>> the
>> meta-poky/conf/toasterconf.json file.
>>
>> Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
>> ---
>> bitbake/bin/toaster | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/bitbake/bin/toaster b/bitbake/bin/toaster
>> index 72eae64..4e709ab 100755
>> --- a/bitbake/bin/toaster
>> +++ b/bitbake/bin/toaster
>> @@ -248,7 +248,7 @@ fi
>> # in the local layers that currently prevent using an arbitrary
>> # toasterconf.json
>> if [ "$TOASTER_CONF" = "" ]; then
>> - TOASTER_CONF="$(dirname $TOASTER)/../../meta
>> -yocto/conf/toasterconf.json"
>> + TOASTER_CONF="$(dirname $TOASTER)/../../meta
>> -poky/conf/toasterconf.json"
>> export TOASTER_CONF=$(python -c "import os; print
>> os.path.realpath('$TOASTER_CONF')")
>> fi
>> if [ ! -f $TOASTER_CONF ]; then
>
>Do we still need this or can this be removed given the TEMPLATECONF
>code above it in this file?
No idea. But fwiw, I commented out lines 250 to 258 of the script, and
started Toaster from scratch. Everything seemed to work the same.
>bitbake really shouldn't have OE/Yocto
>knowledge ideally.
>
>Cheers,
>
>Richard
>
>--
>_______________________________________________
>toaster mailing list
>toaster@yoctoproject.org
>https://lists.yoctoproject.org/listinfo/toaster
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] toaster: change TOASTER_CONF to meta-poky
2016-02-29 16:23 ` Barros Pena, Belen
@ 2016-02-29 23:13 ` Brian Avery
0 siblings, 0 replies; 4+ messages in thread
From: Brian Avery @ 2016-02-29 23:13 UTC (permalink / raw)
To: Barros Pena, Belen; +Cc: toaster@yoctoproject.org
I pushed a patch to clean up bin/toaster that fixes this among a few
other issues.
-b
On Mon, Feb 29, 2016 at 8:23 AM, Barros Pena, Belen
<belen.barros.pena@intel.com> wrote:
>
>
> On 29/02/2016 15:59, "toaster-bounces@yoctoproject.org on behalf of
> Richard Purdie" <toaster-bounces@yoctoproject.org on behalf of
> richard.purdie@linuxfoundation.org> wrote:
>
>>On Mon, 2016-02-29 at 15:44 +0000, Belen Barros Pena wrote:
>>> From: Belen Barros Pena <belen.barros.pena@intel.com>
>>>
>>> Patch 9d5483c37523ff3d334c98cafb848282b54962cd renames the layer
>>> within
>>> the meta-yocto repository to meta-poky. This patch changes the value
>>> of
>>> TOASTER_CONF in the toaster set up script to get Toaster to import
>>> the
>>> meta-poky/conf/toasterconf.json file.
>>>
>>> Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
>>> ---
>>> bitbake/bin/toaster | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/bitbake/bin/toaster b/bitbake/bin/toaster
>>> index 72eae64..4e709ab 100755
>>> --- a/bitbake/bin/toaster
>>> +++ b/bitbake/bin/toaster
>>> @@ -248,7 +248,7 @@ fi
>>> # in the local layers that currently prevent using an arbitrary
>>> # toasterconf.json
>>> if [ "$TOASTER_CONF" = "" ]; then
>>> - TOASTER_CONF="$(dirname $TOASTER)/../../meta
>>> -yocto/conf/toasterconf.json"
>>> + TOASTER_CONF="$(dirname $TOASTER)/../../meta
>>> -poky/conf/toasterconf.json"
>>> export TOASTER_CONF=$(python -c "import os; print
>>> os.path.realpath('$TOASTER_CONF')")
>>> fi
>>> if [ ! -f $TOASTER_CONF ]; then
>>
>>Do we still need this or can this be removed given the TEMPLATECONF
>>code above it in this file?
>
> No idea. But fwiw, I commented out lines 250 to 258 of the script, and
> started Toaster from scratch. Everything seemed to work the same.
>
>>bitbake really shouldn't have OE/Yocto
>>knowledge ideally.
>>
>>Cheers,
>>
>>Richard
>>
>>--
>>_______________________________________________
>>toaster mailing list
>>toaster@yoctoproject.org
>>https://lists.yoctoproject.org/listinfo/toaster
>
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-02-29 23:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-29 15:44 [PATCH] toaster: change TOASTER_CONF to meta-poky Belen Barros Pena
2016-02-29 15:59 ` Richard Purdie
2016-02-29 16:23 ` Barros Pena, Belen
2016-02-29 23:13 ` Brian Avery
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.