From: Gerd Hoffmann <kraxel@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: jtomko@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] log: do not log if QEMU is daemonized but without -D
Date: Tue, 01 Mar 2016 14:51:34 +0100 [thread overview]
Message-ID: <1456840294.23994.89.camel@redhat.com> (raw)
In-Reply-To: <1456833053-8896-1-git-send-email-pbonzini@redhat.com>
On Di, 2016-03-01 at 12:50 +0100, Paolo Bonzini wrote:
> Commit 96c33a4 ("log: Redirect stderr to logfile if deamonized",
> 2016-02-22) wanted to move stderr of a daemonized QEMU to the file
> specified with -D.
>
> However, if -D was not passed, the patch had the side effect of not
> redirecting stderr to /dev/null. This happened because qemu_logfile
> was set to stderr rather than the expected value of NULL. The fix
> is simply in the "if" condition of do_qemu_set_log; the "if" for
> closing the file is also changed to match.
Tested-by: Gerd Hoffmann <kraxel@redhat.com>
cheers,
Gerd
next prev parent reply other threads:[~2016-03-01 13:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 11:50 [Qemu-devel] [PATCH] log: do not log if QEMU is daemonized but without -D Paolo Bonzini
2016-03-01 11:58 ` Cornelia Huck
2016-03-01 13:51 ` Gerd Hoffmann [this message]
2016-03-01 14:03 ` Dimitris Aragiorgis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456840294.23994.89.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=jtomko@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.