From: Joe Perches <joe@perches.com>
To: "Jeffrey Lin (林義章)" <Jeffrey.Lin@rad-ic.com>,
"jeffrey.lin" <yajohn@gmail.com>,
"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
"rydberg@euromail.se" <rydberg@euromail.se>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"jeesw@melfas.com" <jeesw@melfas.com>,
"bleung@chromium.org" <bleung@chromium.org>,
"scott.liu@emc.com.tw" <scott.liu@emc.com.tw>
Cc: "Roger Yang (楊鎮瑋)" <Roger.Yang@rad-ic.com>,
"KP Li (李昆倍)" <KP.Li@rad-ic.com>,
"Albert Shieh (謝欣瑋)" <Albert.Shieh@rad-ic.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH] driver: input :touchscreen : add Raydium I2C touch driver
Date: Wed, 02 Mar 2016 19:55:28 -0800 [thread overview]
Message-ID: <1456977328.4044.99.camel@perches.com> (raw)
In-Reply-To: <9BE4B49389AB2F41A64A32DFC844F1DF73EF8627@RADHCMS5.corp.rad-ic.com>
On Thu, 2016-03-03 at 03:14 +0000, Jeffrey Lin (林義章) wrote:
> Hi Joe:
> Thank you for your response. I'll follow your comments in next version.
OK, btw: the below looks very odd
> > +static int raydium_i2c_send_message(struct i2c_client *client,
> > + size_t len, void *data)
> > +{
> > + int error;
> > + u8 buf[HEADER_SIZE], ii;
> > +
> > + for (ii = 0; ii < HEADER_SIZE; ii++)
> > + buf[ii] = ((u8 *)data)[3 - ii];
It intermixes a #define of 4 with a hard declaration of 3
to reverse copy a byte array of length HEADER_SIZE.
Maybe use:
for (ii = 0; ii < HEADER_SIZE; ii++)
buf[ii] = ((u8 *)data)[HEADER_SIZE - 1 - ii]
next prev parent reply other threads:[~2016-03-03 3:55 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 2:29 [PATCH] driver: input :touchscreen : add Raydium I2C touch driver jeffrey.lin
2016-03-03 2:44 ` Joe Perches
2016-03-03 3:14 ` Jeffrey Lin (林義章)
2016-03-03 3:55 ` Joe Perches [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-05-24 9:05 jeffrey.lin
2016-05-17 15:34 jeffrey.lin
2016-05-11 13:51 jeffrey.lin
2016-04-29 9:45 jeffrey.lin
2016-05-04 22:58 ` Dmitry Torokhov
2016-05-05 10:23 ` Jeffrey Lin (林義章)
2016-05-05 10:25 ` Jeffrey Lin (林義章)
2016-05-06 8:24 ` jeffrey.lin
2016-05-11 16:04 ` jeffrey.lin
[not found] ` <1461923113-426-1-git-send-email-jeffrey.lin-s3Ivl27awEzQT0dZR+AlfA@public.gmane.org>
2016-05-13 4:18 ` Dmitry Torokhov
2016-05-13 4:18 ` Dmitry Torokhov
2016-05-13 17:08 ` jeffrey.lin
2016-05-16 15:46 ` jeffrey.lin
2016-05-16 15:46 ` jeffrey.lin
[not found] ` <1463413611-367-1-git-send-email-jeffrey.lin-s3Ivl27awEzQT0dZR+AlfA@public.gmane.org>
2016-05-16 16:41 ` Dmitry Torokhov
2016-05-16 16:41 ` Dmitry Torokhov
2016-05-16 16:43 ` Dmitry Torokhov
2016-05-16 15:57 ` jeffrey.lin
2016-05-17 16:07 ` jeffrey.lin
[not found] ` <1463501223-20723-1-git-send-email-jeffrey.lin-s3Ivl27awEzQT0dZR+AlfA@public.gmane.org>
2016-05-21 18:18 ` Dmitry Torokhov
2016-05-21 18:18 ` Dmitry Torokhov
2016-05-22 9:32 ` jeffrey.lin
2016-05-22 22:37 ` Dmitry Torokhov
2016-05-22 9:35 ` jeffrey.lin
2016-05-23 14:43 ` jeffrey.lin
[not found] ` <1464014633-20829-1-git-send-email-jeffrey.lin-s3Ivl27awEzQT0dZR+AlfA@public.gmane.org>
2016-05-23 16:27 ` Dmitry Torokhov
2016-05-23 16:27 ` Dmitry Torokhov
2016-05-24 9:31 ` jeffrey.lin
[not found] ` <1464082301-11539-1-git-send-email-jeffrey.lin-s3Ivl27awEzQT0dZR+AlfA@public.gmane.org>
2016-05-27 16:34 ` Dmitry Torokhov
2016-05-27 16:34 ` Dmitry Torokhov
2016-04-22 10:01 dan.huang
[not found] ` <1461319268-362-1-git-send-email-dan.huang-s3Ivl27awEzQT0dZR+AlfA@public.gmane.org>
2016-04-22 22:50 ` Dmitry Torokhov
2016-04-22 22:50 ` Dmitry Torokhov
2016-04-25 2:48 ` yajohn lin
2016-03-25 5:21 jeffrey.lin
2016-04-11 8:24 ` Dmitry Torokhov
2016-04-11 9:57 ` Jeffrey Lin (林義章)
2016-04-14 9:28 ` Jeffrey Lin (林義章)
2016-03-22 6:23 jeffrey.lin
2016-03-15 8:44 jeffrey.lin
2016-03-18 21:04 ` Rob Herring
2016-03-03 6:42 jeffrey.lin
2016-03-10 18:47 ` Dmitry Torokhov
2016-03-11 2:10 ` Jeffrey Lin (林義章)
2016-02-23 8:11 jeffrey.lin
2016-01-21 4:02 Jeffrey Lin
2016-01-21 9:37 ` Dmitry Torokhov
2016-01-15 3:30 Jeffrey Lin
2016-01-13 7:49 Jeffrey Lin
2016-01-13 8:31 ` Dmitry Torokhov
2016-01-13 8:31 ` Dmitry Torokhov
2016-01-13 19:14 ` Dmitry Torokhov
2016-01-13 6:23 Jeffrey Lin
2016-01-13 6:44 ` Dmitry Torokhov
2016-01-08 15:17 Jeffrey Lin
2016-01-09 19:20 ` Dmitry Torokhov
2015-01-06 9:25 jeffrey.lin
2015-01-06 19:43 ` Jeremiah Mahler
2015-01-07 0:40 ` Dmitry Torokhov
2014-12-08 3:42 jeffrey.lin
2014-12-05 8:15 jeffrey.lin
2014-12-05 15:04 ` Dmitry Torokhov
2014-11-14 7:19 jeffrey.lin
2014-11-14 17:43 ` Benson Leung
2014-11-14 18:00 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456977328.4044.99.camel@perches.com \
--to=joe@perches.com \
--cc=Albert.Shieh@rad-ic.com \
--cc=Jeffrey.Lin@rad-ic.com \
--cc=KP.Li@rad-ic.com \
--cc=Roger.Yang@rad-ic.com \
--cc=bleung@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=grant.likely@linaro.org \
--cc=jeesw@melfas.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rydberg@euromail.se \
--cc=scott.liu@emc.com.tw \
--cc=yajohn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.