From: Eryu Guan <eguan@redhat.com>
To: fstests@vger.kernel.org
Cc: xfs@oss.sgi.com, Eryu Guan <eguan@redhat.com>
Subject: [PATCH] xfs/137: require scratch to be CRC enabled XFS
Date: Thu, 3 Mar 2016 12:38:19 +0800 [thread overview]
Message-ID: <1456979899-7221-1-git-send-email-eguan@redhat.com> (raw)
This test is only valid for CRC enabled XFS, and test fails with
MKFS_OPTIONS="-m crc=0" being set (no mount failure detected).
Fix it by adding _require_scratch_xfs_crc, which ensures scratch device
has CRC support and enabled.
Signed-off-by: Eryu Guan <eguan@redhat.com>
---
tests/xfs/137 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/xfs/137 b/tests/xfs/137
index f162264..dec9fc9 100755
--- a/tests/xfs/137
+++ b/tests/xfs/137
@@ -52,7 +52,7 @@ rm -f $seqres.full
_supported_fs xfs
_supported_os Linux
_require_scratch
-_require_xfs_crc
+_require_scratch_xfs_crc
_require_xfs_db_command "logformat"
_scratch_mkfs >> $seqres.full 2>&1 || _fail "mkfs failed"
--
2.5.0
WARNING: multiple messages have this Message-ID (diff)
From: Eryu Guan <eguan@redhat.com>
To: fstests@vger.kernel.org
Cc: Eryu Guan <eguan@redhat.com>, xfs@oss.sgi.com
Subject: [PATCH] xfs/137: require scratch to be CRC enabled XFS
Date: Thu, 3 Mar 2016 12:38:19 +0800 [thread overview]
Message-ID: <1456979899-7221-1-git-send-email-eguan@redhat.com> (raw)
This test is only valid for CRC enabled XFS, and test fails with
MKFS_OPTIONS="-m crc=0" being set (no mount failure detected).
Fix it by adding _require_scratch_xfs_crc, which ensures scratch device
has CRC support and enabled.
Signed-off-by: Eryu Guan <eguan@redhat.com>
---
tests/xfs/137 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/xfs/137 b/tests/xfs/137
index f162264..dec9fc9 100755
--- a/tests/xfs/137
+++ b/tests/xfs/137
@@ -52,7 +52,7 @@ rm -f $seqres.full
_supported_fs xfs
_supported_os Linux
_require_scratch
-_require_xfs_crc
+_require_scratch_xfs_crc
_require_xfs_db_command "logformat"
_scratch_mkfs >> $seqres.full 2>&1 || _fail "mkfs failed"
--
2.5.0
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2016-03-03 4:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 4:38 Eryu Guan [this message]
2016-03-03 4:38 ` [PATCH] xfs/137: require scratch to be CRC enabled XFS Eryu Guan
2016-03-03 7:37 ` Christoph Hellwig
2016-03-03 7:37 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456979899-7221-1-git-send-email-eguan@redhat.com \
--to=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.