From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next] net: ixgbe: Fix cls_u32 offload support for ports and fields with masks.
Date: Fri, 04 Mar 2016 14:10:13 -0800 [thread overview]
Message-ID: <1457129413.2936.27.camel@intel.com> (raw)
In-Reply-To: <1457120869-3489-1-git-send-email-sridhar.samudrala@intel.com>
On Fri, 2016-03-04 at 11:47 -0800, Sridhar Samudrala wrote:
> Fix support for 16 bit source/dest port matches in ixgbe model.
> u32 uses a single 32-bit key value for both source and destination
> ports
> starting at offset 0. So replace the 2 functions with a single
> function
> that takes this key value/mask to program both source and dest ports.
>
> Remove the incorrect check for mask in ixgbe_configure_clsu32()
>
> Tested with the following filters:
>
> ?#tc qdisc add dev p4p1 ingress
> ?#tc filter add dev p4p1 parent ffff: protocol ip prio 99 \
> ????????handle 800:0:1 u32 ht 800: \
> ????????match ip dst 11.0.0.1/24 match ip src 11.0.0.2/24 action drop
>
> ?#tc filter del dev p4p1 parent ffff: protocol ip prio 99 \
> ????????handle 800:0:1 u32
> ?#tc filter add dev p4p1 parent ffff: protocol ip prio 99 \
> ????????handle 1: u32 divisor 1
> ?#tc filter add dev p4p1 parent ffff: protocol ip prio 99 \
> ????????handle 800:0:10 u32 ht 800: link 1: \
> ????????offset at 0 mask 0f00 shift 6 plus 0 eat match ip protocol 6
> ff
> ?#tc filter add dev p4p1 parent ffff: protocol ip prio 99 \
> ????????handle 1:0:10 u32 ht 1: \
> ????????match tcp src 1024 ffff match tcp dst 80 ffff action drop
>
> Signed-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com>
> ---
> ?drivers/net/ethernet/intel/ixgbe/ixgbe_main.c? |? 3 +--
> ?drivers/net/ethernet/intel/ixgbe/ixgbe_model.h | 17 ++++----------
> ---
> ?2 files changed, 5 insertions(+), 15 deletions(-)
Is this v2? ?If not, why are you re-sending a patch that is already in
my queue? ?If so, where is the changelog so we know what changed in
this updated v2 of the patch?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20160304/ec96557f/attachment.asc>
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Sridhar Samudrala <sridhar.samudrala@intel.com>,
intel-wired-lan@lists.osuosl.org, john.r.fastabend@intel.com,
netdev@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH net-next] net: ixgbe: Fix cls_u32 offload support for ports and fields with masks.
Date: Fri, 04 Mar 2016 14:10:13 -0800 [thread overview]
Message-ID: <1457129413.2936.27.camel@intel.com> (raw)
In-Reply-To: <1457120869-3489-1-git-send-email-sridhar.samudrala@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1758 bytes --]
On Fri, 2016-03-04 at 11:47 -0800, Sridhar Samudrala wrote:
> Fix support for 16 bit source/dest port matches in ixgbe model.
> u32 uses a single 32-bit key value for both source and destination
> ports
> starting at offset 0. So replace the 2 functions with a single
> function
> that takes this key value/mask to program both source and dest ports.
>
> Remove the incorrect check for mask in ixgbe_configure_clsu32()
>
> Tested with the following filters:
>
> #tc qdisc add dev p4p1 ingress
> #tc filter add dev p4p1 parent ffff: protocol ip prio 99 \
> handle 800:0:1 u32 ht 800: \
> match ip dst 11.0.0.1/24 match ip src 11.0.0.2/24 action drop
>
> #tc filter del dev p4p1 parent ffff: protocol ip prio 99 \
> handle 800:0:1 u32
> #tc filter add dev p4p1 parent ffff: protocol ip prio 99 \
> handle 1: u32 divisor 1
> #tc filter add dev p4p1 parent ffff: protocol ip prio 99 \
> handle 800:0:10 u32 ht 800: link 1: \
> offset at 0 mask 0f00 shift 6 plus 0 eat match ip protocol 6
> ff
> #tc filter add dev p4p1 parent ffff: protocol ip prio 99 \
> handle 1:0:10 u32 ht 1: \
> match tcp src 1024 ffff match tcp dst 80 ffff action drop
>
> Signed-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 +--
> drivers/net/ethernet/intel/ixgbe/ixgbe_model.h | 17 ++++----------
> ---
> 2 files changed, 5 insertions(+), 15 deletions(-)
Is this v2? If not, why are you re-sending a patch that is already in
my queue? If so, where is the changelog so we know what changed in
this updated v2 of the patch?
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-03-04 22:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 19:47 [Intel-wired-lan] [PATCH net-next] net: ixgbe: Fix cls_u32 offload support for ports and fields with masks Sridhar Samudrala
2016-03-04 19:47 ` Sridhar Samudrala
2016-03-04 20:41 ` [Intel-wired-lan] " John Fastabend
2016-03-04 20:41 ` John Fastabend
2016-03-04 21:27 ` Samudrala, Sridhar
2016-03-04 21:27 ` Samudrala, Sridhar
2016-03-04 22:22 ` John Fastabend
2016-03-04 23:07 ` Samudrala, Sridhar
2016-03-04 23:07 ` John Fastabend
2016-03-04 23:09 ` John Fastabend
2016-03-04 22:10 ` Jeff Kirsher [this message]
2016-03-04 22:10 ` Jeff Kirsher
2016-03-04 22:16 ` Samudrala, Sridhar
2016-03-04 22:16 ` Samudrala, Sridhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457129413.2936.27.camel@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.