All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>,
	linux-wireless@vger.kernel.org
Cc: mohammed@codeaurora.org,
	Anilkumar Kolli <akolli@qti.qualcomm.com>,
	kvalo@codeaurora.org, ath10k@lists.infradead.org
Subject: Re: [RFC v1] mac80211: Add support for per station rx stats histogram
Date: Tue, 08 Mar 2016 09:07:31 +0100	[thread overview]
Message-ID: <1457424451.2283.2.camel@sipsolutions.net> (raw)
In-Reply-To: <1457367809-13637-1-git-send-email-mohammed@qca.qualcomm.com>

On Mon, 2016-03-07 at 21:53 +0530, Mohammed Shafi Shajakhan wrote:
> 
> +#define IEEE80211_HT_MCS_NUM		32
> +#define IEEE80211_VHT_MCS_NUM		10
> +#define IEEE80211_BW_NUM		4
> +#define IEEE80211_NSS_NUM		4
> +#define IEEE80211_GI_NUM		2
> +#define IEEE80211_RATE_TABLE_NUM	320
> +#define IEEE80211_LEGACY_RATE_NUM	12

> +#ifdef CONFIG_MAC80211_DEBUG_PER_STA_RX_STATS
> +	u64 rx_legacy_pkt[IEEE80211_LEGACY_RATE_NUM];
> +	u64 rx_ht_pkt[IEEE80211_HT_MCS_NUM];
> +	u64 rx_vht_pkt[IEEE80211_VHT_MCS_NUM];
> +	u64 rx_bw_pkt[IEEE80211_BW_NUM];
> +	u64 rx_nss_pkt[IEEE80211_NSS_NUM];
> +	u64 rx_gi_pkt[IEEE80211_GI_NUM];
> +	u64 rx_rate_pkt[IEEE80211_RATE_TABLE_NUM];
> +	u64 rx_legacy_byte[IEEE80211_LEGACY_RATE_NUM];
> +	u64 rx_ht_byte[IEEE80211_HT_MCS_NUM];
> +	u64 rx_vht_byte[IEEE80211_VHT_MCS_NUM];
> +	u64 rx_bw_byte[IEEE80211_BW_NUM];
> +	u64 rx_nss_byte[IEEE80211_NSS_NUM];
> +	u64 rx_gi_byte[IEEE80211_GI_NUM];
> +	u64 rx_rate_byte[IEEE80211_RATE_TABLE_NUM];
> +#endif

Do you know how much data this is?!

Felix is going to kill both of us if I apply it.

Please look at reviving my rate-statistics patch and do the remaining
work in userspace:

http://thread.gmane.org/gmane.linux.kernel.wireless.general/133172

johannes

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>,
	linux-wireless@vger.kernel.org
Cc: ath10k@lists.infradead.org, kvalo@codeaurora.org,
	mohammed@codeaurora.org,
	Anilkumar Kolli <akolli@qti.qualcomm.com>
Subject: Re: [RFC v1] mac80211: Add support for per station rx stats histogram
Date: Tue, 08 Mar 2016 09:07:31 +0100	[thread overview]
Message-ID: <1457424451.2283.2.camel@sipsolutions.net> (raw)
In-Reply-To: <1457367809-13637-1-git-send-email-mohammed@qca.qualcomm.com>

On Mon, 2016-03-07 at 21:53 +0530, Mohammed Shafi Shajakhan wrote:
> 
> +#define IEEE80211_HT_MCS_NUM		32
> +#define IEEE80211_VHT_MCS_NUM		10
> +#define IEEE80211_BW_NUM		4
> +#define IEEE80211_NSS_NUM		4
> +#define IEEE80211_GI_NUM		2
> +#define IEEE80211_RATE_TABLE_NUM	320
> +#define IEEE80211_LEGACY_RATE_NUM	12

> +#ifdef CONFIG_MAC80211_DEBUG_PER_STA_RX_STATS
> +	u64 rx_legacy_pkt[IEEE80211_LEGACY_RATE_NUM];
> +	u64 rx_ht_pkt[IEEE80211_HT_MCS_NUM];
> +	u64 rx_vht_pkt[IEEE80211_VHT_MCS_NUM];
> +	u64 rx_bw_pkt[IEEE80211_BW_NUM];
> +	u64 rx_nss_pkt[IEEE80211_NSS_NUM];
> +	u64 rx_gi_pkt[IEEE80211_GI_NUM];
> +	u64 rx_rate_pkt[IEEE80211_RATE_TABLE_NUM];
> +	u64 rx_legacy_byte[IEEE80211_LEGACY_RATE_NUM];
> +	u64 rx_ht_byte[IEEE80211_HT_MCS_NUM];
> +	u64 rx_vht_byte[IEEE80211_VHT_MCS_NUM];
> +	u64 rx_bw_byte[IEEE80211_BW_NUM];
> +	u64 rx_nss_byte[IEEE80211_NSS_NUM];
> +	u64 rx_gi_byte[IEEE80211_GI_NUM];
> +	u64 rx_rate_byte[IEEE80211_RATE_TABLE_NUM];
> +#endif

Do you know how much data this is?!

Felix is going to kill both of us if I apply it.

Please look at reviving my rate-statistics patch and do the remaining
work in userspace:

http://thread.gmane.org/gmane.linux.kernel.wireless.general/133172

johannes

  parent reply	other threads:[~2016-03-08  8:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-07 16:23 [RFC v1] mac80211: Add support for per station rx stats histogram Mohammed Shafi Shajakhan
2016-03-07 16:23 ` Mohammed Shafi Shajakhan
2016-03-07 16:28 ` Mohammed Shafi Shajakhan
2016-03-07 16:28   ` Mohammed Shafi Shajakhan
2016-03-08  8:07 ` Johannes Berg [this message]
2016-03-08  8:07   ` Johannes Berg
2016-03-08  9:42   ` Mohammed Shafi Shajakhan
2016-03-08  9:42     ` Mohammed Shafi Shajakhan
2016-03-09 16:30     ` Mohammed Shafi Shajakhan
2016-03-09 16:30       ` Mohammed Shafi Shajakhan
2016-03-09 17:27       ` Johannes Berg
2016-03-09 17:27         ` Johannes Berg
2016-03-10  6:18         ` Mohammed Shafi Shajakhan
2016-03-10  6:18           ` Mohammed Shafi Shajakhan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1457424451.2283.2.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=akolli@qti.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mohammed@codeaurora.org \
    --cc=mohammed@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.