[PATCH] xmlrpc: fix bug in setting XMLRPCServer.single_use

[PATCH] xmlrpc: fix bug in setting XMLRPCServer.single_use

[Ed Bartosh]

XMLRPCServer.single_use attribute was always set to False.
This caused xmlrpc server to keep running after build is done as
BitBakeServerCommands.removeClient only shuts down server if its
single_use attribute is set to True.

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
---
 bitbake/lib/bb/server/xmlrpc.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/bitbake/lib/bb/server/xmlrpc.py b/bitbake/lib/bb/server/xmlrpc.py
index 1ceca51..d627550 100644
--- a/bitbake/lib/bb/server/xmlrpc.py
+++ b/bitbake/lib/bb/server/xmlrpc.py
@@ -193,6 +193,8 @@ class XMLRPCServer(SimpleXMLRPCServer, BaseImplServer):
         BaseImplServer.__init__(self)
         if (interface[1] == 0):     # anonymous port, not getting reused
             self.single_use = True
+        else:
+            self.singe_use = False
         # Use auto port configuration
         if (interface[1] == -1):
             interface = (interface[0], 0)
@@ -205,7 +207,6 @@ class XMLRPCServer(SimpleXMLRPCServer, BaseImplServer):
         self.commands = BitBakeServerCommands(self)
         self.autoregister_all_functions(self.commands, "")
         self.interface = interface
-        self.single_use = False
 
     def addcooker(self, cooker):
         BaseImplServer.addcooker(self, cooker)
-- 
2.1.4

Re: [PATCH] xmlrpc: fix bug in setting XMLRPCServer.single_use

[Joshua G Lock]

On Fri, 2016-03-04 at 10:13 +0200, Ed Bartosh wrote:
> XMLRPCServer.single_use attribute was always set to False.
> This caused xmlrpc server to keep running after build is done as
> BitBakeServerCommands.removeClient only shuts down server if its
> single_use attribute is set to True.
> 
> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> ---
>  bitbake/lib/bb/server/xmlrpc.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/bitbake/lib/bb/server/xmlrpc.py
> b/bitbake/lib/bb/server/xmlrpc.py
> index 1ceca51..d627550 100644
> --- a/bitbake/lib/bb/server/xmlrpc.py
> +++ b/bitbake/lib/bb/server/xmlrpc.py
> @@ -193,6 +193,8 @@ class XMLRPCServer(SimpleXMLRPCServer,
> BaseImplServer):
>          BaseImplServer.__init__(self)
>          if (interface[1] == 0):     # anonymous port, not getting
> reused
>              self.single_use = True
> +        else:
> +            self.singe_use = False

This won't work, right? Typo.

Regards,

Joshua

>          # Use auto port configuration
>          if (interface[1] == -1):
>              interface = (interface[0], 0)
> @@ -205,7 +207,6 @@ class XMLRPCServer(SimpleXMLRPCServer,
> BaseImplServer):
>          self.commands = BitBakeServerCommands(self)
>          self.autoregister_all_functions(self.commands, "")
>          self.interface = interface
> -        self.single_use = False
>  
>      def addcooker(self, cooker):
>          BaseImplServer.addcooker(self, cooker)
> -- 
> 2.1.4
> 

Re: [PATCH] xmlrpc: fix bug in setting XMLRPCServer.single_use

[Peter Kjellerstedt]

> -----Original Message-----
> From: bitbake-devel-bounces@lists.openembedded.org [mailto:bitbake-
> devel-bounces@lists.openembedded.org] On Behalf Of Joshua G Lock
> Sent: den 4 mars 2016 11:30
> To: bitbake-devel@lists.openembedded.org
> Subject: Re: [bitbake-devel] [PATCH] xmlrpc: fix bug in setting
> XMLRPCServer.single_use
> 
> On Fri, 2016-03-04 at 10:13 +0200, Ed Bartosh wrote:
> > XMLRPCServer.single_use attribute was always set to False.
> > This caused xmlrpc server to keep running after build is done as
> > BitBakeServerCommands.removeClient only shuts down server if its
> > single_use attribute is set to True.
> >
> > Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> > ---
> >  bitbake/lib/bb/server/xmlrpc.py | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/bitbake/lib/bb/server/xmlrpc.py
> > b/bitbake/lib/bb/server/xmlrpc.py
> > index 1ceca51..d627550 100644
> > --- a/bitbake/lib/bb/server/xmlrpc.py
> > +++ b/bitbake/lib/bb/server/xmlrpc.py
> > @@ -193,6 +193,8 @@ class XMLRPCServer(SimpleXMLRPCServer,
> > BaseImplServer):
> >          BaseImplServer.__init__(self)
> >          if (interface[1] == 0):     # anonymous port, not getting
> > reused
> >              self.single_use = True
> > +        else:
> > +            self.singe_use = False
> 
> This won't work, right? Typo.
> 
> Regards,
> 
> Joshua

Or you can simplify it as:

            self.single_use = interface[1] == 0

//Peter

Re: [PATCH] xmlrpc: fix bug in setting XMLRPCServer.single_use

[Ed Bartosh]

On Fri, Mar 04, 2016 at 10:30:06AM +0000, Joshua G Lock wrote:
> On Fri, 2016-03-04 at 10:13 +0200, Ed Bartosh wrote:
> > XMLRPCServer.single_use attribute was always set to False.
> > This caused xmlrpc server to keep running after build is done as
> > BitBakeServerCommands.removeClient only shuts down server if its
> > single_use attribute is set to True.
> > 
> > Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> > ---
> >  bitbake/lib/bb/server/xmlrpc.py | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/bitbake/lib/bb/server/xmlrpc.py
> > b/bitbake/lib/bb/server/xmlrpc.py
> > index 1ceca51..d627550 100644
> > --- a/bitbake/lib/bb/server/xmlrpc.py
> > +++ b/bitbake/lib/bb/server/xmlrpc.py
> > @@ -193,6 +193,8 @@ class XMLRPCServer(SimpleXMLRPCServer,
> > BaseImplServer):
> >          BaseImplServer.__init__(self)
> >          if (interface[1] == 0):     # anonymous port, not getting
> > reused
> >              self.single_use = True
> > +        else:
> > +            self.singe_use = False
> 
> This won't work, right? Typo.
>
Why do you think so? It works for me so far :)

--
Regards,
Ed

Re: [PATCH] xmlrpc: fix bug in setting XMLRPCServer.single_use

[Ed Bartosh]

On Fri, Mar 04, 2016 at 03:20:12PM +0000, Peter Kjellerstedt wrote:
> > -----Original Message-----
> > From: bitbake-devel-bounces@lists.openembedded.org [mailto:bitbake-
> > devel-bounces@lists.openembedded.org] On Behalf Of Joshua G Lock
> > Sent: den 4 mars 2016 11:30
> > To: bitbake-devel@lists.openembedded.org
> > Subject: Re: [bitbake-devel] [PATCH] xmlrpc: fix bug in setting
> > XMLRPCServer.single_use
> > 
> > On Fri, 2016-03-04 at 10:13 +0200, Ed Bartosh wrote:
> > > XMLRPCServer.single_use attribute was always set to False.
> > > This caused xmlrpc server to keep running after build is done as
> > > BitBakeServerCommands.removeClient only shuts down server if its
> > > single_use attribute is set to True.
> > >
> > > Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> > > ---
> > >  bitbake/lib/bb/server/xmlrpc.py | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/bitbake/lib/bb/server/xmlrpc.py
> > > b/bitbake/lib/bb/server/xmlrpc.py
> > > index 1ceca51..d627550 100644
> > > --- a/bitbake/lib/bb/server/xmlrpc.py
> > > +++ b/bitbake/lib/bb/server/xmlrpc.py
> > > @@ -193,6 +193,8 @@ class XMLRPCServer(SimpleXMLRPCServer,
> > > BaseImplServer):
> > >          BaseImplServer.__init__(self)
> > >          if (interface[1] == 0):     # anonymous port, not getting
> > > reused
> > >              self.single_use = True
> > > +        else:
> > > +            self.singe_use = False
> > 
> > This won't work, right? Typo.
> > 
> > Regards,
> > 
> > Joshua
> 
> Or you can simplify it as:
> 
>             self.single_use = interface[1] == 0

I thought about doing this. Decided not to do as it's less readable from
my point of view.

--
Regards,
Ed

Re: [PATCH] xmlrpc: fix bug in setting XMLRPCServer.single_use

[Randy Witt]

On 03/07/2016 11:22 AM, Ed Bartosh wrote:
> On Fri, Mar 04, 2016 at 03:20:12PM +0000, Peter Kjellerstedt wrote:
>>> -----Original Message-----
>>> From: bitbake-devel-bounces@lists.openembedded.org [mailto:bitbake-
>>> devel-bounces@lists.openembedded.org] On Behalf Of Joshua G Lock
>>> Sent: den 4 mars 2016 11:30
>>> To: bitbake-devel@lists.openembedded.org
>>> Subject: Re: [bitbake-devel] [PATCH] xmlrpc: fix bug in setting
>>> XMLRPCServer.single_use
>>>
>>> On Fri, 2016-03-04 at 10:13 +0200, Ed Bartosh wrote:
>>>> XMLRPCServer.single_use attribute was always set to False.
>>>> This caused xmlrpc server to keep running after build is done as
>>>> BitBakeServerCommands.removeClient only shuts down server if its
>>>> single_use attribute is set to True.
>>>>
>>>> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
>>>> ---
>>>>   bitbake/lib/bb/server/xmlrpc.py | 3 ++-
>>>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/bitbake/lib/bb/server/xmlrpc.py
>>>> b/bitbake/lib/bb/server/xmlrpc.py
>>>> index 1ceca51..d627550 100644
>>>> --- a/bitbake/lib/bb/server/xmlrpc.py
>>>> +++ b/bitbake/lib/bb/server/xmlrpc.py
>>>> @@ -193,6 +193,8 @@ class XMLRPCServer(SimpleXMLRPCServer,
>>>> BaseImplServer):
>>>>           BaseImplServer.__init__(self)
>>>>           if (interface[1] == 0):     # anonymous port, not getting
>>>> reused
>>>>               self.single_use = True
>>>> +        else:
>>>> +            self.singe_use = False
>>>
>>> This won't work, right? Typo.
>>>
>>> Regards,
>>>
>>> Joshua
>>
>> Or you can simplify it as:
>>
>>              self.single_use = interface[1] == 0
>
> I thought about doing this. Decided not to do as it's less readable from
> my point of view.

The pythonic way would be

self.single_use = True if (interface == 0) else False

> --
> Regards,
> Ed
>

Re: [PATCH] xmlrpc: fix bug in setting XMLRPCServer.single_use

[Joshua G Lock]

On Mon, 2016-03-07 at 21:21 +0200, Ed Bartosh wrote:
> On Fri, Mar 04, 2016 at 10:30:06AM +0000, Joshua G Lock wrote:
> > 
> > On Fri, 2016-03-04 at 10:13 +0200, Ed Bartosh wrote:
> > > 
> > > XMLRPCServer.single_use attribute was always set to False.
> > > This caused xmlrpc server to keep running after build is done as
> > > BitBakeServerCommands.removeClient only shuts down server if its
> > > single_use attribute is set to True.
> > > 
> > > Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> > > ---
> > >  bitbake/lib/bb/server/xmlrpc.py | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/bitbake/lib/bb/server/xmlrpc.py
> > > b/bitbake/lib/bb/server/xmlrpc.py
> > > index 1ceca51..d627550 100644
> > > --- a/bitbake/lib/bb/server/xmlrpc.py
> > > +++ b/bitbake/lib/bb/server/xmlrpc.py
> > > @@ -193,6 +193,8 @@ class XMLRPCServer(SimpleXMLRPCServer,
> > > BaseImplServer):
> > >          BaseImplServer.__init__(self)
> > >          if (interface[1] == 0):     # anonymous port, not
> > > getting
> > > reused
> > >              self.single_use = True
> > > +        else:
> > > +            self.singe_use = False
> > This won't work, right? Typo.
> > 
> Why do you think so? It works for me so far :)

I don't know toaster's code and only have the context from this diff,
however it looks like you've removed a line that sets a single_use
variable and added a line that sets a singe_use variable. These are
different variables (looks like the result of a typo) thus I wouldn't
expect it to work, or at least I wouldn't expect the addition of this
line to have affected things.

(Just to be sure I used git grep on the bitbake repository and didn't
find any instances of singe_use).

Regards,

Joshua

Re: [PATCH] xmlrpc: fix bug in setting XMLRPCServer.single_use

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1663 bytes --]

On Mon, Mar 07, 2016 at 09:21:20PM +0200, Ed Bartosh wrote:
> On Fri, Mar 04, 2016 at 10:30:06AM +0000, Joshua G Lock wrote:
> > On Fri, 2016-03-04 at 10:13 +0200, Ed Bartosh wrote:
> > > XMLRPCServer.single_use attribute was always set to False.
> > > This caused xmlrpc server to keep running after build is done as
> > > BitBakeServerCommands.removeClient only shuts down server if its
> > > single_use attribute is set to True.
> > > 
> > > Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> > > ---
> > >  bitbake/lib/bb/server/xmlrpc.py | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/bitbake/lib/bb/server/xmlrpc.py
> > > b/bitbake/lib/bb/server/xmlrpc.py
> > > index 1ceca51..d627550 100644
> > > --- a/bitbake/lib/bb/server/xmlrpc.py
> > > +++ b/bitbake/lib/bb/server/xmlrpc.py
> > > @@ -193,6 +193,8 @@ class XMLRPCServer(SimpleXMLRPCServer,
> > > BaseImplServer):
> > >          BaseImplServer.__init__(self)
> > >          if (interface[1] == 0):     # anonymous port, not getting
> > > reused
> > >              self.single_use = True
> > > +        else:
> > > +            self.singe_use = False
> > 
> > This won't work, right? Typo.
> >
> Why do you think so? It works for me so far :)

Then this change is useless, isn't it? Nothing is using singe_use
variable (with missing "l").

> 
> --
> Regards,
> Ed
> -- 
> _______________________________________________
> bitbake-devel mailing list
> bitbake-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/bitbake-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]