From: Dragos Tatulea <dragos@endocode.com>
To: ofono@ofono.org
Subject: [PATCH 13/19] ubloxmodem: push back APN into gprs context
Date: Wed, 09 Mar 2016 16:44:54 +0100 [thread overview]
Message-ID: <1457538300-7183-14-git-send-email-dragos@endocode.com> (raw)
In-Reply-To: <1457538300-7183-1-git-send-email-dragos@endocode.com>
[-- Attachment #1: Type: text/plain, Size: 1637 bytes --]
It can be that the APN is different than what a user provided. So let
the core know. This happens for example when using the default bearer:
the user doesn't provide any APN, so read the one from CGCONTRDP.
---
drivers/ubloxmodem/gprs-context.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/ubloxmodem/gprs-context.c b/drivers/ubloxmodem/gprs-context.c
index f80e1d8..b6eaa5e 100644
--- a/drivers/ubloxmodem/gprs-context.c
+++ b/drivers/ubloxmodem/gprs-context.c
@@ -183,6 +183,7 @@ static void cgcontrdp_bridge_cb(gboolean ok, GAtResult *result, gpointer user_da
const char *laddrnetmask = NULL;
const char *gw = NULL;
const char *dns[2+1] = { NULL, NULL, NULL };
+ const char *apn = NULL;
DBG("ok %d", ok);
@@ -197,7 +198,6 @@ static void cgcontrdp_bridge_cb(gboolean ok, GAtResult *result, gpointer user_da
while (g_at_result_iter_next(&iter, "+CGCONTRDP:")) {
/* tmp vals for ignored fields */
int bearer_id;
- char *apn;
if (!g_at_result_iter_next_number(&iter, &cid))
break;
@@ -234,6 +234,16 @@ static void cgcontrdp_bridge_cb(gboolean ok, GAtResult *result, gpointer user_da
if (dns[0])
ofono_gprs_context_set_ipv4_dns_servers(gc, dns);
+ if (gcd->active_context == ublox_data.default_context_id) {
+ /*
+ * Only for automatic default context: the APN set by the user
+ * might not be the correct one because the default context was
+ * used instead.
+ */
+ ofono_gprs_context_set_apn(gc, apn);
+ strcpy(gcd->apn, apn);
+ }
+
CALLBACK_WITH_SUCCESS(gcd->cb, gcd->cb_data);
}
--
2.5.0
next prev parent reply other threads:[~2016-03-09 15:44 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 15:44 [PATCH 00/19] Support for U-Blox Toby L2 modems Dragos Tatulea
2016-03-09 15:44 ` [PATCH 01/19] plugins/udevng: support the U-Blox TOBY-L2 series Dragos Tatulea
2016-03-10 14:00 ` Denis Kenzior
2016-03-09 15:44 ` [PATCH 02/19] plugins/udevng: support different interface strings to detect TOBY series Dragos Tatulea
2016-03-10 14:01 ` Denis Kenzior
2016-03-09 15:44 ` [PATCH 03/19] plugins/udevng: ublox: set model string Dragos Tatulea
2016-03-10 14:04 ` Denis Kenzior
2016-03-09 15:44 ` [PATCH 04/19] include: vendor.h: add vendor for ublox toby Dragos Tatulea
2016-03-10 14:05 ` Denis Kenzior
2016-03-09 15:44 ` [PATCH 05/19] plugins/ublox: allow enabling of TOBY L2 modems Dragos Tatulea
2016-03-10 14:11 ` Denis Kenzior
2016-03-09 15:44 ` [PATCH 06/19] plugins/ublox: use vendor from structure instead of fixed Dragos Tatulea
2016-03-09 15:44 ` [PATCH 07/19] atmodem: ublox: EPS now supported by newer ublox Dragos Tatulea
2016-03-10 14:29 ` Denis Kenzior
2016-03-10 14:43 ` Denis Kenzior
2016-03-09 15:44 ` [PATCH 08/19] atmodem: add support for U-Blox TOBY L2 modems Dragos Tatulea
2016-03-10 14:34 ` Denis Kenzior
2016-03-10 14:38 ` Dragos Tatulea
2016-03-09 15:44 ` [PATCH 09/19] atmodem: work around CGREG issues in UBlox Toby L2 Dragos Tatulea
2016-03-10 14:40 ` Denis Kenzior
2016-03-09 15:44 ` [PATCH 10/19] ubloxmodem: add Toby L2 gprs context driver Dragos Tatulea
2016-03-09 15:44 ` [PATCH 11/19] gprs-context.h: add function for setting APN Dragos Tatulea
2016-03-09 15:44 ` [PATCH 12/19] gprs: allow APN updates from gprs-context driver Dragos Tatulea
2016-03-09 15:44 ` Dragos Tatulea [this message]
2016-03-09 15:44 ` [PATCH 14/19] plugins/ublox: give names to model ids Dragos Tatulea
2016-03-09 15:44 ` [PATCH 15/19] plugins/ublox: enable ubloxmodem driver when possible Dragos Tatulea
2016-03-09 15:44 ` [PATCH 16/19] plugins/ublox: support more internet contexts Dragos Tatulea
2016-03-09 15:44 ` [PATCH 17/19] ubloxmodem: support authentication Dragos Tatulea
2016-03-09 15:44 ` [PATCH 18/19] plugins/ublox: read network mode Dragos Tatulea
2016-03-09 15:45 ` [PATCH 19/19] ubloxmodem: add routed mode support Dragos Tatulea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457538300-7183-14-git-send-email-dragos@endocode.com \
--to=dragos@endocode.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.