From: Dragos Tatulea <dragos@endocode.com>
To: ofono@ofono.org
Subject: [PATCH 19/19] ubloxmodem: add routed mode support
Date: Wed, 09 Mar 2016 16:45:00 +0100 [thread overview]
Message-ID: <1457538300-7183-20-git-send-email-dragos@endocode.com> (raw)
In-Reply-To: <1457538300-7183-1-git-send-email-dragos@endocode.com>
[-- Attachment #1: Type: text/plain, Size: 5510 bytes --]
From: Dongsu Park <dongsu@endocode.com>
Routed mode needs a different treatment than bridged mode:
* UIPCONF needs to be used for reading the interface ip configuratuion.
The spec says that DHCP should work on that interface but it doesn't. So
we read the first ip in the dhcp range and use that.
* CGCONTRDP: only APN and DNS configuration is read
---
drivers/ubloxmodem/gprs-context.c | 151 +++++++++++++++++++++++++++++++++++++-
1 file changed, 150 insertions(+), 1 deletion(-)
diff --git a/drivers/ubloxmodem/gprs-context.c b/drivers/ubloxmodem/gprs-context.c
index bc100d6..4040a07 100644
--- a/drivers/ubloxmodem/gprs-context.c
+++ b/drivers/ubloxmodem/gprs-context.c
@@ -43,6 +43,7 @@
static const char *none_prefix[] = { NULL };
static const char *cgcontrdp_prefix[] = { "+CGCONTRDP:", NULL };
+static const char *uipconf_prefix[] = { "+UIPCONF:", NULL };
struct gprs_context_data {
GAtChat *chat;
@@ -250,6 +251,65 @@ static void cgcontrdp_bridge_cb(gboolean ok, GAtResult *result, gpointer user_da
CALLBACK_WITH_SUCCESS(gcd->cb, gcd->cb_data);
}
+static void cgcontrdp_router_cb(gboolean ok, GAtResult *result, gpointer user_data)
+{
+ struct ofono_gprs_context *gc = user_data;
+ struct gprs_context_data *gcd = ofono_gprs_context_get_data(gc);
+ GAtResultIter iter;
+
+ const char *dns[2+1] = { NULL, NULL, NULL };
+ const char *apn = NULL;
+
+ DBG("ok %d", ok);
+
+ if (!ok) {
+ callback_with_error(gcd, result);
+
+ return;
+ }
+
+ g_at_result_iter_init(&iter, result);
+
+ while (g_at_result_iter_next(&iter, "+CGCONTRDP:")) {
+ /* skip cid, bearer_id */
+ g_at_result_iter_skip_next(&iter);
+ g_at_result_iter_skip_next(&iter);
+
+ /* read apn */
+ if (!g_at_result_iter_next_string(&iter, &apn))
+ break;
+
+ /* skip laddrnetmask, gw */
+ g_at_result_iter_skip_next(&iter);
+ g_at_result_iter_skip_next(&iter);
+
+ /* read dns servers */
+ if (!g_at_result_iter_next_string(&iter, &dns[0]))
+ break;
+
+ if (!g_at_result_iter_next_string(&iter, &dns[1]))
+ break;
+ }
+
+ set_gprs_context_interface(gc);
+
+ if (dns[0])
+ ofono_gprs_context_set_ipv4_dns_servers(gc, dns);
+
+ if (gcd->active_context == ublox_data.default_context_id) {
+ /*
+ * Only for automatic default context: the APN set by the user
+ * might not be the correct one because the default context was
+ * used instead.
+ */
+ ofono_gprs_context_set_apn(gc, apn);
+ strcpy(gcd->apn, apn);
+ }
+
+ CALLBACK_WITH_SUCCESS(gcd->cb, gcd->cb_data);
+ return;
+}
+
static int ublox_read_ip_config_bridge(struct ofono_gprs_context *gc)
{
struct gprs_context_data *gcd = ofono_gprs_context_get_data(gc);
@@ -262,11 +322,100 @@ static int ublox_read_ip_config_bridge(struct ofono_gprs_context *gc)
}
+static void read_uipconf_cb(gboolean ok, GAtResult *result, gpointer user_data)
+{
+ struct ofono_gprs_context *gc = user_data;
+ struct gprs_context_data *gcd = ofono_gprs_context_get_data(gc);
+ GAtResultIter iter;
+ const char *gw, *netmask, *ipaddr, *dhcp_range_start, *dhcp_range_end;
+ gboolean found = FALSE;
+ char buf[64];
+
+ DBG("ok %d", ok);
+
+ if (!ok) {
+ release_context_id(gcd->active_context);
+ callback_with_error(gcd, result);
+
+ return;
+ }
+
+ g_at_result_iter_init(&iter, result);
+
+ /* for example, +UIPCONF: entry looks like:
+ * +UIPCONF: "192.168.1.1","255.255.255.0","192.168.1.100",
+ * "192.168.1.100","fe80::48a5:b2ff:fe6f:5f86/64"
+ */
+ while (g_at_result_iter_next(&iter, "+UIPCONF:")) {
+ if (!g_at_result_iter_next_string(&iter, &gw))
+ continue;
+
+ if (!g_at_result_iter_next_string(&iter, &netmask))
+ continue;
+
+ if (!g_at_result_iter_next_string(&iter, &dhcp_range_start))
+ continue;
+
+ if (!g_at_result_iter_next_string(&iter, &dhcp_range_end))
+ continue;
+
+ /* skip other entries like IPv6 networks */
+ found = TRUE;
+ break;
+ }
+
+ if (!found)
+ goto error;
+
+ if (dhcp_range_start && dhcp_range_end) {
+ ipaddr = dhcp_range_start;
+ ofono_gprs_context_set_ipv4_address(gc, ipaddr, 1);
+ }
+
+ if (netmask)
+ ofono_gprs_context_set_ipv4_netmask(gc, netmask);
+
+ if (gw)
+ ofono_gprs_context_set_ipv4_gateway(gc, gw);
+
+ /* read ip configuration info */
+ snprintf(buf, sizeof(buf), "AT+CGCONTRDP");
+ if (g_at_chat_send(gcd->chat, buf, cgcontrdp_prefix,
+ cgcontrdp_router_cb, gc, NULL) > 0)
+ return;
+
+error:
+ CALLBACK_WITH_FAILURE(gcd->cb, gcd->cb_data);
+}
+
+static int ublox_read_ip_config_router(struct ofono_gprs_context *gc)
+{
+ struct gprs_context_data *gcd = ofono_gprs_context_get_data(gc);
+ char buf[64];
+
+ /* read ip configuration info */
+ snprintf(buf, sizeof(buf), "AT+UIPCONF?");
+ return g_at_chat_send(gcd->chat, buf, uipconf_prefix,
+ read_uipconf_cb, gc, NULL);
+
+}
+
static void ublox_post_activation(struct ofono_gprs_context *gc)
{
+ struct ofono_modem *modem;
+ const char *network_mode;
struct gprs_context_data *gcd = ofono_gprs_context_get_data(gc);
+ int ret = 0;
+
+ modem = ofono_gprs_context_get_modem(gc);
+ network_mode = ofono_modem_get_string(modem, "NetworkMode");
+
+ if (g_str_equal(network_mode, "routed"))
+ ret = ublox_read_ip_config_router(gc) ;
+ else
+ ret = ublox_read_ip_config_bridge(gc);
- if (ublox_read_ip_config_bridge(gc) < 0)
+ if (ret <= 0)
CALLBACK_WITH_FAILURE(gcd->cb, gcd->cb_data);
}
--
2.5.0
next prev parent reply other threads:[~2016-03-09 15:45 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 15:44 [PATCH 00/19] Support for U-Blox Toby L2 modems Dragos Tatulea
2016-03-09 15:44 ` [PATCH 01/19] plugins/udevng: support the U-Blox TOBY-L2 series Dragos Tatulea
2016-03-10 14:00 ` Denis Kenzior
2016-03-09 15:44 ` [PATCH 02/19] plugins/udevng: support different interface strings to detect TOBY series Dragos Tatulea
2016-03-10 14:01 ` Denis Kenzior
2016-03-09 15:44 ` [PATCH 03/19] plugins/udevng: ublox: set model string Dragos Tatulea
2016-03-10 14:04 ` Denis Kenzior
2016-03-09 15:44 ` [PATCH 04/19] include: vendor.h: add vendor for ublox toby Dragos Tatulea
2016-03-10 14:05 ` Denis Kenzior
2016-03-09 15:44 ` [PATCH 05/19] plugins/ublox: allow enabling of TOBY L2 modems Dragos Tatulea
2016-03-10 14:11 ` Denis Kenzior
2016-03-09 15:44 ` [PATCH 06/19] plugins/ublox: use vendor from structure instead of fixed Dragos Tatulea
2016-03-09 15:44 ` [PATCH 07/19] atmodem: ublox: EPS now supported by newer ublox Dragos Tatulea
2016-03-10 14:29 ` Denis Kenzior
2016-03-10 14:43 ` Denis Kenzior
2016-03-09 15:44 ` [PATCH 08/19] atmodem: add support for U-Blox TOBY L2 modems Dragos Tatulea
2016-03-10 14:34 ` Denis Kenzior
2016-03-10 14:38 ` Dragos Tatulea
2016-03-09 15:44 ` [PATCH 09/19] atmodem: work around CGREG issues in UBlox Toby L2 Dragos Tatulea
2016-03-10 14:40 ` Denis Kenzior
2016-03-09 15:44 ` [PATCH 10/19] ubloxmodem: add Toby L2 gprs context driver Dragos Tatulea
2016-03-09 15:44 ` [PATCH 11/19] gprs-context.h: add function for setting APN Dragos Tatulea
2016-03-09 15:44 ` [PATCH 12/19] gprs: allow APN updates from gprs-context driver Dragos Tatulea
2016-03-09 15:44 ` [PATCH 13/19] ubloxmodem: push back APN into gprs context Dragos Tatulea
2016-03-09 15:44 ` [PATCH 14/19] plugins/ublox: give names to model ids Dragos Tatulea
2016-03-09 15:44 ` [PATCH 15/19] plugins/ublox: enable ubloxmodem driver when possible Dragos Tatulea
2016-03-09 15:44 ` [PATCH 16/19] plugins/ublox: support more internet contexts Dragos Tatulea
2016-03-09 15:44 ` [PATCH 17/19] ubloxmodem: support authentication Dragos Tatulea
2016-03-09 15:44 ` [PATCH 18/19] plugins/ublox: read network mode Dragos Tatulea
2016-03-09 15:45 ` Dragos Tatulea [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-03-09 16:06 [PATCH 19/19] ubloxmodem: add routed mode support dragos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457538300-7183-20-git-send-email-dragos@endocode.com \
--to=dragos@endocode.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.