From: andriy.shevchenko@linux.intel.com (Andy Shevchenko)
To: linux-arm-kernel@lists.infradead.org
Subject: [patch net 1/2] net: hns: fix return value of the function about rss
Date: Thu, 10 Mar 2016 10:11:49 +0200 [thread overview]
Message-ID: <1457597509.1347.49.camel@linux.intel.com> (raw)
In-Reply-To: <1457576189-22924-2-git-send-email-yankejian@huawei.com>
On Thu, 2016-03-10 at 10:16 +0800, Kejian Yan wrote:
> Both .get_rxfh and .get_rxfh are always return 0, it should return
> result
> from hardware when getting or setting rss. And the rss function
> should
> return the correct data type.
>
@@ -1213,7 +1213,7 @@ hns_get_rss(struct net_device *netdev, u32
> *indir, u8 *key, u8 *hfunc)
> ?
>
> ? ret = ops->get_rss(priv->ae_handle, indir, key, hfunc);
> ?
> - return 0;
> + return ret;
All three can be one line.
> @@ -1241,7 +1241,7 @@ hns_set_rss(struct net_device *netdev, const
> u32 *indir, const u8 *key,
> ?
> ? ret = ops->set_rss(priv->ae_handle, indir, key, hfunc);
> ?
> - return 0;
> + return ret;
Ditto.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Kejian Yan <yankejian@huawei.com>, davem@davemloft.net
Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com,
liguozhu@huawei.com, huangdaode@hisilicon.com, arnd@arndb.de,
andrew@lunn.ch, chenny.xu@huawei.com, ivecera@redhat.com,
lisheng011@huawei.com, fengguang.wu@intel.com,
haifeng.wei@huawei.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linuxarm@huawei.com
Subject: Re: [patch net 1/2] net: hns: fix return value of the function about rss
Date: Thu, 10 Mar 2016 10:11:49 +0200 [thread overview]
Message-ID: <1457597509.1347.49.camel@linux.intel.com> (raw)
In-Reply-To: <1457576189-22924-2-git-send-email-yankejian@huawei.com>
On Thu, 2016-03-10 at 10:16 +0800, Kejian Yan wrote:
> Both .get_rxfh and .get_rxfh are always return 0, it should return
> result
> from hardware when getting or setting rss. And the rss function
> should
> return the correct data type.
>
@@ -1213,7 +1213,7 @@ hns_get_rss(struct net_device *netdev, u32
> *indir, u8 *key, u8 *hfunc)
>
>
> ret = ops->get_rss(priv->ae_handle, indir, key, hfunc);
>
> - return 0;
> + return ret;
All three can be one line.
> @@ -1241,7 +1241,7 @@ hns_set_rss(struct net_device *netdev, const
> u32 *indir, const u8 *key,
>
> ret = ops->set_rss(priv->ae_handle, indir, key, hfunc);
>
> - return 0;
> + return ret;
Ditto.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2016-03-10 8:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 2:16 [patch net 0/2] net: hns: get and set RSS indirection table by using ethtool Kejian Yan
2016-03-10 2:16 ` Kejian Yan
2016-03-10 2:16 ` [patch net 1/2] net: hns: fix return value of the function about rss Kejian Yan
2016-03-10 2:16 ` Kejian Yan
2016-03-10 8:11 ` Andy Shevchenko [this message]
2016-03-10 8:11 ` Andy Shevchenko
2016-03-10 12:04 ` Yankejian (Hackim Yim)
2016-03-10 12:04 ` Yankejian (Hackim Yim)
2016-03-10 12:04 ` Yankejian (Hackim Yim)
2016-03-10 2:16 ` [patch net 2/2] net: hns: fixes a bug of RSS Kejian Yan
2016-03-10 2:16 ` Kejian Yan
2016-03-10 8:24 ` Andy Shevchenko
2016-03-10 8:24 ` Andy Shevchenko
2016-03-10 13:03 ` Yankejian (Hackim Yim)
2016-03-10 13:03 ` Yankejian (Hackim Yim)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457597509.1347.49.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.