[PATCH] fetch2: include PV in 'Unable to get checksum for SRC_URI entry' warnings

[PATCH] fetch2: include PV in 'Unable to get checksum for SRC_URI entry' warnings

[Andre McCurdy]

Referencing PN only is ambiguous if multiple versions of a recipe are
present.

Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
 lib/bb/fetch2/__init__.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/bb/fetch2/__init__.py b/lib/bb/fetch2/__init__.py
index f86014c..124420d 100644
--- a/lib/bb/fetch2/__init__.py
+++ b/lib/bb/fetch2/__init__.py
@@ -1102,9 +1102,9 @@ def get_checksum_file_list(d):
                 if f.startswith(dl_dir):
                     # The local fetcher's behaviour is to return a path under DL_DIR if it couldn't find the file anywhere else
                     if os.path.exists(f):
-                        bb.warn("Getting checksum for %s SRC_URI entry %s: file not found except in DL_DIR" % (d.getVar('PN', True), os.path.basename(f)))
+                        bb.warn("Getting checksum for %s SRC_URI entry %s: file not found except in DL_DIR" % (d.getVar('P', True), os.path.basename(f)))
                     else:
-                        bb.warn("Unable to get checksum for %s SRC_URI entry %s: file could not be found" % (d.getVar('PN', True), os.path.basename(f)))
+                        bb.warn("Unable to get checksum for %s SRC_URI entry %s: file could not be found" % (d.getVar('P', True), os.path.basename(f)))
                 filelist.append(f + ":" + str(os.path.exists(f)))
 
     return " ".join(filelist)
-- 
1.9.1

Re: [PATCH] fetch2: include PV in 'Unable to get checksum for SRC_URI entry' warnings

[Richard Purdie]

On Thu, 2016-03-10 at 08:15 -0800, Andre McCurdy wrote:
> Referencing PN only is ambiguous if multiple versions of a recipe are
> present.
> 
> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
> ---
>  lib/bb/fetch2/__init__.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Now that we have recipe level messages getting a prefix during logging,
do we still need this with master?

Cheers,

Richard

Re: [PATCH] fetch2: include PV in 'Unable to get checksum for SRC_URI entry' warnings

[Andre McCurdy]

On Thu, Mar 10, 2016 at 8:30 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Thu, 2016-03-10 at 08:15 -0800, Andre McCurdy wrote:
>> Referencing PN only is ambiguous if multiple versions of a recipe are
>> present.
>>
>> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
>> ---
>>  lib/bb/fetch2/__init__.py | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Now that we have recipe level messages getting a prefix during logging,
> do we still need this with master?

Yes, I think so. These warnings get generated during initial parsing,
not as part of executing any task.

> Cheers,
>
> Richard

Re: [PATCH] fetch2: include PV in 'Unable to get checksum for SRC_URI entry' warnings

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1890 bytes --]

On Thu, Mar 10, 2016 at 08:15:32AM -0800, Andre McCurdy wrote:
> Referencing PN only is ambiguous if multiple versions of a recipe are
> present.

Would it work with FILE to get immediate pointer to file where to update
them?

> 
> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
> ---
>  lib/bb/fetch2/__init__.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/bb/fetch2/__init__.py b/lib/bb/fetch2/__init__.py
> index f86014c..124420d 100644
> --- a/lib/bb/fetch2/__init__.py
> +++ b/lib/bb/fetch2/__init__.py
> @@ -1102,9 +1102,9 @@ def get_checksum_file_list(d):
>                  if f.startswith(dl_dir):
>                      # The local fetcher's behaviour is to return a path under DL_DIR if it couldn't find the file anywhere else
>                      if os.path.exists(f):
> -                        bb.warn("Getting checksum for %s SRC_URI entry %s: file not found except in DL_DIR" % (d.getVar('PN', True), os.path.basename(f)))
> +                        bb.warn("Getting checksum for %s SRC_URI entry %s: file not found except in DL_DIR" % (d.getVar('P', True), os.path.basename(f)))
>                      else:
> -                        bb.warn("Unable to get checksum for %s SRC_URI entry %s: file could not be found" % (d.getVar('PN', True), os.path.basename(f)))
> +                        bb.warn("Unable to get checksum for %s SRC_URI entry %s: file could not be found" % (d.getVar('P', True), os.path.basename(f)))
>                  filelist.append(f + ":" + str(os.path.exists(f)))
>  
>      return " ".join(filelist)
> -- 
> 1.9.1
> 
> -- 
> _______________________________________________
> bitbake-devel mailing list
> bitbake-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/bitbake-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: [PATCH] fetch2: include PV in 'Unable to get checksum for SRC_URI entry' warnings

[Andre McCurdy]

On Thu, Mar 10, 2016 at 9:03 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Thu, Mar 10, 2016 at 08:15:32AM -0800, Andre McCurdy wrote:
>> Referencing PN only is ambiguous if multiple versions of a recipe are
>> present.
>
> Would it work with FILE to get immediate pointer to file where to update
> them?

Yes, that works. It's a bit more verbose but having the full path to
the recipe is useful.

>>
>> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
>> ---
>>  lib/bb/fetch2/__init__.py | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/lib/bb/fetch2/__init__.py b/lib/bb/fetch2/__init__.py
>> index f86014c..124420d 100644
>> --- a/lib/bb/fetch2/__init__.py
>> +++ b/lib/bb/fetch2/__init__.py
>> @@ -1102,9 +1102,9 @@ def get_checksum_file_list(d):
>>                  if f.startswith(dl_dir):
>>                      # The local fetcher's behaviour is to return a path under DL_DIR if it couldn't find the file anywhere else
>>                      if os.path.exists(f):
>> -                        bb.warn("Getting checksum for %s SRC_URI entry %s: file not found except in DL_DIR" % (d.getVar('PN', True), os.path.basename(f)))
>> +                        bb.warn("Getting checksum for %s SRC_URI entry %s: file not found except in DL_DIR" % (d.getVar('P', True), os.path.basename(f)))
>>                      else:
>> -                        bb.warn("Unable to get checksum for %s SRC_URI entry %s: file could not be found" % (d.getVar('PN', True), os.path.basename(f)))
>> +                        bb.warn("Unable to get checksum for %s SRC_URI entry %s: file could not be found" % (d.getVar('P', True), os.path.basename(f)))
>>                  filelist.append(f + ":" + str(os.path.exists(f)))
>>
>>      return " ".join(filelist)
>> --
>> 1.9.1
>>
>> --
>> _______________________________________________
>> bitbake-devel mailing list
>> bitbake-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/bitbake-devel
>
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

Re: [PATCH] fetch2: include PV in 'Unable to get checksum for SRC_URI entry' warnings

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 649 bytes --]

On Thu, Mar 10, 2016 at 10:38 AM Andre McCurdy <armccurdy@gmail.com> wrote:

> On Thu, Mar 10, 2016 at 9:03 AM, Martin Jansa <martin.jansa@gmail.com>
> wrote:
> > On Thu, Mar 10, 2016 at 08:15:32AM -0800, Andre McCurdy wrote:
> >> Referencing PN only is ambiguous if multiple versions of a recipe are
> >> present.
> >
> > Would it work with FILE to get immediate pointer to file where to update
> > them?
>
> Yes, that works. It's a bit more verbose but having the full path to
> the recipe is useful.
>

It's worth noting that current bitbake master includes PN/PV in all log
messages coming from tasks for the knotty UI already.

[-- Attachment #2: Type: text/html, Size: 1028 bytes --]