Re: [Outreachy kernel] [PATCH v2] staging: dgnc: fixed spaces before and after "|"

Re: [Outreachy kernel] [PATCH v2] staging: dgnc: fixed spaces before and after "|"

[Julia Lawall]

On Sun, 13 Mar 2016, Juliana Rodrigues wrote:

> This patch fixes the following issue while mantains
> 80 character per line limit by removing
> unnecessary parenthesis.
> 
> CHECK: spaces preferred around that '|' (ctx:VxV)
> +       writeb((UART_FCR_ENABLE_FIFO|UART_FCR_CLEAR_RCVR|UART_FCR_CLEAR_XMIT),
> 
> Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
> ---
> Changes on v2:
>    - Removed file name from subject line
> ---
>  drivers/staging/dgnc/dgnc_cls.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
> index 51db98b..6e1e475 100644
> --- a/drivers/staging/dgnc/dgnc_cls.c
> +++ b/drivers/staging/dgnc/dgnc_cls.c
> @@ -1168,8 +1168,10 @@ static void cls_uart_init(struct channel_t *ch)
>  	/* Clear out UART and FIFO */
>  	readb(&ch->ch_cls_uart->txrx);
>  
> -	writeb((UART_FCR_ENABLE_FIFO|UART_FCR_CLEAR_RCVR|UART_FCR_CLEAR_XMIT),
> -	       &ch->ch_cls_uart->isr_fcr);
> +	writeb((UART_FCR_ENABLE_FIFO |
> +		UART_FCR_CLEAR_RCVR  |
> +		UART_FCR_CLEAR_XMIT),

So it couldn't fit on one line?  Or not even on two lines?

> +		&ch->ch_cls_uart->isr_fcr);

This line should not have been affected by the patch.  It has been 
indented by one more space to make it look like it is part of the | rather 
than an argument of writeb.

julia

>  	udelay(10);
>  
>  	ch->ch_flags |= (CH_FIFO_ENABLED | CH_TX_FIFO_EMPTY | CH_TX_FIFO_LWM);
> -- 
> 2.7.2
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160313052049.GA12145%40spock.
> For more options, visit https://groups.google.com/d/optout.
> 

Re: [Outreachy kernel] [PATCH v2] staging: dgnc: fixed spaces before and after "|"

[Juliana Rodrigues]

Em Dom, 2016-03-13 às 06:33 +0100, Julia Lawall escreveu:
> On Sun, 13 Mar 2016, Juliana Rodrigues wrote:
> 
> > This patch fixes the following issue while mantains
> > 80 character per line limit by removing
> > unnecessary parenthesis.
> > 
> > CHECK: spaces preferred around that '|' (ctx:VxV)
> > +      
> writeb((UART_FCR_ENABLE_FIFO|UART_FCR_CLEAR_RCVR|UART_FCR_CLEAR_XMIT)
> ,
> > 
> > Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
> > ---
> > Changes on v2:
> >    - Removed file name from subject line
> > ---
> >  drivers/staging/dgnc/dgnc_cls.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/dgnc/dgnc_cls.c
> b/drivers/staging/dgnc/dgnc_cls.c
> > index 51db98b..6e1e475 100644
> > --- a/drivers/staging/dgnc/dgnc_cls.c
> > +++ b/drivers/staging/dgnc/dgnc_cls.c
> > @@ -1168,8 +1168,10 @@ static void cls_uart_init(struct channel_t
> *ch)
> >       /* Clear out UART and FIFO */
> >       readb(&ch->ch_cls_uart->txrx);
> >  
> >
> -     writeb((UART_FCR_ENABLE_FIFO|UART_FCR_CLEAR_RCVR|UART_FCR_CLEAR
> _XMIT),
> > -            &ch->ch_cls_uart->isr_fcr);
> > +     writeb((UART_FCR_ENABLE_FIFO |
> > +             UART_FCR_CLEAR_RCVR  |
> > +             UART_FCR_CLEAR_XMIT),
> 
> So it couldn't fit on one line?  Or not even on two lines?

Actually, I forgot to add the changes into this patch, sorry.
I sent a new one to fix this.

> 
> > +             &ch->ch_cls_uart->isr_fcr);
> 
> This line should not have been affected by the patch.  It has been 
> indented by one more space to make it look like it is part of the |
> rather 
> than an argument of writeb.
> 
> julia
> 
> >       udelay(10);
> >  
> >       ch->ch_flags |= (CH_FIFO_ENABLED | CH_TX_FIFO_EMPTY |
> CH_TX_FIFO_LWM);
> > -- 
> > 2.7.2
> > 
> > -- 
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it,
> send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.
> com.
> > To view this discussion on the web visit https://groups.google.com/
> d/msgid/outreachy-kernel/20160313052049.GA12145%40spock.
> > For more options, visit https://groups.google.com/d/optout.
> >