From: Alexander Larsson <alexl-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Andy Lutomirski <luto-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Linux FS Devel
<linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Eric W. Biederman"
<ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
Cc: Linux Containers
<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
gnome-os-list-rDKQcyrBJuzYtjvyW6yDsg@public.gmane.org,
mclasen-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH] devpts: Make ptmx be owned by the userns owner instead of userns-local 0
Date: Mon, 14 Mar 2016 16:42:55 +0100 [thread overview]
Message-ID: <1457970175.30497.1.camel@redhat.com> (raw)
In-Reply-To: <fd99f5e7144be5de87c88e069cd5edb36136eefd.1457931898.git.luto-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
On sön, 2016-03-13 at 22:06 -0700, Andy Lutomirski wrote:
> We used to have ptmx be owned by the inner uid and gid 0. Change
> this: if the owner and group are both mapped but are not both 0,
> then use the owner instead.
>
> For container-style namespaces (LXC, etc), this should have no
> effect -- UID 0 is will either be the owner or will be unmapped.
>
> The important behavior change is for sandboxes: many sandboxes
> intentionally do not create an inner uid 0. Without this patch,
> mounting devpts in such a sandbox is awkward. With this patch, it
> will just work and ptmx will be owned by the namespace owner.
>
> Cc: Alexander Larsson <alexl@redhat.com>
> Cc: mclasen@redhat.com
> Cc: "Eric W. Biederman" <ebiederm@xmission.com>
> Cc: Linux Containers <containers@lists.linux-foundation.org>
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
Tested-by: Alexander Larsson <alexl@redhat.com>
Seems to work fine for me! Thanks!
--
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Alexander Larsson Red Hat, Inc
alexl@redhat.com alexander.larsson@gmail.com
He's an uncontrollable voodoo librarian with a robot buddy named Sparky.
She's a cynical winged journalist from the wrong side of the tracks. They
fight crime!
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/containers
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Larsson <alexl@redhat.com>
To: Andy Lutomirski <luto@kernel.org>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
linux-kernel@vger.kernel.org,
"Eric W. Biederman" <ebiederm@xmission.com>
Cc: gnome-os-list@gnome.org,
James Bottomley <James.Bottomley@hansenpartnership.com>,
mclasen@redhat.com,
Linux Containers <containers@lists.linux-foundation.org>
Subject: Re: [PATCH] devpts: Make ptmx be owned by the userns owner instead of userns-local 0
Date: Mon, 14 Mar 2016 16:42:55 +0100 [thread overview]
Message-ID: <1457970175.30497.1.camel@redhat.com> (raw)
In-Reply-To: <fd99f5e7144be5de87c88e069cd5edb36136eefd.1457931898.git.luto@kernel.org>
On sön, 2016-03-13 at 22:06 -0700, Andy Lutomirski wrote:
> We used to have ptmx be owned by the inner uid and gid 0. Change
> this: if the owner and group are both mapped but are not both 0,
> then use the owner instead.
>
> For container-style namespaces (LXC, etc), this should have no
> effect -- UID 0 is will either be the owner or will be unmapped.
>
> The important behavior change is for sandboxes: many sandboxes
> intentionally do not create an inner uid 0. Without this patch,
> mounting devpts in such a sandbox is awkward. With this patch, it
> will just work and ptmx will be owned by the namespace owner.
>
> Cc: Alexander Larsson <alexl@redhat.com>
> Cc: mclasen@redhat.com
> Cc: "Eric W. Biederman" <ebiederm@xmission.com>
> Cc: Linux Containers <containers@lists.linux-foundation.org>
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
Tested-by: Alexander Larsson <alexl@redhat.com>
Seems to work fine for me! Thanks!
--
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Alexander Larsson Red Hat, Inc
alexl@redhat.com alexander.larsson@gmail.com
He's an uncontrollable voodoo librarian with a robot buddy named Sparky.
She's a cynical winged journalist from the wrong side of the tracks. They
fight crime!
next prev parent reply other threads:[~2016-03-14 15:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 5:06 [PATCH] devpts: Make ptmx be owned by the userns owner instead of userns-local 0 Andy Lutomirski
2016-03-14 5:06 ` Andy Lutomirski
2016-03-14 8:35 ` Serge Hallyn
2016-03-15 18:21 ` Andy Lutomirski
2016-03-15 18:21 ` Andy Lutomirski
[not found] ` <fd99f5e7144be5de87c88e069cd5edb36136eefd.1457931898.git.luto-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-03-14 8:35 ` Serge Hallyn
2016-03-14 15:42 ` Alexander Larsson [this message]
2016-03-14 15:42 ` Alexander Larsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457970175.30497.1.camel@redhat.com \
--to=alexl-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
--cc=gnome-os-list-rDKQcyrBJuzYtjvyW6yDsg@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=luto-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=mclasen-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.