From: David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Alex Williamson
<alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] iommu/vt-d: Ratelimit fault handler
Date: Tue, 15 Mar 2016 19:47:56 +0000 [thread overview]
Message-ID: <1458071276.78634.124.camel@infradead.org> (raw)
In-Reply-To: <20160315163503.2875.49980.stgit-GCcqpEzw8uZBDLzU/O5InQ@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 891 bytes --]
On Tue, 2016-03-15 at 10:35 -0600, Alex Williamson wrote:
> Fault rates can easily overwhelm the console and make the system
> unresponsive. Ratelimit to allow an opportunity for maintenance.
>
> Signed-off-by: Alex Williamson <alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Rather than just rate-limiting the printk, I'd prefer to handle this
explicitly. There's a bit in the context-entry which can tell the IOMMU
not to bother raising an interrupt at all. And then we can re-enable it
if/when the driver recovers the device. (Or perhaps just when it next
does a mapping).
We really ought to be reporting faults to drivers too, FWIW. I keep
meaning to take a look at that.
--
David Woodhouse Open Source Technology Centre
David.Woodhouse-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org Intel Corporation
[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5691 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: David Woodhouse <dwmw2@infradead.org>
To: Alex Williamson <alex.williamson@redhat.com>,
iommu@lists.linux-foundation.org
Cc: joro@8bytes.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/vt-d: Ratelimit fault handler
Date: Tue, 15 Mar 2016 19:47:56 +0000 [thread overview]
Message-ID: <1458071276.78634.124.camel@infradead.org> (raw)
In-Reply-To: <20160315163503.2875.49980.stgit@gimli.home>
[-- Attachment #1: Type: text/plain, Size: 832 bytes --]
On Tue, 2016-03-15 at 10:35 -0600, Alex Williamson wrote:
> Fault rates can easily overwhelm the console and make the system
> unresponsive. Ratelimit to allow an opportunity for maintenance.
>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Rather than just rate-limiting the printk, I'd prefer to handle this
explicitly. There's a bit in the context-entry which can tell the IOMMU
not to bother raising an interrupt at all. And then we can re-enable it
if/when the driver recovers the device. (Or perhaps just when it next
does a mapping).
We really ought to be reporting faults to drivers too, FWIW. I keep
meaning to take a look at that.
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5691 bytes --]
next prev parent reply other threads:[~2016-03-15 19:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 16:35 [PATCH] iommu/vt-d: Ratelimit fault handler Alex Williamson
2016-03-15 16:35 ` Alex Williamson
2016-03-15 17:10 ` Joe Perches
2016-03-15 18:01 ` Joe Perches
[not found] ` <20160315163503.2875.49980.stgit-GCcqpEzw8uZBDLzU/O5InQ@public.gmane.org>
2016-03-15 19:47 ` David Woodhouse [this message]
2016-03-15 19:47 ` David Woodhouse
[not found] ` <1458071276.78634.124.camel-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-03-17 16:53 ` Alex Williamson
2016-03-17 16:53 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458071276.78634.124.camel@infradead.org \
--to=dwmw2-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.