From: Ian Campbell <ijc@debian.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-kbuild@vger.kernel.org, Michal Marek <mmarek@suse.cz>,
devicetree@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Robert Richter <rrichter@cavium.com>,
Ben Hutchings <ben@decadent.org.uk>,
linux-arm-kernel@lists.infradead.org,
debian-kernel <debian-kernel@lists.debian.org>
Subject: Re: dtbs_install recursing on subdirs-y and dtbs-subdir leading to race?
Date: Wed, 16 Mar 2016 09:13:08 +0000 [thread overview]
Message-ID: <1458119588.28250.61.camel@debian.org> (raw)
In-Reply-To: <20160316090449.GW19428@n2100.arm.linux.org.uk>
On Wed, 2016-03-16 at 09:04 +0000, Russell King - ARM Linux wrote:
> On Wed, Mar 16, 2016 at 08:54:34AM +0000, Ian Campbell wrote:
> > Where it appears that multiple instance of __dtbs_install_prep have
> > been running in parallel at least the apm and arm subdirectories of
> > arch/arm64/boot/dts, with both of them then racing in the
> > $(Q)if [ -d $(INSTALL_DTBS_PATH) ]; then mv
> $(INSTALL_DTBS_PATH) $(INSTALL_DTBS_PATH).old; fi
> > rule since apparently $(INSTALL_DTBS_PATH) existed during the "-d"
> > check but had gone by the time of the move.
>
> I've already sent a patch several times to remove this line, I believe
> it's finally queued for this merge window.
Yes, as I said further down in my mail:
I understand that the mv bit of the rule in question is likely to be
removed quite soon[1] but I think the underlying race / extra recursion
still exits and might have other implications.
(where [1] was a link to your patch).
I still think it is unexpected (or at least unintended) that this rune
is run in all subdirectories.
Ian.
WARNING: multiple messages have this Message-ID (diff)
From: ijc@debian.org (Ian Campbell)
To: linux-arm-kernel@lists.infradead.org
Subject: dtbs_install recursing on subdirs-y and dtbs-subdir leading to race?
Date: Wed, 16 Mar 2016 09:13:08 +0000 [thread overview]
Message-ID: <1458119588.28250.61.camel@debian.org> (raw)
In-Reply-To: <20160316090449.GW19428@n2100.arm.linux.org.uk>
On Wed, 2016-03-16 at 09:04 +0000, Russell King - ARM Linux wrote:
> On Wed, Mar 16, 2016 at 08:54:34AM +0000, Ian Campbell wrote:
> > Where it appears that multiple instance of __dtbs_install_prep have
> > been running in parallel at least the apm and arm subdirectories of
> > arch/arm64/boot/dts, with both of them then racing in the?
> >?????$(Q)if [ -d $(INSTALL_DTBS_PATH) ]; then mv
> $(INSTALL_DTBS_PATH) $(INSTALL_DTBS_PATH).old; fi
> > rule since apparently $(INSTALL_DTBS_PATH) existed during the "-d"
> > check but had gone by the time of the move.
>
> I've already sent a patch several times to remove this line, I believe
> it's finally queued for this merge window.
Yes, as I said further down in my mail:
I understand that the mv bit of the rule in question is likely to be
removed quite soon[1] but I think the underlying race / extra recursion
still exits and might have other implications.
(where [1] was a link to your patch).
I still think it is unexpected (or at least unintended) that this rune
is run in all subdirectories.
Ian.
WARNING: multiple messages have this Message-ID (diff)
From: Ian Campbell <ijc@debian.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-kbuild@vger.kernel.org, Michal Marek <mmarek@suse.cz>,
devicetree@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Robert Richter <rrichter@cavium.com>,
Ben Hutchings <ben@decadent.org.uk>,
linux-arm-kernel@lists.infradead.org,
debian-kernel <debian-kernel@lists.debian.org>
Subject: Re: dtbs_install recursing on subdirs-y and dtbs-subdir leading to race?
Date: Wed, 16 Mar 2016 09:13:08 +0000 [thread overview]
Message-ID: <1458119588.28250.61.camel@debian.org> (raw)
In-Reply-To: <20160316090449.GW19428@n2100.arm.linux.org.uk>
On Wed, 2016-03-16 at 09:04 +0000, Russell King - ARM Linux wrote:
> On Wed, Mar 16, 2016 at 08:54:34AM +0000, Ian Campbell wrote:
> > Where it appears that multiple instance of __dtbs_install_prep have
> > been running in parallel at least the apm and arm subdirectories of
> > arch/arm64/boot/dts, with both of them then racing in the
> > $(Q)if [ -d $(INSTALL_DTBS_PATH) ]; then mv
> $(INSTALL_DTBS_PATH) $(INSTALL_DTBS_PATH).old; fi
> > rule since apparently $(INSTALL_DTBS_PATH) existed during the "-d"
> > check but had gone by the time of the move.
>
> I've already sent a patch several times to remove this line, I believe
> it's finally queued for this merge window.
Yes, as I said further down in my mail:
I understand that the mv bit of the rule in question is likely to be
removed quite soon[1] but I think the underlying race / extra recursion
still exits and might have other implications.
(where [1] was a link to your patch).
I still think it is unexpected (or at least unintended) that this rune
is run in all subdirectories.
Ian.
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-03-16 9:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 8:54 dtbs_install recursing on subdirs-y and dtbs-subdir leading to race? Ian Campbell
2016-03-16 8:54 ` Ian Campbell
2016-03-16 9:04 ` Russell King - ARM Linux
2016-03-16 9:04 ` Russell King - ARM Linux
2016-03-16 9:04 ` Russell King - ARM Linux
2016-03-16 9:13 ` Ian Campbell [this message]
2016-03-16 9:13 ` Ian Campbell
2016-03-16 9:13 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458119588.28250.61.camel@debian.org \
--to=ijc@debian.org \
--cc=ben@decadent.org.uk \
--cc=catalin.marinas@arm.com \
--cc=debian-kernel@lists.debian.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mmarek@suse.cz \
--cc=rrichter@cavium.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.