diff for duplicates of <1458343221.6622.88.camel@neuling.org> diff --git a/a/1.txt b/N1/1.txt index 7aa3a9f..4a40b36 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,21 +1,21 @@ On Sat, 2016-03-19 at 09:37 +1100, Benjamin Herrenschmidt wrote: > On Fri, 2016-03-18 at 15:04 +1100, Michael Neuling wrote: -> > +> >=20 > > static int nr_chips; > > +static DEFINE_PER_CPU(unsigned int, chip_id); -> > +> > =20 > > /* > > * Note: The set of pstates consists of contiguous integers, the > > @@ -317,9 +318,7 @@ static void powernv_cpufreq_throttle_check(void > > *data) -> > -> > pmsr = get_pmspr(SPRN_PMSR); -> > -> > - for (i = 0; i < nr_chips; i++) -> > - if (chips[i].id == cpu_to_chip_id(cpu)) +> > =20 +> > pmsr =3D get_pmspr(SPRN_PMSR); +> > =20 +> > - for (i =3D 0; i < nr_chips; i++) +> > - if (chips[i].id =3D=3D cpu_to_chip_id(cpu)) > > - break; -> > + i = this_cpu_read(chip_id); -> +> > + i =3D this_cpu_read(chip_id); +>=20 > Except it's not a chip_id, so your patch confused me for a good 2mn > ... > Call it chip_idx maybe ? ie, index. diff --git a/a/content_digest b/N1/content_digest index 9f78f19..ea3c380 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -20,22 +20,22 @@ "b\0" "On Sat, 2016-03-19 at 09:37 +1100, Benjamin Herrenschmidt wrote:\n" "> On Fri, 2016-03-18 at 15:04 +1100, Michael Neuling wrote:\n" - "> > \n" + "> >=20\n" "> > static int nr_chips;\n" "> > +static DEFINE_PER_CPU(unsigned int, chip_id);\n" - "> > \n" + "> > =20\n" "> > /*\n" "> > * Note: The set of pstates consists of contiguous integers, the\n" "> > @@ -317,9 +318,7 @@ static void powernv_cpufreq_throttle_check(void\n" "> > *data)\n" - "> > \n" - "> > pmsr = get_pmspr(SPRN_PMSR);\n" - "> > \n" - "> > - for (i = 0; i < nr_chips; i++)\n" - "> > - if (chips[i].id == cpu_to_chip_id(cpu))\n" + "> > =20\n" + "> > pmsr =3D get_pmspr(SPRN_PMSR);\n" + "> > =20\n" + "> > - for (i =3D 0; i < nr_chips; i++)\n" + "> > - if (chips[i].id =3D=3D cpu_to_chip_id(cpu))\n" "> > - break;\n" - "> > + i = this_cpu_read(chip_id);\n" - "> \n" + "> > + i =3D this_cpu_read(chip_id);\n" + ">=20\n" "> Except it's not a chip_id, so your patch confused me for a good 2mn\n" "> ...\n" "> Call it chip_idx maybe ? ie, index.\n" @@ -47,4 +47,4 @@ "\n" Mikey -17c7f968ad4a15dabef63e531020fff6dd2050ca7386ffaeebfb6477835a610c +258764060ae3832a0d920a55eb0586038bb20100855b0fa79faaa4fee6f4530c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.