From: Michael Neuling <mikey@neuling.org>
To: benh@au1.ibm.com,
Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>,
linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Cc: ego@linux.vnet.ibm.com, linux-pm@vger.kernel.org,
shreyas@linux.vnet.ibm.com, rjw@rjwysocki.net, pc@us.ibm.com,
viresh.kumar@linaro.org, anton@samba.org
Subject: Re: [PATCH v8 3/6] cpufreq: powernv: Remove cpu_to_chip_id() from hot-path
Date: Sat, 19 Mar 2016 10:20:21 +1100 [thread overview]
Message-ID: <1458343221.6622.88.camel@neuling.org> (raw)
In-Reply-To: <1458340635.3107.89.camel@au1.ibm.com>
On Sat, 2016-03-19 at 09:37 +1100, Benjamin Herrenschmidt wrote:
> On Fri, 2016-03-18 at 15:04 +1100, Michael Neuling wrote:
> >
> > static int nr_chips;
> > +static DEFINE_PER_CPU(unsigned int, chip_id);
> >
> > /*
> > * Note: The set of pstates consists of contiguous integers, the
> > @@ -317,9 +318,7 @@ static void powernv_cpufreq_throttle_check(void
> > *data)
> >
> > pmsr = get_pmspr(SPRN_PMSR);
> >
> > - for (i = 0; i < nr_chips; i++)
> > - if (chips[i].id == cpu_to_chip_id(cpu))
> > - break;
> > + i = this_cpu_read(chip_id);
>
> Except it's not a chip_id, so your patch confused me for a good 2mn
> ...
> Call it chip_idx maybe ? ie, index.
Yeah, it was a badly named variable but I changed it even more and
Shilpasri rebased it here:
http://patchwork.ozlabs.org/patch/599523/
Mikey
WARNING: multiple messages have this Message-ID (diff)
From: Michael Neuling <mikey@neuling.org>
To: benh@au1.ibm.com,
Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>,
linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Cc: ego@linux.vnet.ibm.com, linux-pm@vger.kernel.org,
shreyas@linux.vnet.ibm.com, rjw@rjwysocki.net, pc@us.ibm.com,
viresh.kumar@linaro.org, anton@samba.org
Subject: Re: [PATCH v8 3/6] cpufreq: powernv: Remove cpu_to_chip_id() from hot-path
Date: Sat, 19 Mar 2016 10:20:21 +1100 [thread overview]
Message-ID: <1458343221.6622.88.camel@neuling.org> (raw)
In-Reply-To: <1458340635.3107.89.camel@au1.ibm.com>
On Sat, 2016-03-19 at 09:37 +1100, Benjamin Herrenschmidt wrote:
> On Fri, 2016-03-18 at 15:04 +1100, Michael Neuling wrote:
> >=20
> > static int nr_chips;
> > +static DEFINE_PER_CPU(unsigned int, chip_id);
> > =20
> > /*
> > * Note: The set of pstates consists of contiguous integers, the
> > @@ -317,9 +318,7 @@ static void powernv_cpufreq_throttle_check(void
> > *data)
> > =20
> > pmsr =3D get_pmspr(SPRN_PMSR);
> > =20
> > - for (i =3D 0; i < nr_chips; i++)
> > - if (chips[i].id =3D=3D cpu_to_chip_id(cpu))
> > - break;
> > + i =3D this_cpu_read(chip_id);
>=20
> Except it's not a chip_id, so your patch confused me for a good 2mn
> ...
> Call it chip_idx maybe ? ie, index.
Yeah, it was a badly named variable but I changed it even more and
Shilpasri rebased it here:
http://patchwork.ozlabs.org/patch/599523/
Mikey
next prev parent reply other threads:[~2016-03-18 23:20 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 19:41 [PATCH v8 0/6] cpufreq: powernv: Redesign the presentation of throttle notification and solve bug-fixes in the driver Shilpasri G Bhat
2016-02-02 19:41 ` [PATCH v8 1/6] cpufreq: powernv: Free 'chips' on module exit Shilpasri G Bhat
2016-02-02 19:41 ` [PATCH v8 2/6] cpufreq: powernv: Hot-plug safe the kworker thread Shilpasri G Bhat
2016-02-02 19:41 ` [PATCH v8 3/6] cpufreq: powernv: Remove cpu_to_chip_id() from hot-path Shilpasri G Bhat
2016-03-18 4:04 ` Michael Neuling
2016-03-18 4:04 ` Michael Neuling
2016-03-18 4:11 ` Michael Neuling
2016-03-18 4:11 ` Michael Neuling
2016-03-18 13:13 ` Rafael J. Wysocki
2016-03-18 14:58 ` [PATCH] cpufreq: powernv: Define per_cpu chip pointer to optimize hot-path Shilpasri G Bhat
2016-03-21 7:22 ` Viresh Kumar
2016-03-21 14:13 ` Rafael J. Wysocki
2016-03-18 22:37 ` [PATCH v8 3/6] cpufreq: powernv: Remove cpu_to_chip_id() from hot-path Benjamin Herrenschmidt
2016-03-18 23:20 ` Michael Neuling [this message]
2016-03-18 23:20 ` Michael Neuling
2016-02-02 19:41 ` [PATCH v8 4/6] cpufreq: powernv/tracing: Add powernv_throttle tracepoint Shilpasri G Bhat
2016-02-02 19:41 ` [PATCH v8 5/6] cpufreq: powernv: Replace pr_info with trace print for throttle event Shilpasri G Bhat
2016-02-02 19:41 ` [PATCH v8 6/6] cpufreq: powernv: Add sysfs attributes to show throttle stats Shilpasri G Bhat
2016-02-03 8:27 ` Viresh Kumar
2016-02-03 8:42 ` Shilpasri G Bhat
2016-02-03 8:42 ` Shilpasri G Bhat
2016-02-03 9:03 ` Viresh Kumar
2016-02-03 12:02 ` Gautham R Shenoy
2016-02-03 12:02 ` Gautham R Shenoy
2016-02-03 14:06 ` Viresh Kumar
2016-02-03 16:24 ` Shilpasri G Bhat
[not found] ` <56B229C9.4010909-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-02-04 1:51 ` Viresh Kumar
2016-02-04 1:51 ` Viresh Kumar
2016-02-03 13:40 ` [PATCH v8 0/6] cpufreq: powernv: Redesign the presentation of throttle notification and solve bug-fixes in the driver Rafael J. Wysocki
2016-02-03 14:01 ` Viresh Kumar
2016-02-03 16:14 ` Shilpasri G Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458343221.6622.88.camel@neuling.org \
--to=mikey@neuling.org \
--cc=anton@samba.org \
--cc=benh@au1.ibm.com \
--cc=ego@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=pc@us.ibm.com \
--cc=rjw@rjwysocki.net \
--cc=shilpa.bhat@linux.vnet.ibm.com \
--cc=shreyas@linux.vnet.ibm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.