From: Hannes Reinecke <hare@suse.de>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: [PATCH] sd: fixup capacity calculation for 4k drives
Date: Mon, 21 Mar 2016 13:27:29 +0100 [thread overview]
Message-ID: <1458563249-91200-1-git-send-email-hare@suse.de> (raw)
in sd_read_capacity() the sdkp->capacity field changes its meaning:
after the call to read_capacity_XX() it carries the _unscaled_ values,
making the comparison between the original value and the new value
always false for drives with a sector size != 512.
So introduce a 'new_capacity' carrying the new, scaled, capacity.
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
drivers/scsi/sd.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 5a5457a..fbb8daa 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -2312,8 +2312,13 @@ got_data:
}
blk_queue_logical_block_size(sdp->request_queue, sector_size);
+ /*
+ * Note: up to this point sdkp->capacity carries the
+ * _unscaled_ capacity (cf the scaling after this block).
+ */
{
char cap_str_2[10], cap_str_10[10];
+ size_t new_capacity = sdkp->capacity >> (ilog2(sector_size) - 9);
string_get_size(sdkp->capacity, sector_size,
STRING_UNITS_2, cap_str_2, sizeof(cap_str_2));
@@ -2321,7 +2326,7 @@ got_data:
STRING_UNITS_10, cap_str_10,
sizeof(cap_str_10));
- if (sdkp->first_scan || old_capacity != sdkp->capacity) {
+ if (sdkp->first_scan || old_capacity != new_capacity) {
sd_printk(KERN_NOTICE, sdkp,
"%llu %d-byte logical blocks: (%s/%s)\n",
(unsigned long long)sdkp->capacity,
--
1.8.5.6
next reply other threads:[~2016-03-21 12:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 12:27 Hannes Reinecke [this message]
2016-03-21 14:31 ` [PATCH] sd: fixup capacity calculation for 4k drives Christoph Hellwig
2016-03-22 1:16 ` Martin K. Petersen
2016-03-22 6:55 ` Christoph Hellwig
2016-03-22 7:14 ` Hannes Reinecke
2016-03-22 14:16 ` Ewan D. Milne
2016-03-29 1:14 ` Martin K. Petersen
2016-03-29 1:18 ` [PATCH v2] sd: Fix excessive capacity printing on devices with blocks bigger than 512 bytes Martin K. Petersen
2016-03-30 8:06 ` Hannes Reinecke
2016-03-30 16:34 ` Ewan D. Milne
-- strict thread matches above, loose matches on Subject: below --
2016-03-29 8:06 [PATCH] sd: fixup capacity calculation for 4k drives Hannes Reinecke
2016-04-10 2:02 ` Lee Duncan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458563249-91200-1-git-send-email-hare@suse.de \
--to=hare@suse.de \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.